Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1412591 > unrolled thread
| Started by | Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> |
|---|---|
| First post | 2016-06-03 00:40 +0200 |
| Last post | 2016-06-04 01:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] net: ethernet: ti: cpsw: remove unused priv lock Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> - 2016-06-03 00:40 +0200
Re: [PATCH] net: ethernet: ti: cpsw: remove unused priv lock Grygorii Strashko <grygorii.strashko@ti.com> - 2016-06-03 18:50 +0200
Re: [PATCH] net: ethernet: ti: cpsw: remove unused priv lock David Miller <davem@davemloft.net> - 2016-06-04 01:50 +0200
| From | Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> |
|---|---|
| Date | 2016-06-03 00:40 +0200 |
| Subject | [PATCH] net: ethernet: ti: cpsw: remove unused priv lock |
| Message-ID | <rFJrs-3sw-11@gated-at.bofh.it> |
There is no reason in this lock. At least for now.
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
---
Based on master
drivers/net/ethernet/ti/cpsw.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index 9919cb3..8d1d373 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -365,7 +365,6 @@ static inline void slave_write(struct cpsw_slave *slave, u32 val, u32 offset)
}
struct cpsw_priv {
- spinlock_t lock;
struct platform_device *pdev;
struct net_device *ndev;
struct napi_struct napi_rx;
@@ -2413,7 +2412,6 @@ static int cpsw_probe_dual_emac(struct platform_device *pdev,
}
priv_sl2 = netdev_priv(ndev);
- spin_lock_init(&priv_sl2->lock);
priv_sl2->data = *data;
priv_sl2->pdev = pdev;
priv_sl2->ndev = ndev;
@@ -2533,7 +2531,6 @@ static int cpsw_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, ndev);
priv = netdev_priv(ndev);
- spin_lock_init(&priv->lock);
priv->pdev = pdev;
priv->ndev = ndev;
priv->dev = &ndev->dev;
--
1.9.1
[toc] | [next] | [standalone]
| From | Grygorii Strashko <grygorii.strashko@ti.com> |
|---|---|
| Date | 2016-06-03 18:50 +0200 |
| Message-ID | <rG0si-5FK-31@gated-at.bofh.it> |
| In reply to | #1412591 |
On 06/03/2016 01:37 AM, Ivan Khoronzhuk wrote:
> There is no reason in this lock. At least for now.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> ---
>
> Based on master
>
> drivers/net/ethernet/ti/cpsw.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index 9919cb3..8d1d373 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -365,7 +365,6 @@ static inline void slave_write(struct cpsw_slave *slave, u32 val, u32 offset)
> }
>
> struct cpsw_priv {
> - spinlock_t lock;
> struct platform_device *pdev;
> struct net_device *ndev;
> struct napi_struct napi_rx;
> @@ -2413,7 +2412,6 @@ static int cpsw_probe_dual_emac(struct platform_device *pdev,
> }
>
> priv_sl2 = netdev_priv(ndev);
> - spin_lock_init(&priv_sl2->lock);
> priv_sl2->data = *data;
> priv_sl2->pdev = pdev;
> priv_sl2->ndev = ndev;
> @@ -2533,7 +2531,6 @@ static int cpsw_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, ndev);
> priv = netdev_priv(ndev);
> - spin_lock_init(&priv->lock);
> priv->pdev = pdev;
> priv->ndev = ndev;
> priv->dev = &ndev->dev;
>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
regards,
-grygorii
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-06-04 01:50 +0200 |
| Message-ID | <rG70J-1fx-3@gated-at.bofh.it> |
| In reply to | #1412591 |
From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> Date: Fri, 3 Jun 2016 01:37:08 +0300 > There is no reason in this lock. At least for now. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> Applied to net-next.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web