Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1410016 > unrolled thread

[RFC PATCH 0/2] Remove and replace SD_WAKE_AFFINE with SD_BALANCE_WAKE

Started byYuyang Du <yuyang.du@intel.com>
First post2016-05-31 11:10 +0200
Last post2016-05-31 11:30 +0200
Articles 2 on this page of 22 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [RFC PATCH 0/2] Remove and replace SD_WAKE_AFFINE with SD_BALANCE_WAKE Yuyang Du <yuyang.du@intel.com> - 2016-05-31 11:10 +0200
    [RFC PATCH 2/2] sched: Remove SD_WAKE_AFFINE flag and replace it with SD_BALANCE_WAKE Yuyang Du <yuyang.du@intel.com> - 2016-05-31 11:10 +0200
      Re: [RFC PATCH 2/2] sched: Remove SD_WAKE_AFFINE flag and replace it  with SD_BALANCE_WAKE Peter Zijlstra <peterz@infradead.org> - 2016-05-31 11:30 +0200
        Re: [RFC PATCH 2/2] sched: Remove SD_WAKE_AFFINE flag and replace it  with SD_BALANCE_WAKE Yuyang Du <yuyang.du@intel.com> - 2016-05-31 11:40 +0200
    [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-05-31 11:10 +0200
      Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-05-31 11:30 +0200
        Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Peter Zijlstra <peterz@infradead.org> - 2016-05-31 12:50 +0200
          Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-01 04:00 +0200
        Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-01 07:10 +0200
          Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-01 10:00 +0200
            Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Vincent Guittot <vincent.guittot@linaro.org> - 2016-06-01 10:40 +0200
              Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-01 11:10 +0200
                Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Vincent Guittot <vincent.guittot@linaro.org> - 2016-06-01 11:30 +0200
                  Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-02 05:40 +0200
                    Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Vincent Guittot <vincent.guittot@linaro.org> - 2016-06-02 09:00 +0200
                      Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-02 09:20 +0200
            Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-01 11:40 +0200
              Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-02 06:10 +0200
                Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-02 08:00 +0200
                  Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-02 08:40 +0200
                    Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-02 08:50 +0200
      Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Peter Zijlstra <peterz@infradead.org> - 2016-05-31 11:30 +0200

Page 2 of 2 — ← Prev page 1 [2]

#1411906 — Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up

FromMike Galbraith <umgwanakikbuti@gmail.com>
Date2016-06-02 08:50 +0200
SubjectRe: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up
Message-ID<rFuC5-2sz-9@gated-at.bofh.it>
In reply to#1411886
On Thu, 2016-06-02 at 06:41 +0800, Yuyang Du wrote:

> Again, agreed, and with this patch, just disable SD_BALANCE_WAKE. :)

Yeah, we pretty much agree on everything.. other than whether you shoul
d be picking on poor defenseless little SD_WAKE_AFFINE or not :^)

	-Mike

[toc] | [prev] | [next] | [standalone]

#1410032 — Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up

FromPeter Zijlstra <peterz@infradead.org>
Date2016-05-31 11:30 +0200
SubjectRe: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up
Message-ID<rEO9P-Rc-7@gated-at.bofh.it>
In reply to#1410018
On Tue, May 31, 2016 at 09:11:37AM +0800, Yuyang Du wrote:
> The SD_BALANCE_WAKE is irrelevant in the contexts of these two removals,
> and in addition SD_BALANCE_WAKE is not and should not be set in any
> sched_domain flags so far.

This Changelog doesn't make any sense...

> Signed-off-by: Yuyang Du <yuyang.du@intel.com>
> ---
>  kernel/sched/core.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 7f2cae4..e00b8ea 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -6229,10 +6229,10 @@ static void set_domain_attribute(struct sched_domain *sd,
>  		request = attr->relax_domain_level;
>  	if (request < sd->level) {
>  		/* turn off idle balance on this domain */
> -		sd->flags &= ~(SD_BALANCE_WAKE|SD_BALANCE_NEWIDLE);
> +		sd->flags &= ~(SD_BALANCE_NEWIDLE);
>  	} else {
>  		/* turn on idle balance on this domain */
> -		sd->flags |= (SD_BALANCE_WAKE|SD_BALANCE_NEWIDLE);
> +		sd->flags |= (SD_BALANCE_NEWIDLE);
>  	}
>  }
>  
> -- 
> 1.7.9.5
>

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web