Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1411232 > unrolled thread
| Started by | Christoph Hellwig <hch@infradead.org> |
|---|---|
| First post | 2016-06-01 15:50 +0200 |
| Last post | 2016-06-02 05:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v6 5/8] fs: xfs: replace BIO_MAX_SECTORS with BIO_MAX_PAGES Christoph Hellwig <hch@infradead.org> - 2016-06-01 15:50 +0200
Re: [PATCH v6 5/8] fs: xfs: replace BIO_MAX_SECTORS with BIO_MAX_PAGES Ming Lei <ming.lei@canonical.com> - 2016-06-02 05:40 +0200
| From | Christoph Hellwig <hch@infradead.org> |
|---|---|
| Date | 2016-06-01 15:50 +0200 |
| Subject | Re: [PATCH v6 5/8] fs: xfs: replace BIO_MAX_SECTORS with BIO_MAX_PAGES |
| Message-ID | <rFeH0-BQ-9@gated-at.bofh.it> |
On Mon, May 30, 2016 at 09:34:33PM +0800, Ming Lei wrote: > diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c > index e71cfbd..e5d713b 100644 > --- a/fs/xfs/xfs_buf.c > +++ b/fs/xfs/xfs_buf.c > @@ -1157,9 +1157,7 @@ xfs_buf_ioapply_map( > > next_chunk: > atomic_inc(&bp->b_io_remaining); > - nr_pages = BIO_MAX_SECTORS >> (PAGE_SHIFT - BBSHIFT); > - if (nr_pages > total_nr_pages) > - nr_pages = total_nr_pages; > + nr_pages = min(total_nr_pages, BIO_MAX_PAGES); > > bio = bio_alloc(GFP_NOIO, nr_pages); While I think this is a useful cleanup on it's own I think you'd make everyones life easier if bio_alloc simply clamped down the passed nr_pages value to the maximum allowed.
[toc] | [next] | [standalone]
| From | Ming Lei <ming.lei@canonical.com> |
|---|---|
| Date | 2016-06-02 05:40 +0200 |
| Subject | Re: [PATCH v6 5/8] fs: xfs: replace BIO_MAX_SECTORS with BIO_MAX_PAGES |
| Message-ID | <rFrEd-Dz-1@gated-at.bofh.it> |
| In reply to | #1411232 |
On Wed, Jun 1, 2016 at 9:48 PM, Christoph Hellwig <hch@infradead.org> wrote: > On Mon, May 30, 2016 at 09:34:33PM +0800, Ming Lei wrote: >> diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c >> index e71cfbd..e5d713b 100644 >> --- a/fs/xfs/xfs_buf.c >> +++ b/fs/xfs/xfs_buf.c >> @@ -1157,9 +1157,7 @@ xfs_buf_ioapply_map( >> >> next_chunk: >> atomic_inc(&bp->b_io_remaining); >> - nr_pages = BIO_MAX_SECTORS >> (PAGE_SHIFT - BBSHIFT); >> - if (nr_pages > total_nr_pages) >> - nr_pages = total_nr_pages; >> + nr_pages = min(total_nr_pages, BIO_MAX_PAGES); >> >> bio = bio_alloc(GFP_NOIO, nr_pages); > > While I think this is a useful cleanup on it's own I think > you'd make everyones life easier if bio_alloc simply clamped down > the passed nr_pages value to the maximum allowed. Yes, that looks a good cleanup, but need be careful because the passed 'nr_pages' can be used after returning from bio_alloc() in the current function, and it is easy to see this usage. So we can do that in another patchset instead of this one. Thanks, > -- > To unsubscribe from this list: send the line "unsubscribe linux-block" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web