Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1411417 > unrolled thread
| Started by | John Stultz <john.stultz@linaro.org> |
|---|---|
| First post | 2016-06-01 19:40 +0200 |
| Last post | 2016-06-02 19:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[RFC][PATCH 2/2] arm64: dts: hi6220: Add pl031 RTC support John Stultz <john.stultz@linaro.org> - 2016-06-01 19:40 +0200
Re: [RFC][PATCH 2/2] arm64: dts: hi6220: Add pl031 RTC support Guodong Xu <guodong.xu@linaro.org> - 2016-06-02 06:00 +0200
Re: [RFC][PATCH 2/2] arm64: dts: hi6220: Add pl031 RTC support John Stultz <john.stultz@linaro.org> - 2016-06-02 19:20 +0200
| From | John Stultz <john.stultz@linaro.org> |
|---|---|
| Date | 2016-06-01 19:40 +0200 |
| Subject | [RFC][PATCH 2/2] arm64: dts: hi6220: Add pl031 RTC support |
| Message-ID | <rFihA-2VQ-5@gated-at.bofh.it> |
From: Zhangfei Gao <zhangfei.gao@linaro.org>
Add pl031 rtc0 support to hi6220 dtsi
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Wei Xu <xuwei5@hisilicon.com>
Cc: Guodong Xu <guodong.xu@linaro.org>
Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
[jstultz: Forward ported and tweaked commit description]
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
index 189d215..1288995 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
@@ -336,6 +336,14 @@
clock-names = "timer1", "timer2", "apb_pclk";
};
+ rtc0: rtc@170000 {
+ compatible = "arm,pl031", "arm,primecell";
+ reg = <0x0 0xf8003000 0x0 0x1000>;
+ interrupts = <0 12 4>;
+ clocks = <&ao_ctrl HI6220_RTC0_PCLK>;
+ clock-names = "apb_pclk";
+ };
+
pmx0: pinmux@f7010000 {
compatible = "pinctrl-single";
reg = <0x0 0xf7010000 0x0 0x27c>;
--
1.9.1
[toc] | [next] | [standalone]
| From | Guodong Xu <guodong.xu@linaro.org> |
|---|---|
| Date | 2016-06-02 06:00 +0200 |
| Message-ID | <rFrXz-JG-1@gated-at.bofh.it> |
| In reply to | #1411417 |
On 2 June 2016 at 01:39, John Stultz <john.stultz@linaro.org> wrote:
> From: Zhangfei Gao <zhangfei.gao@linaro.org>
>
> Add pl031 rtc0 support to hi6220 dtsi
>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Cc: Guodong Xu <guodong.xu@linaro.org>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> [jstultz: Forward ported and tweaked commit description]
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 189d215..1288995 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -336,6 +336,14 @@
> clock-names = "timer1", "timer2", "apb_pclk";
> };
>
> + rtc0: rtc@170000 {
> + compatible = "arm,pl031", "arm,primecell";
> + reg = <0x0 0xf8003000 0x0 0x1000>;
> + interrupts = <0 12 4>;
> + clocks = <&ao_ctrl HI6220_RTC0_PCLK>;
> + clock-names = "apb_pclk";
> + };
> +
Hi, John
Checked from Hi6220 spec, and verified on HiKey:
+ rtc1: rtc@f8004000 {
+ compatible = "arm,pl031", "arm,primecell";
+ reg = <0x0 0xf8004000 0x0 0x1000>;
+ interrupts = <0 8 4>;
+ clocks = <&ao_ctrl HI6220_RTC1_PCLK>;
+ clock-names = "apb_pclk";
+ };
+
Would you please append that into the patch?
-Guodong
> pmx0: pinmux@f7010000 {
> compatible = "pinctrl-single";
> reg = <0x0 0xf7010000 0x0 0x27c>;
> --
> 1.9.1
>
[toc] | [prev] | [next] | [standalone]
| From | John Stultz <john.stultz@linaro.org> |
|---|---|
| Date | 2016-06-02 19:20 +0200 |
| Message-ID | <rFErM-fL-19@gated-at.bofh.it> |
| In reply to | #1411801 |
On Wed, Jun 1, 2016 at 8:58 PM, Guodong Xu <guodong.xu@linaro.org> wrote:
> On 2 June 2016 at 01:39, John Stultz <john.stultz@linaro.org> wrote:
>> From: Zhangfei Gao <zhangfei.gao@linaro.org>
>>
>> Add pl031 rtc0 support to hi6220 dtsi
>>
>> Cc: Michael Turquette <mturquette@baylibre.com>
>> Cc: Stephen Boyd <sboyd@codeaurora.org>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Pawel Moll <pawel.moll@arm.com>
>> Cc: Wei Xu <xuwei5@hisilicon.com>
>> Cc: Guodong Xu <guodong.xu@linaro.org>
>> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
>> [jstultz: Forward ported and tweaked commit description]
>> Signed-off-by: John Stultz <john.stultz@linaro.org>
>> ---
>> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> index 189d215..1288995 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> @@ -336,6 +336,14 @@
>> clock-names = "timer1", "timer2", "apb_pclk";
>> };
>>
>> + rtc0: rtc@170000 {
>> + compatible = "arm,pl031", "arm,primecell";
>> + reg = <0x0 0xf8003000 0x0 0x1000>;
>> + interrupts = <0 12 4>;
>> + clocks = <&ao_ctrl HI6220_RTC0_PCLK>;
>> + clock-names = "apb_pclk";
>> + };
>> +
>
> Hi, John
>
> Checked from Hi6220 spec, and verified on HiKey:
>
> + rtc1: rtc@f8004000 {
> + compatible = "arm,pl031", "arm,primecell";
> + reg = <0x0 0xf8004000 0x0 0x1000>;
> + interrupts = <0 8 4>;
> + clocks = <&ao_ctrl HI6220_RTC1_PCLK>;
> + clock-names = "apb_pclk";
> + };
> +
>
> Would you please append that into the patch?
Sure. I also noticed the node offset for rtc0 doesn't match the
register, so I corrected it as well.
thanks
-john
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web