Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1411380 > unrolled thread
| Started by | Kangjie Lu <kangjielu@gmail.com> |
|---|---|
| First post | 2016-06-01 18:20 +0200 |
| Last post | 2016-06-02 08:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] net: fix potential infoleak in rds_inc_info_copy Kangjie Lu <kangjielu@gmail.com> - 2016-06-01 18:20 +0200
Re: [PATCH] net: fix potential infoleak in rds_inc_info_copy David Miller <davem@davemloft.net> - 2016-06-02 08:40 +0200
| From | Kangjie Lu <kangjielu@gmail.com> |
|---|---|
| Date | 2016-06-01 18:20 +0200 |
| Subject | [PATCH] net: fix potential infoleak in rds_inc_info_copy |
| Message-ID | <rFh2a-2cp-35@gated-at.bofh.it> |
The last field "flags" of object "minfo" is not initialized. Copying this object out may leak kernel stack data. Assign 0 to it to avoid leak. Signed-off-by: Kangjie Lu <kjlu@gatech.edu> --- net/rds/recv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/rds/recv.c b/net/rds/recv.c index c0be1ec..8413f6c 100644 --- a/net/rds/recv.c +++ b/net/rds/recv.c @@ -561,5 +561,7 @@ void rds_inc_info_copy(struct rds_incoming *inc, minfo.fport = inc->i_hdr.h_dport; } + minfo.flags = 0; + rds_info_copy(iter, &minfo, sizeof(minfo)); } -- 2.7.4
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-06-02 08:40 +0200 |
| Message-ID | <rFusq-2oO-47@gated-at.bofh.it> |
| In reply to | #1411380 |
From: Kangjie Lu <kangjielu@gmail.com> Date: Wed, 1 Jun 2016 12:11:16 -0400 > The last field "flags" of object "minfo" is not initialized. > Copying this object out may leak kernel stack data. > Assign 0 to it to avoid leak. > > Signed-off-by: Kangjie Lu <kjlu@gatech.edu> The correct subsystem prefix is "rds: ". Please resubmit this patch with your Subject corrected thusly. Thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web