Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1411237 > unrolled thread

[PATCH] usb: musb_host: Use sizeof(*qh)instead of sizeof *qh.

Started bySandhya Bankar <bankarsandhya512@gmail.com>
First post2016-06-01 15:50 +0200
Last post2016-06-02 23:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] usb: musb_host: Use sizeof(*qh)instead of sizeof *qh. Sandhya Bankar <bankarsandhya512@gmail.com> - 2016-06-01 15:50 +0200
    Re: [PATCH] usb: musb_host: Use sizeof(*qh)instead of sizeof *qh. Bin Liu <b-liu@ti.com> - 2016-06-02 23:40 +0200

#1411237 — [PATCH] usb: musb_host: Use sizeof(*qh)instead of sizeof *qh.

FromSandhya Bankar <bankarsandhya512@gmail.com>
Date2016-06-01 15:50 +0200
Subject[PATCH] usb: musb_host: Use sizeof(*qh)instead of sizeof *qh.
Message-ID<rFeH0-BQ-21@gated-at.bofh.it>
Use sizeof(*qh)instead of sizeof *qh.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/usb/musb/musb_host.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index 2f8ad7f..72121fe 100644
--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
@@ -2228,7 +2228,7 @@ static int musb_urb_enqueue(
 	 * REVISIT consider a dedicated qh kmem_cache, so it's harder
 	 * for bugs in other kernel code to break this driver...
 	 */
-	qh = kzalloc(sizeof *qh, mem_flags);
+	qh = kzalloc(sizeof(*qh), mem_flags);
 	if (!qh) {
 		spin_lock_irqsave(&musb->lock, flags);
 		usb_hcd_unlink_urb_from_ep(hcd, urb);
-- 
1.8.3.4

[toc] | [next] | [standalone]


#1412567

FromBin Liu <b-liu@ti.com>
Date2016-06-02 23:40 +0200
Message-ID<rFIvo-2TE-11@gated-at.bofh.it>
In reply to#1411237
Hi,

On Wed, Jun 01, 2016 at 09:40:06AM -0400, Sandhya Bankar wrote:
> Use sizeof(*qh)instead of sizeof *qh.
> 
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>

Please revise the subject prefix to "usb: musb: host: ...".

Regards,
-Bin.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web