Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1411110 > unrolled thread

[PATCH v2] ARM: uniphier: drop code for old DT binding

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] ARM: uniphier: drop code for old DT binding Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-06-01 13:40 +0200
    Re: [PATCH v2] ARM: uniphier: drop code for old DT binding Olof Johansson <olof@lixom.net> - 2016-06-03 22:00 +0200

#1411110 — [PATCH v2] ARM: uniphier: drop code for old DT binding

Commit 307d40c56b0c ("ARM: uniphier: rework SMP code to support new
System Bus binding") added a new DT binding for SMP code, but still
kept old code for the backward compatibility.

Linux 4.6 was out with both bindings supported, so it should not
hurt to drop the old code now.  Moreover, the mainline code are
currently not used for any of our products, so this change has
no impact on our customers in any way.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

Changes in v2:
  - Add more explanation in git-log

 arch/arm/mach-uniphier/platsmp.c | 18 +++++-------------
 1 file changed, 5 insertions(+), 13 deletions(-)

diff --git a/arch/arm/mach-uniphier/platsmp.c b/arch/arm/mach-uniphier/platsmp.c
index e802ca8..9978c41 100644
--- a/arch/arm/mach-uniphier/platsmp.c
+++ b/arch/arm/mach-uniphier/platsmp.c
@@ -101,21 +101,13 @@ static int __init uniphier_smp_prepare_trampoline(unsigned int max_cpus)
 	np = of_find_compatible_node(NULL, NULL, "socionext,uniphier-smpctrl");
 	ret = of_address_to_resource(np, 0, &res);
 	of_node_put(np);
-	if (!ret) {
-		rom_rsv2_phys = res.start + UNIPHIER_SMPCTRL_ROM_RSV2;
-	} else {
-		/* try old binding too */
-		np = of_find_compatible_node(NULL, NULL,
-					     "socionext,uniphier-system-bus-controller");
-		ret = of_address_to_resource(np, 1, &res);
-		of_node_put(np);
-		if (ret) {
-			pr_err("failed to get resource of SMP control\n");
-			return ret;
-		}
-		rom_rsv2_phys = res.start + 0x1000 + UNIPHIER_SMPCTRL_ROM_RSV2;
+	if (ret) {
+		pr_err("failed to get resource of SMP control\n");
+		return ret;
 	}
 
+	rom_rsv2_phys = res.start + UNIPHIER_SMPCTRL_ROM_RSV2;
+
 	ret = uniphier_smp_copy_trampoline(rom_rsv2_phys);
 	if (ret)
 		return ret;
-- 
1.9.1

[toc] | [next] | [standalone]

#1413424

On Wed, Jun 01, 2016 at 08:37:46PM +0900, Masahiro Yamada wrote:
> Commit 307d40c56b0c ("ARM: uniphier: rework SMP code to support new
> System Bus binding") added a new DT binding for SMP code, but still
> kept old code for the backward compatibility.
> 
> Linux 4.6 was out with both bindings supported, so it should not
> hurt to drop the old code now.  Moreover, the mainline code are
> currently not used for any of our products, so this change has
> no impact on our customers in any way.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
> Changes in v2:
>   - Add more explanation in git-log

Thanks, applied to next/cleanup for 4.8.


-Olof

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web