Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1413127 > unrolled thread

[PATCH v2] tty:serial:msm:Do not restore Rx interrupts in DMA

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2] tty:serial:msm:Do not restore Rx interrupts in DMA Charanya Venkatraman <charanya@codeaurora.org> - 2016-06-03 13:20 +0200
    Re: [PATCH v2] tty:serial:msm:Do not restore Rx interrupts in DMA Greg KH <gregkh@linuxfoundation.org> - 2016-06-03 17:50 +0200

#1413127 — [PATCH v2] tty:serial:msm:Do not restore Rx interrupts in DMA

From: Charanya <charanya@codeaurora.org>

Avoid data corruption issues that result in
CRC erros during file transfers over serial ports
at higher baud rates.

The current msm_serial driver masks the FIFO Rx
interrupts in msm_start_rx_dma() since Rx FIFO
interrupts are not required in DMA mode. However,
msm_complete_rx_dma() renables the Rx FIFO interrupt
which could cause RXSTALE event to be processed
when a TXLEV interrupt occurs.

The following is the sequence of events that
could occur resulting in data corruption

msm_start_rx_dma -> msm_complete_rx_dma -->
spin_unlock_irqrestore(&port->lock) -->  msm_uart_irq()
(For TXLEV interrupt) -->  msm_handle_rx_dm() (Read
from FIFO resulting in data corruption)

The patch fixes the issue by not restoring the RXLEV
and RXSTALE interrupts in msm_complete_rx_dma(). These
interrupts are required only in FIFO mode.

Signed-off-by: Charanya Venkatraman <charanya@codeaurora.org>
---
 drivers/tty/serial/msm_serial.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
index b7d80bd..646aa3f 100644
--- a/drivers/tty/serial/msm_serial.c
+++ b/drivers/tty/serial/msm_serial.c
@@ -388,10 +388,6 @@ static void msm_complete_rx_dma(void *args)
 	val &= ~dma->enable_bit;
 	msm_write(port, val, UARTDM_DMEN);
 
-	/* Restore interrupts */
-	msm_port->imr |= UART_IMR_RXLEV | UART_IMR_RXSTALE;
-	msm_write(port, msm_port->imr, UART_IMR);
-
 	if (msm_read(port, UART_SR) & UART_SR_OVERRUN) {
 		port->icount.overrun++;
 		tty_insert_flip_char(tport, 0, TTY_OVERRUN);
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [next] | [standalone]

#1413315

On Fri, Jun 03, 2016 at 04:40:32PM +0530, Charanya Venkatraman wrote:
> From: Charanya <charanya@codeaurora.org>

This name must match up with your Signed-off-by name :(

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web