Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1413153 > unrolled thread

[PATCH] usb: dwc3: host: Set the dma_ops for xhci device

Back to article view | Back to linux.kernel

Contents

  [PATCH] usb: dwc3: host: Set the dma_ops for xhci device Baolin Wang <baolin.wang@linaro.org> - 2016-06-03 14:00 +0200
    Re: [PATCH] usb: dwc3: host: Set the dma_ops for xhci device kbuild test robot <lkp@intel.com> - 2016-06-03 14:50 +0200

#1413153 — [PATCH] usb: dwc3: host: Set the dma_ops for xhci device

It will be failed when xhci device set the dma mask, if the xhci device
dma_ops is dummy. Thus set the xhci device dma_ops from the parent device.

Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
 drivers/usb/dwc3/host.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index c679f63..7ce55c9 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -32,6 +32,9 @@ int dwc3_host_init(struct dwc3 *dwc)
 		return -ENOMEM;
 	}
 
+	if (get_dma_ops(&xhci->dev) == get_dma_ops(NULL))
+		xhci->dev.archdata.dma_ops = get_dma_ops(dwc->dev);
+
 	dma_set_coherent_mask(&xhci->dev, dwc->dev->coherent_dma_mask);
 
 	xhci->dev.parent	= dwc->dev;
-- 
1.7.9.5

[toc] | [next] | [standalone]

#1413208

[Multipart message — attachments visible in raw view] — view raw

Hi,

[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.7-rc1 next-20160603]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Baolin-Wang/usb-dwc3-host-Set-the-dma_ops-for-xhci-device/20160603-195855
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: i386-randconfig-i1-201622 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/usb/dwc3/host.c: In function 'dwc3_host_init':
>> drivers/usb/dwc3/host.c:36:21: error: 'struct dev_archdata' has no member named 'dma_ops'
      xhci->dev.archdata.dma_ops = get_dma_ops(dwc->dev);
                        ^

vim +36 drivers/usb/dwc3/host.c

    30		if (!xhci) {
    31			dev_err(dwc->dev, "couldn't allocate xHCI device\n");
    32			return -ENOMEM;
    33		}
    34	
    35		if (get_dma_ops(&xhci->dev) == get_dma_ops(NULL))
  > 36			xhci->dev.archdata.dma_ops = get_dma_ops(dwc->dev);
    37	
    38		dma_set_coherent_mask(&xhci->dev, dwc->dev->coherent_dma_mask);
    39	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web