Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1412108 > unrolled thread

[RFC PATCH v1 0/3] regulator: qcom_smd: add list_voltage callback support.

Back to article view | Back to linux.kernel

Contents

  [RFC PATCH v1 0/3] regulator: qcom_smd: add list_voltage callback support. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-06-02 12:30 +0200
    [RFC PATCH v1 2/3] regulator: qcom_smd: add list_voltage callback Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-06-02 12:30 +0200
      Re: [RFC PATCH v1 2/3] regulator: qcom_smd: add list_voltage callback Mark Brown <broonie@kernel.org> - 2016-06-03 12:50 +0200
        Re: [RFC PATCH v1 2/3] regulator: qcom_smd: add list_voltage callback Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-06-03 13:30 +0200

#1412108 — [RFC PATCH v1 0/3] regulator: qcom_smd: add list_voltage callback support.

This patchset adds list_voltage callback support to qcom smd regulator driver.
One of the helper patch modifies the existing list_voltage_linear_range()
callback to consider voltage constriants, so that the consumers get the
actual supported voltage range information.

Without this patchset, I was unable to get SD card working with the
mainline kernel on DB410c.

Thanks,
srini

Srinivas Kandagatla (3):
  regulator: helpers: consider constriants in list_voltage_linear_range
  regulator: qcom_smd: add list_voltage callback
  regulator: qcom_smd: add linear range to pm8941 lnldo

 drivers/regulator/helpers.c            | 10 ++++++++--
 drivers/regulator/qcom_smd-regulator.c |  6 +++++-
 2 files changed, 13 insertions(+), 3 deletions(-)

--
2.8.2

[toc] | [next] | [standalone]

#1412109 — [RFC PATCH v1 2/3] regulator: qcom_smd: add list_voltage callback

This patch adds support to list_voltage callback, so that consumers
like mmc core, can get information of supported voltage range.

Without this patch there is no way for mmc core to know this voltage range.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 drivers/regulator/qcom_smd-regulator.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
index 56a17ec..b11b627 100644
--- a/drivers/regulator/qcom_smd-regulator.c
+++ b/drivers/regulator/qcom_smd-regulator.c
@@ -140,6 +140,7 @@ static const struct regulator_ops rpm_smps_ldo_ops = {
 	.enable = rpm_reg_enable,
 	.disable = rpm_reg_disable,
 	.is_enabled = rpm_reg_is_enabled,
+	.list_voltage = regulator_list_voltage_linear_range,
 
 	.get_voltage = rpm_reg_get_voltage,
 	.set_voltage = rpm_reg_set_voltage,
-- 
2.8.2

[toc] | [prev] | [next] | [standalone]

#1413041 — Re: [RFC PATCH v1 2/3] regulator: qcom_smd: add list_voltage callback

[Multipart message — attachments visible in raw view] — view raw

On Thu, Jun 02, 2016 at 11:23:15AM +0100, Srinivas Kandagatla wrote:
> This patch adds support to list_voltage callback, so that consumers
> like mmc core, can get information of supported voltage range.
> 
> Without this patch there is no way for mmc core to know this voltage range.

Something I applied yesterday, most likely this, seems to have broken
boot on a large proportion of (potentially all) 32 bit Qualcomm
platforms:

   https://kernelci.org/boot/all/job/broonie-regulator/kernel/v4.7-rc1-10-gafafb91512cf/

I suspect this is because the fixed voltage regulator is triggering a
crash as it has no linear ranges defined.  Please get me a fix ASAP.

[toc] | [prev] | [next] | [standalone]

#1413142 — Re: [RFC PATCH v1 2/3] regulator: qcom_smd: add list_voltage callback

On 03/06/16 11:40, Mark Brown wrote:
> On Thu, Jun 02, 2016 at 11:23:15AM +0100, Srinivas Kandagatla wrote:
>> This patch adds support to list_voltage callback, so that consumers
>> like mmc core, can get information of supported voltage range.
>>
>> Without this patch there is no way for mmc core to know this voltage range.
>
> Something I applied yesterday, most likely this, seems to have broken
> boot on a large proportion of (potentially all) 32 bit Qualcomm
> platforms:
>
>     https://kernelci.org/boot/all/job/broonie-regulator/kernel/v4.7-rc1-10-gafafb91512cf/
>
> I suspect this is because the fixed voltage regulator is triggering a
> crash as it has no linear ranges defined.  Please get me a fix ASAP.
Yes, looks like it is because of the fixed regulator thing, I send a 
patch with separate ops for this.

--srini
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web