Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1412889 > unrolled thread
| Started by | John Crispin <john@phrozen.org> |
|---|---|
| First post | 2016-06-03 10:20 +0200 |
| Last post | 2016-06-04 02:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH V4 0/4] net-next: mediatek: improve phy support John Crispin <john@phrozen.org> - 2016-06-03 10:20 +0200
[PATCH V4 3/4] net-next: mediatek: add fixed-phy support John Crispin <john@phrozen.org> - 2016-06-03 10:20 +0200
Re: [PATCH V4 0/4] net-next: mediatek: improve phy support David Miller <davem@davemloft.net> - 2016-06-04 02:00 +0200
| From | John Crispin <john@phrozen.org> |
|---|---|
| Date | 2016-06-03 10:20 +0200 |
| Subject | [PATCH V4 0/4] net-next: mediatek: improve phy support |
| Message-ID | <rFSuJ-Jx-3@gated-at.bofh.it> |
The current driver did not handle the RGMII delay modes and asymmetric flow control properly. The mii_bus is not freed properly. Also add support for fixed-phy allowing the driver to work on SoCs that have an internal gigabit switch. John Crispin (4): net-next: mediatek: use mdiobus_free() in favour of kfree() net-next: mediatek: fix gigabit and flow control advertisement net-next: mediatek: add fixed-phy support net-next: mediatek: properly handle RGMII modes drivers/net/ethernet/mediatek/mtk_eth_soc.c | 40 +++++++++++++++++++++++---- 1 file changed, 34 insertions(+), 6 deletions(-) -- 1.7.10.4
[toc] | [next] | [standalone]
| From | John Crispin <john@phrozen.org> |
|---|---|
| Date | 2016-06-03 10:20 +0200 |
| Subject | [PATCH V4 3/4] net-next: mediatek: add fixed-phy support |
| Message-ID | <rFSuJ-Jx-17@gated-at.bofh.it> |
| In reply to | #1412889 |
The MT7623 SoC has a builtin gigabit switch. If we want to use it, GMAC1 needs to be configured using a fixed link speed and flow control settings. The easiest way to do this is to used the fixed-phy driver, allowing us to reuse the existing mdio polling code to setup the MAC. Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: John Crispin <john@phrozen.org> --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index b0652f6..231d284 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -229,6 +229,9 @@ static int mtk_phy_connect(struct mtk_mac *mac) u32 val, ge_mode; np = of_parse_phandle(mac->of_node, "phy-handle", 0); + if (!np && of_phy_is_fixed_link(mac->of_node)) + if (!of_phy_register_fixed_link(mac->of_node)) + np = of_node_get(mac->of_node); if (!np) return -ENODEV; -- 1.7.10.4
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-06-04 02:00 +0200 |
| Subject | Re: [PATCH V4 0/4] net-next: mediatek: improve phy support |
| Message-ID | <rG7ap-1iQ-3@gated-at.bofh.it> |
| In reply to | #1412889 |
From: John Crispin <john@phrozen.org> Date: Fri, 3 Jun 2016 10:17:05 +0200 > The current driver did not handle the RGMII delay modes and asymmetric flow > control properly. The mii_bus is not freed properly. Also add support for > fixed-phy allowing the driver to work on SoCs that have an internal gigabit > switch. Series applied, thanks John.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web