Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1411987 > unrolled thread
| Started by | Kangjie Lu <kangjielu@gmail.com> |
|---|---|
| First post | 2016-06-02 10:20 +0200 |
| Last post | 2016-06-03 06:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] rds: fix an infoleak in rds_inc_info_copy Kangjie Lu <kangjielu@gmail.com> - 2016-06-02 10:20 +0200
Re: [PATCH] rds: fix an infoleak in rds_inc_info_copy Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-06-02 17:30 +0200
Re: [PATCH] rds: fix an infoleak in rds_inc_info_copy David Miller <davem@davemloft.net> - 2016-06-03 06:40 +0200
| From | Kangjie Lu <kangjielu@gmail.com> |
|---|---|
| Date | 2016-06-02 10:20 +0200 |
| Subject | [PATCH] rds: fix an infoleak in rds_inc_info_copy |
| Message-ID | <rFw1c-3rP-19@gated-at.bofh.it> |
The last field "flags" of object "minfo" is not initialized. Copying this object out may leak kernel stack data. Assign 0 to it to avoid leak. Signed-off-by: Kangjie Lu <kjlu@gatech.edu> --- net/rds/recv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/rds/recv.c b/net/rds/recv.c index c0be1ec..8413f6c 100644 --- a/net/rds/recv.c +++ b/net/rds/recv.c @@ -561,5 +561,7 @@ void rds_inc_info_copy(struct rds_incoming *inc, minfo.fport = inc->i_hdr.h_dport; } + minfo.flags = 0; + rds_info_copy(iter, &minfo, sizeof(minfo)); } -- 2.7.4
[toc] | [next] | [standalone]
| From | Santosh Shilimkar <santosh.shilimkar@oracle.com> |
|---|---|
| Date | 2016-06-02 17:30 +0200 |
| Message-ID | <rFCJk-7Au-23@gated-at.bofh.it> |
| In reply to | #1411987 |
On 6/2/2016 1:11 AM, Kangjie Lu wrote: > The last field "flags" of object "minfo" is not initialized. > Copying this object out may leak kernel stack data. > Assign 0 to it to avoid leak. > > Signed-off-by: Kangjie Lu <kjlu@gatech.edu> > --- > net/rds/recv.c | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-06-03 06:40 +0200 |
| Message-ID | <rFP3P-703-9@gated-at.bofh.it> |
| In reply to | #1411987 |
From: Kangjie Lu <kangjielu@gmail.com> Date: Thu, 2 Jun 2016 04:11:20 -0400 > The last field "flags" of object "minfo" is not initialized. > Copying this object out may leak kernel stack data. > Assign 0 to it to avoid leak. > > Signed-off-by: Kangjie Lu <kjlu@gatech.edu> Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web