Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1411979 > unrolled thread

[PATCH] tipc: fix an infoleak in tipc_nl_compat_link_dump

Back to article view | Back to linux.kernel

Contents

  [PATCH] tipc: fix an infoleak in tipc_nl_compat_link_dump Kangjie Lu <kangjielu@gmail.com> - 2016-06-02 10:10 +0200
    Re: [PATCH] tipc: fix an infoleak in tipc_nl_compat_link_dump David Miller <davem@davemloft.net> - 2016-06-03 06:40 +0200

#1411979 — [PATCH] tipc: fix an infoleak in tipc_nl_compat_link_dump

link_info.str is a char array of size 60. Memory after the NULL
byte is not initialized. Sending the whole object out can cause
a leak.

Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
---
 net/tipc/netlink_compat.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c
index f795b1d..2518014 100644
--- a/net/tipc/netlink_compat.c
+++ b/net/tipc/netlink_compat.c
@@ -604,7 +604,8 @@ static int tipc_nl_compat_link_dump(struct tipc_nl_compat_msg *msg,
 
 	link_info.dest = nla_get_flag(link[TIPC_NLA_LINK_DEST]);
 	link_info.up = htonl(nla_get_flag(link[TIPC_NLA_LINK_UP]));
-	strcpy(link_info.str, nla_data(link[TIPC_NLA_LINK_NAME]));
+	nla_strlcpy(link_info.str, nla_data(link[TIPC_NLA_LINK_NAME]),
+		    TIPC_MAX_LINK_NAME);
 
 	return tipc_add_tlv(msg->rep, TIPC_TLV_LINK_INFO,
 			    &link_info, sizeof(link_info));
-- 
2.7.4

[toc] | [next] | [standalone]

#1412785

From: Kangjie Lu <kangjielu@gmail.com>
Date: Thu,  2 Jun 2016 04:04:56 -0400

> link_info.str is a char array of size 60. Memory after the NULL
> byte is not initialized. Sending the whole object out can cause
> a leak.
> 
> Signed-off-by: Kangjie Lu <kjlu@gatech.edu>

Applied.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web