Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1412433 > unrolled thread

Re: [PATCH 32/32] mmc: bcm2835: Import bcm2835-mmc and switch to it

Started byStefan Wahren <stefan.wahren@i2se.com>
First post2016-06-02 19:00 +0200
Last post2016-06-02 23:50 +0200
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 32/32] mmc: bcm2835: Import bcm2835-mmc and switch to it Stefan Wahren <stefan.wahren@i2se.com> - 2016-06-02 19:00 +0200
    Re: [PATCH 32/32] mmc: bcm2835: Import bcm2835-mmc and switch to it Eric Anholt <eric@anholt.net> - 2016-06-02 20:20 +0200
      Re: [PATCH 32/32] mmc: bcm2835: Import bcm2835-mmc and switch to it Stefan Wahren <stefan.wahren@i2se.com> - 2016-06-02 21:10 +0200
        Re: [PATCH 32/32] mmc: bcm2835: Import bcm2835-mmc and switch to it Gerd Hoffmann <kraxel@redhat.com> - 2016-06-02 22:10 +0200
        Re: [PATCH 32/32] mmc: bcm2835: Import bcm2835-mmc and switch to it Eric Anholt <eric@anholt.net> - 2016-06-02 23:50 +0200

#1412433 — Re: [PATCH 32/32] mmc: bcm2835: Import bcm2835-mmc and switch to it

FromStefan Wahren <stefan.wahren@i2se.com>
Date2016-06-02 19:00 +0200
SubjectRe: [PATCH 32/32] mmc: bcm2835: Import bcm2835-mmc and switch to it
Message-ID<rFE8q-8lc-37@gated-at.bofh.it>
Hi Gerd,

Am 01.06.2016 um 23:43 schrieb Gerd Hoffmann:
> From: Eric Anholt <eric@anholt.net>
>
> With this we can get wifi (brcmfmac) to probe.  Without it we're stuck
> with timeouts from sdio.c when it tries to set the bus width to 4.

adding a new MMC driver to fix a wifi issue is really weird.

Beside that there are already two MMC drivers (sdhci-bcm2835.c and
sdhci-iproc.c) in the Kernel which are compatible to BCM2835. Why should
we add two new ones?

Stefan

[toc] | [next] | [standalone]


#1412481

FromEric Anholt <eric@anholt.net>
Date2016-06-02 20:20 +0200
Message-ID<rFFnQ-13m-21@gated-at.bofh.it>
In reply to#1412433

[Multipart message — attachments visible in raw view] — view raw

Stefan Wahren <stefan.wahren@i2se.com> writes:

> Hi Gerd,
>
> Am 01.06.2016 um 23:43 schrieb Gerd Hoffmann:
>> From: Eric Anholt <eric@anholt.net>
>>
>> With this we can get wifi (brcmfmac) to probe.  Without it we're stuck
>> with timeouts from sdio.c when it tries to set the bus width to 4.
>
> adding a new MMC driver to fix a wifi issue is really weird.
>
> Beside that there are already two MMC drivers (sdhci-bcm2835.c and
> sdhci-iproc.c) in the Kernel which are compatible to BCM2835. Why should
> we add two new ones?

Despite the fact that this is my commit, I don't think it should be
merged.  We should figure out why sdhci-iproc.c isn't working, instead.

[toc] | [prev] | [next] | [standalone]


#1412508

FromStefan Wahren <stefan.wahren@i2se.com>
Date2016-06-02 21:10 +0200
Message-ID<rFGad-1z0-21@gated-at.bofh.it>
In reply to#1412481
Hi Eric,

> Eric Anholt <eric@anholt.net> hat am 2. Juni 2016 um 20:18 geschrieben:
> 
> 
> Stefan Wahren <stefan.wahren@i2se.com> writes:
> 
> > Hi Gerd,
> >
> > Am 01.06.2016 um 23:43 schrieb Gerd Hoffmann:
> >> From: Eric Anholt <eric@anholt.net>
> >>
> >> With this we can get wifi (brcmfmac) to probe.  Without it we're stuck
> >> with timeouts from sdio.c when it tries to set the bus width to 4.
> >
> > adding a new MMC driver to fix a wifi issue is really weird.
> >
> > Beside that there are already two MMC drivers (sdhci-bcm2835.c and
> > sdhci-iproc.c) in the Kernel which are compatible to BCM2835. Why should
> > we add two new ones?
> 
> Despite the fact that this is my commit, I don't think it should be
> merged.  We should figure out why sdhci-iproc.c isn't working, instead.

so it doesn't work with sdhci-bcm2835 on RPi 3, too?

I plan to send a patch series to remove sdhci-bcm2835.

Stefan

[toc] | [prev] | [next] | [standalone]


#1412529

FromGerd Hoffmann <kraxel@redhat.com>
Date2016-06-02 22:10 +0200
Message-ID<rFH6h-2bE-3@gated-at.bofh.it>
In reply to#1412508
  Hi,

> > Despite the fact that this is my commit, I don't think it should be
> > merged.  We should figure out why sdhci-iproc.c isn't working, instead.
> 
> so it doesn't work with sdhci-bcm2835 on RPi 3, too?

With sdhci-bcm2835 rpi3 wifi doesn't work for me.
I didn't try sdhci-iproc yet.

cheers,
  Gerd

[toc] | [prev] | [next] | [standalone]


#1412571

FromEric Anholt <eric@anholt.net>
Date2016-06-02 23:50 +0200
Message-ID<rFIF3-2WQ-9@gated-at.bofh.it>
In reply to#1412508

[Multipart message — attachments visible in raw view] — view raw

Stefan Wahren <stefan.wahren@i2se.com> writes:

> Hi Eric,
>
>> Eric Anholt <eric@anholt.net> hat am 2. Juni 2016 um 20:18 geschrieben:
>> 
>> 
>> Stefan Wahren <stefan.wahren@i2se.com> writes:
>> 
>> > Hi Gerd,
>> >
>> > Am 01.06.2016 um 23:43 schrieb Gerd Hoffmann:
>> >> From: Eric Anholt <eric@anholt.net>
>> >>
>> >> With this we can get wifi (brcmfmac) to probe.  Without it we're stuck
>> >> with timeouts from sdio.c when it tries to set the bus width to 4.
>> >
>> > adding a new MMC driver to fix a wifi issue is really weird.
>> >
>> > Beside that there are already two MMC drivers (sdhci-bcm2835.c and
>> > sdhci-iproc.c) in the Kernel which are compatible to BCM2835. Why should
>> > we add two new ones?
>> 
>> Despite the fact that this is my commit, I don't think it should be
>> merged.  We should figure out why sdhci-iproc.c isn't working, instead.
>
> so it doesn't work with sdhci-bcm2835 on RPi 3, too?

Correct.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web