Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1412340 > unrolled thread

[PATCH v1 1/2] ARM: dts: keystone: remove bogus IO resource entry from PCI binding

Started byMurali Karicheri <m-karicheri2@ti.com>
First post2016-06-02 17:20 +0200
Last post2016-06-02 23:10 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v1 1/2] ARM: dts: keystone: remove bogus IO resource entry from PCI binding Murali Karicheri <m-karicheri2@ti.com> - 2016-06-02 17:20 +0200
    [PATCH v1 2/2] ARM: dts: keystone: add interrupt property to PCI controller bindings Murali Karicheri <m-karicheri2@ti.com> - 2016-06-02 17:20 +0200
    Re: [PATCH v1 1/2] ARM: dts: keystone: remove bogus IO resource entry  from PCI binding Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-06-02 20:10 +0200
      Re: [PATCH v1 1/2] ARM: dts: keystone: remove bogus IO resource entry  from PCI binding Murali Karicheri <m-karicheri2@ti.com> - 2016-06-02 23:10 +0200

#1412340 — [PATCH v1 1/2] ARM: dts: keystone: remove bogus IO resource entry from PCI binding

FromMurali Karicheri <m-karicheri2@ti.com>
Date2016-06-02 17:20 +0200
Subject[PATCH v1 1/2] ARM: dts: keystone: remove bogus IO resource entry from PCI binding
Message-ID<rFCzD-7xa-1@gated-at.bofh.it>
The PCI DT bindings contain a bogus entry for IO space which is not
supported on Keystone. The current bogus entry has an invalid size
and throws following error during boot.

[0.420713] keystone-pcie 21021000.pcie: error -22: failed to map
           resource [io  0x0000-0x400000003fff]

So remove it from the dts. While at it also add a bus-range
value that eliminates following log at boot up.

[0.420659] No bus range found for /soc/pcie@21020000, using [bus 00-ff]

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
---
 v1 - fixed subject to something more meaningful
 applies to master v4.7-rcx at kernel.org git repo
 arch/arm/boot/dts/keystone-k2e.dtsi | 5 +++--
 arch/arm/boot/dts/keystone.dtsi     | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/keystone-k2e.dtsi b/arch/arm/boot/dts/keystone-k2e.dtsi
index 96b349f..5374c9a 100644
--- a/arch/arm/boot/dts/keystone-k2e.dtsi
+++ b/arch/arm/boot/dts/keystone-k2e.dtsi
@@ -96,12 +96,13 @@
 			#address-cells = <3>;
 			#size-cells = <2>;
 			reg =  <0x21021000 0x2000>, <0x21020000 0x1000>, <0x02620128 4>;
-			ranges = <0x81000000 0 0 0x23260000 0x4000 0x4000
-				0x82000000 0 0x60000000 0x60000000 0 0x10000000>;
+			ranges = <0x82000000 0 0x60000000 0x60000000
+				  0 0x10000000>;
 
 			status = "disabled";
 			device_type = "pci";
 			num-lanes = <2>;
+			bus-range = <0x00 0xff>;
 
 			#interrupt-cells = <1>;
 			interrupt-map-mask = <0 0 0 7>;
diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
index e34b226..f627a1c 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -294,12 +294,13 @@
 			#address-cells = <3>;
 			#size-cells = <2>;
 			reg =  <0x21801000 0x2000>, <0x21800000 0x1000>, <0x02620128 4>;
-			ranges = <0x81000000 0 0 0x23250000 0 0x4000
-				0x82000000 0 0x50000000 0x50000000 0 0x10000000>;
+			ranges = <0x82000000 0 0x50000000 0x50000000
+				  0 0x10000000>;
 
 			status = "disabled";
 			device_type = "pci";
 			num-lanes = <2>;
+			bus-range = <0x00 0xff>;
 
 			#interrupt-cells = <1>;
 			interrupt-map-mask = <0 0 0 7>;
-- 
1.9.1

[toc] | [next] | [standalone]

#1412344 — [PATCH v1 2/2] ARM: dts: keystone: add interrupt property to PCI controller bindings

FromMurali Karicheri <m-karicheri2@ti.com>
Date2016-06-02 17:20 +0200
Subject[PATCH v1 2/2] ARM: dts: keystone: add interrupt property to PCI controller bindings
Message-ID<rFCzD-7xa-17@gated-at.bofh.it>
In reply to#1412340
Now that Keystone PCIe controller supports error interrupt handling
add interrupt property to PCI controller DT bindings to enable
error interrupt handling.

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
---
 - v1 - no change from initial version
 - applies to master v4.7-rcx at kernel.org git repo
 arch/arm/boot/dts/keystone-k2e.dtsi | 2 ++
 arch/arm/boot/dts/keystone.dtsi     | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/keystone-k2e.dtsi b/arch/arm/boot/dts/keystone-k2e.dtsi
index 5374c9a..9a51b8c 100644
--- a/arch/arm/boot/dts/keystone-k2e.dtsi
+++ b/arch/arm/boot/dts/keystone-k2e.dtsi
@@ -104,6 +104,8 @@
 			num-lanes = <2>;
 			bus-range = <0x00 0xff>;
 
+			/* error interrupt */
+			interrupts = <GIC_SPI 385 IRQ_TYPE_EDGE_RISING>;
 			#interrupt-cells = <1>;
 			interrupt-map-mask = <0 0 0 7>;
 			interrupt-map = <0 0 0 1 &pcie_intc1 0>, /* INT A */
diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
index f627a1c..e23f46d 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -302,6 +302,8 @@
 			num-lanes = <2>;
 			bus-range = <0x00 0xff>;
 
+			/* error interrupt */
+			interrupts = <GIC_SPI 38 IRQ_TYPE_EDGE_RISING>;
 			#interrupt-cells = <1>;
 			interrupt-map-mask = <0 0 0 7>;
 			interrupt-map = <0 0 0 1 &pcie_intc0 0>, /* INT A */
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1412469 — Re: [PATCH v1 1/2] ARM: dts: keystone: remove bogus IO resource entry from PCI binding

FromSantosh Shilimkar <santosh.shilimkar@oracle.com>
Date2016-06-02 20:10 +0200
SubjectRe: [PATCH v1 1/2] ARM: dts: keystone: remove bogus IO resource entry from PCI binding
Message-ID<rFFe9-103-1@gated-at.bofh.it>
In reply to#1412340
On 6/2/2016 8:17 AM, Murali Karicheri wrote:
> The PCI DT bindings contain a bogus entry for IO space which is not
> supported on Keystone. The current bogus entry has an invalid size
> and throws following error during boot.
>
> [0.420713] keystone-pcie 21021000.pcie: error -22: failed to map
>            resource [io  0x0000-0x400000003fff]
>
> So remove it from the dts. While at it also add a bus-range
> value that eliminates following log at boot up.
>
> [0.420659] No bus range found for /soc/pcie@21020000, using [bus 00-ff]
>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> ---
Both 1/2 and 2/2 looks fine to me. Will queue them for
next merge window.

Regards,
Santosh

[toc] | [prev] | [next] | [standalone]

#1412556 — Re: [PATCH v1 1/2] ARM: dts: keystone: remove bogus IO resource entry from PCI binding

FromMurali Karicheri <m-karicheri2@ti.com>
Date2016-06-02 23:10 +0200
SubjectRe: [PATCH v1 1/2] ARM: dts: keystone: remove bogus IO resource entry from PCI binding
Message-ID<rFI2m-2Jx-17@gated-at.bofh.it>
In reply to#1412469
On 06/02/2016 02:08 PM, Santosh Shilimkar wrote:
> On 6/2/2016 8:17 AM, Murali Karicheri wrote:
>> The PCI DT bindings contain a bogus entry for IO space which is not
>> supported on Keystone. The current bogus entry has an invalid size
>> and throws following error during boot.
>>
>> [0.420713] keystone-pcie 21021000.pcie: error -22: failed to map
>>            resource [io  0x0000-0x400000003fff]
>>
>> So remove it from the dts. While at it also add a bus-range
>> value that eliminates following log at boot up.
>>
>> [0.420659] No bus range found for /soc/pcie@21020000, using [bus 00-ff]
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> ---
> Both 1/2 and 2/2 looks fine to me. Will queue them for
> next merge window.
> 
> Regards,
> Santosh
> 
Ok. Thanks Santosh!

-- 
Murali Karicheri
Linux Kernel, Keystone

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web