Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1410637 > unrolled thread

[PATCH] perf/x86/intel/uncore: Remove redundant pci_get_drvdata()

Back to article view | Back to linux.kernel

Contents

  [PATCH] perf/x86/intel/uncore: Remove redundant pci_get_drvdata() Bjorn Helgaas <bhelgaas@google.com> - 2016-05-31 23:30 +0200
    Re: [PATCH] perf/x86/intel/uncore: Remove redundant  pci_get_drvdata() Thomas Gleixner <tglx@linutronix.de> - 2016-06-10 01:10 +0200

#1410637 — [PATCH] perf/x86/intel/uncore: Remove redundant pci_get_drvdata()

Remove redundant pci_get_drvdata() call.  There's another call a few lines
down, just before we test "box" for NULL.

No functional change intended.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 arch/x86/events/intel/uncore.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/events/intel/uncore.c b/arch/x86/events/intel/uncore.c
index fce7406..0c81d00 100644
--- a/arch/x86/events/intel/uncore.c
+++ b/arch/x86/events/intel/uncore.c
@@ -956,7 +956,7 @@ static int uncore_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id
 
 static void uncore_pci_remove(struct pci_dev *pdev)
 {
-	struct intel_uncore_box *box = pci_get_drvdata(pdev);
+	struct intel_uncore_box *box;
 	struct intel_uncore_pmu *pmu;
 	int i, phys_id, pkg;
 

[toc] | [next] | [standalone]

#1418936 — Re: [PATCH] perf/x86/intel/uncore: Remove redundant pci_get_drvdata()

On Tue, 31 May 2016, Bjorn Helgaas wrote:

> Remove redundant pci_get_drvdata() call.  There's another call a few lines
> down, just before we test "box" for NULL.
> 
> No functional change intended.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

Acked-by: Thomas Gleixner <tglx@linutronix.de>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web