Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1410633 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-05-31 23:20 +0200 |
| Last post | 2016-06-02 18:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] ASoC: hdmi-codec: select CONFIG_HDMI Arnd Bergmann <arnd@arndb.de> - 2016-05-31 23:20 +0200
Re: [PATCH] ASoC: hdmi-codec: select CONFIG_HDMI Jyri Sarha <jsarha@ti.com> - 2016-06-01 08:40 +0200
Applied "ASoC: hdmi-codec: select CONFIG_HDMI" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-06-02 18:00 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-05-31 23:20 +0200 |
| Subject | [PATCH] ASoC: hdmi-codec: select CONFIG_HDMI |
| Message-ID | <rEZeW-7Pi-7@gated-at.bofh.it> |
SND_SOC_HDMI_CODEC can be enabled without HDMI support, leading
to a link error:
In function `hdmi_codec_hw_params':
sound/soc/codecs/hdmi-codec.c:188: undefined reference to `hdmi_audio_infoframe_init'
sound/built-in.o:(.debug_addr+0x1a5c0): undefined reference to `hdmi_audio_infoframe_init'
This changes the Kconfig file to select HDMI, as the other codec using
hdmi_audio_infoframe_init already does.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 09184118a8ab ("ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders")
---
sound/soc/codecs/Kconfig | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 4d82a58ff6b0..f3fb98f0a995 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -483,9 +483,10 @@ config SND_SOC_DMIC
tristate
config SND_SOC_HDMI_CODEC
- tristate
- select SND_PCM_ELD
- select SND_PCM_IEC958
+ tristate
+ select SND_PCM_ELD
+ select SND_PCM_IEC958
+ select HDMI
config SND_SOC_ES8328
tristate "Everest Semi ES8328 CODEC"
--
2.7.0
[toc] | [next] | [standalone]
| From | Jyri Sarha <jsarha@ti.com> |
|---|---|
| Date | 2016-06-01 08:40 +0200 |
| Message-ID | <rF7YR-4TR-13@gated-at.bofh.it> |
| In reply to | #1410633 |
On 06/01/16 00:12, Arnd Bergmann wrote:
> SND_SOC_HDMI_CODEC can be enabled without HDMI support, leading
> to a link error:
>
> In function `hdmi_codec_hw_params':
> sound/soc/codecs/hdmi-codec.c:188: undefined reference to `hdmi_audio_infoframe_init'
> sound/built-in.o:(.debug_addr+0x1a5c0): undefined reference to `hdmi_audio_infoframe_init'
>
> This changes the Kconfig file to select HDMI, as the other codec using
> hdmi_audio_infoframe_init already does.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 09184118a8ab ("ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders")
Oops. I wonder how I missed that. Something in omap2plus_defconfig must
trigger the selecting of HDMI.
Acked-by: Jyri Sarha <jsarha@ti.com>
> ---
> sound/soc/codecs/Kconfig | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 4d82a58ff6b0..f3fb98f0a995 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -483,9 +483,10 @@ config SND_SOC_DMIC
> tristate
>
> config SND_SOC_HDMI_CODEC
> - tristate
> - select SND_PCM_ELD
> - select SND_PCM_IEC958
> + tristate
> + select SND_PCM_ELD
> + select SND_PCM_IEC958
> + select HDMI
>
> config SND_SOC_ES8328
> tristate "Everest Semi ES8328 CODEC"
>
[toc] | [prev] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2016-06-02 18:00 +0200 |
| Subject | Applied "ASoC: hdmi-codec: select CONFIG_HDMI" to the asoc tree |
| Message-ID | <rFDcm-7Kh-19@gated-at.bofh.it> |
| In reply to | #1410633 |
The patch ASoC: hdmi-codec: select CONFIG_HDMI has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 6de7df8d1b1a45a07d6ecc6b4f94179e1e68f5ec Mon Sep 17 00:00:00 2001 From: Arnd Bergmann <arnd@arndb.de> Date: Tue, 31 May 2016 23:12:00 +0200 Subject: [PATCH] ASoC: hdmi-codec: select CONFIG_HDMI SND_SOC_HDMI_CODEC can be enabled without HDMI support, leading to a link error: In function `hdmi_codec_hw_params': sound/soc/codecs/hdmi-codec.c:188: undefined reference to `hdmi_audio_infoframe_init' sound/built-in.o:(.debug_addr+0x1a5c0): undefined reference to `hdmi_audio_infoframe_init' This changes the Kconfig file to select HDMI, as the other codec using hdmi_audio_infoframe_init already does. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Jyri Sarha <jsarha@ti.com> Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/codecs/Kconfig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 4d82a58ff6b0..f3fb98f0a995 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -483,9 +483,10 @@ config SND_SOC_DMIC tristate config SND_SOC_HDMI_CODEC - tristate - select SND_PCM_ELD - select SND_PCM_IEC958 + tristate + select SND_PCM_ELD + select SND_PCM_IEC958 + select HDMI config SND_SOC_ES8328 tristate "Everest Semi ES8328 CODEC" -- 2.8.1
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web