Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1410393 > unrolled thread

[PATCH 00/11] ALSA: Utilize the module_isa_driver macro

Started byWilliam Breathitt Gray <vilhelm.gray@gmail.com>
First post2016-05-31 18:00 +0200
Last post2016-06-01 07:40 +0200
Articles 5 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 00/11] ALSA: Utilize the module_isa_driver macro William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-05-31 18:00 +0200
    [PATCH 02/11] ALSA: jazz16: Utilize the module_isa_driver macro William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-05-31 18:00 +0200
    [PATCH 01/11] ALSA: sb8: Utilize the module_isa_driver macro William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-05-31 18:00 +0200
    [PATCH 06/11] ALSA: gusmax: Utilize the module_isa_driver macro William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-05-31 18:00 +0200
    Re: [PATCH 00/11] ALSA: Utilize the module_isa_driver macro Takashi Iwai <tiwai@suse.de> - 2016-06-01 07:40 +0200

#1410393 — [PATCH 00/11] ALSA: Utilize the module_isa_driver macro

FromWilliam Breathitt Gray <vilhelm.gray@gmail.com>
Date2016-05-31 18:00 +0200
Subject[PATCH 00/11] ALSA: Utilize the module_isa_driver macro
Message-ID<rEUff-4Bu-3@gated-at.bofh.it>
The module_isa_driver macro is a helper macro for ISA drivers which do
not do anything special in module init/exit. This patchset eliminates a
lot of ISA driver registration boilerplate code by utilizing
module_isa_driver, which replaces module_init and module_exit.

William Breathitt Gray (11):
  ALSA: sb8: Utilize the module_isa_driver macro
  ALSA: jazz16: Utilize the module_isa_driver macro
  ALSA: ad1848: Utilize the module_isa_driver macro
  ALSA: cmi8328: Utilize the module_isa_driver macro
  ALSA: cs4231: Utilize the module_isa_driver macro
  ALSA: gusmax: Utilize the module_isa_driver macro
  ALSA: gusextreme: Utilize the module_isa_driver macro
  ALSA: gusclassic: Utilize the module_isa_driver macro
  ALSA: sc6000: Utilize the module_isa_driver macro
  ALSA: galaxy: Utilize the module_isa_driver macro
  ALSA: adlib: Utilize the module_isa_driver macro

 sound/isa/ad1848/ad1848.c  | 13 +------------
 sound/isa/adlib.c          | 13 +------------
 sound/isa/cmi8328.c        | 13 +------------
 sound/isa/cs423x/cs4231.c  | 13 +------------
 sound/isa/galaxy/galaxy.c  | 13 +------------
 sound/isa/gus/gusclassic.c | 13 +------------
 sound/isa/gus/gusextreme.c | 13 +------------
 sound/isa/gus/gusmax.c     | 13 +------------
 sound/isa/sb/jazz16.c      | 13 +------------
 sound/isa/sb/sb8.c         | 13 +------------
 sound/isa/sc6000.c         | 13 +------------
 11 files changed, 11 insertions(+), 132 deletions(-)

-- 
2.7.3

[toc] | [next] | [standalone]


#1410394 — [PATCH 02/11] ALSA: jazz16: Utilize the module_isa_driver macro

FromWilliam Breathitt Gray <vilhelm.gray@gmail.com>
Date2016-05-31 18:00 +0200
Subject[PATCH 02/11] ALSA: jazz16: Utilize the module_isa_driver macro
Message-ID<rEUfg-4Bu-25@gated-at.bofh.it>
In reply to#1410393
This driver does not do anything special in module init/exit. This patch
eliminates the module init/exit boilerplate code by utilizing the
module_isa_driver macro.

Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
 sound/isa/sb/jazz16.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/sound/isa/sb/jazz16.c b/sound/isa/sb/jazz16.c
index 6b4884d..4d90997 100644
--- a/sound/isa/sb/jazz16.c
+++ b/sound/isa/sb/jazz16.c
@@ -387,15 +387,4 @@ static struct isa_driver snd_jazz16_driver = {
 	},
 };
 
-static int __init alsa_card_jazz16_init(void)
-{
-	return isa_register_driver(&snd_jazz16_driver, SNDRV_CARDS);
-}
-
-static void __exit alsa_card_jazz16_exit(void)
-{
-	isa_unregister_driver(&snd_jazz16_driver);
-}
-
-module_init(alsa_card_jazz16_init)
-module_exit(alsa_card_jazz16_exit)
+module_isa_driver(snd_jazz16_driver, SNDRV_CARDS);
-- 
2.7.3

[toc] | [prev] | [next] | [standalone]


#1410395 — [PATCH 01/11] ALSA: sb8: Utilize the module_isa_driver macro

FromWilliam Breathitt Gray <vilhelm.gray@gmail.com>
Date2016-05-31 18:00 +0200
Subject[PATCH 01/11] ALSA: sb8: Utilize the module_isa_driver macro
Message-ID<rEUfg-4Bu-31@gated-at.bofh.it>
In reply to#1410393
This driver does not do anything special in module init/exit. This patch
eliminates the module init/exit boilerplate code by utilizing the
module_isa_driver macro.

Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
 sound/isa/sb/sb8.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/sound/isa/sb/sb8.c b/sound/isa/sb/sb8.c
index b8e2391..ad42d23 100644
--- a/sound/isa/sb/sb8.c
+++ b/sound/isa/sb/sb8.c
@@ -251,15 +251,4 @@ static struct isa_driver snd_sb8_driver = {
 	},
 };
 
-static int __init alsa_card_sb8_init(void)
-{
-	return isa_register_driver(&snd_sb8_driver, SNDRV_CARDS);
-}
-
-static void __exit alsa_card_sb8_exit(void)
-{
-	isa_unregister_driver(&snd_sb8_driver);
-}
-
-module_init(alsa_card_sb8_init)
-module_exit(alsa_card_sb8_exit)
+module_isa_driver(snd_sb8_driver, SNDRV_CARDS);
-- 
2.7.3

[toc] | [prev] | [next] | [standalone]


#1410396 — [PATCH 06/11] ALSA: gusmax: Utilize the module_isa_driver macro

FromWilliam Breathitt Gray <vilhelm.gray@gmail.com>
Date2016-05-31 18:00 +0200
Subject[PATCH 06/11] ALSA: gusmax: Utilize the module_isa_driver macro
Message-ID<rEUfg-4Bu-33@gated-at.bofh.it>
In reply to#1410393
This driver does not do anything special in module init/exit. This patch
eliminates the module init/exit boilerplate code by utilizing the
module_isa_driver macro.

Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
 sound/isa/gus/gusmax.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/sound/isa/gus/gusmax.c b/sound/isa/gus/gusmax.c
index 8216e8d..dd88c9d 100644
--- a/sound/isa/gus/gusmax.c
+++ b/sound/isa/gus/gusmax.c
@@ -370,15 +370,4 @@ static struct isa_driver snd_gusmax_driver = {
 	},
 };
 
-static int __init alsa_card_gusmax_init(void)
-{
-	return isa_register_driver(&snd_gusmax_driver, SNDRV_CARDS);
-}
-
-static void __exit alsa_card_gusmax_exit(void)
-{
-	isa_unregister_driver(&snd_gusmax_driver);
-}
-
-module_init(alsa_card_gusmax_init)
-module_exit(alsa_card_gusmax_exit)
+module_isa_driver(snd_gusmax_driver, SNDRV_CARDS);
-- 
2.7.3

[toc] | [prev] | [next] | [standalone]


#1410828

FromTakashi Iwai <tiwai@suse.de>
Date2016-06-01 07:40 +0200
Message-ID<rF72O-4kP-5@gated-at.bofh.it>
In reply to#1410393
On Tue, 31 May 2016 17:54:16 +0200,
William Breathitt Gray wrote:
> 
> The module_isa_driver macro is a helper macro for ISA drivers which do
> not do anything special in module init/exit. This patchset eliminates a
> lot of ISA driver registration boilerplate code by utilizing
> module_isa_driver, which replaces module_init and module_exit.
> 
> William Breathitt Gray (11):
>   ALSA: sb8: Utilize the module_isa_driver macro
>   ALSA: jazz16: Utilize the module_isa_driver macro
>   ALSA: ad1848: Utilize the module_isa_driver macro
>   ALSA: cmi8328: Utilize the module_isa_driver macro
>   ALSA: cs4231: Utilize the module_isa_driver macro
>   ALSA: gusmax: Utilize the module_isa_driver macro
>   ALSA: gusextreme: Utilize the module_isa_driver macro
>   ALSA: gusclassic: Utilize the module_isa_driver macro
>   ALSA: sc6000: Utilize the module_isa_driver macro
>   ALSA: galaxy: Utilize the module_isa_driver macro
>   ALSA: adlib: Utilize the module_isa_driver macro

Thanks, applied all patches now.


Takashi

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web