Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1410366 > unrolled thread
| Started by | Dave Jones <davej@codemonkey.org.uk> |
|---|---|
| First post | 2016-05-31 17:20 +0200 |
| Last post | 2016-05-31 17:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
mwifiex: fix self-assignment in mwifiex_uap_recv_packet Dave Jones <davej@codemonkey.org.uk> - 2016-05-31 17:20 +0200
RE: mwifiex: fix self-assignment in mwifiex_uap_recv_packet Amitkumar Karwar <akarwar@marvell.com> - 2016-05-31 17:30 +0200
| From | Dave Jones <davej@codemonkey.org.uk> |
|---|---|
| Date | 2016-05-31 17:20 +0200 |
| Subject | mwifiex: fix self-assignment in mwifiex_uap_recv_packet |
| Message-ID | <rETCx-4oz-13@gated-at.bofh.it> |
This function wants to operate on the adapter pointer in the priv
struct, not on itself which makes no sense.
Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
diff --git a/drivers/net/wireless/marvell/mwifiex/uap_txrx.c b/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
index 666e91af59d7..bf5660eb27d3 100644
--- a/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
+++ b/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
@@ -272,7 +272,7 @@ int mwifiex_handle_uap_rx_forward(struct mwifiex_private *priv,
int mwifiex_uap_recv_packet(struct mwifiex_private *priv,
struct sk_buff *skb)
{
- struct mwifiex_adapter *adapter = adapter;
+ struct mwifiex_adapter *adapter = priv->adapter;
struct mwifiex_sta_node *src_node;
struct ethhdr *p_ethhdr;
struct sk_buff *skb_uap;
[toc] | [next] | [standalone]
| From | Amitkumar Karwar <akarwar@marvell.com> |
|---|---|
| Date | 2016-05-31 17:30 +0200 |
| Message-ID | <rETMd-4rJ-9@gated-at.bofh.it> |
| In reply to | #1410366 |
Hi Dave,
> From: Dave Jones [mailto:davej@codemonkey.org.uk]
> Sent: Tuesday, May 31, 2016 8:47 PM
> To: Linux Kernel
> Cc: Xinming Hu; Cathy Luo; Amitkumar Karwar; Kalle Valo
> Subject: mwifiex: fix self-assignment in mwifiex_uap_recv_packet
>
> This function wants to operate on the adapter pointer in the priv
> struct, not on itself which makes no sense.
>
> Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
> b/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
> index 666e91af59d7..bf5660eb27d3 100644
> --- a/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
> +++ b/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
> @@ -272,7 +272,7 @@ int mwifiex_handle_uap_rx_forward(struct
> mwifiex_private *priv, int mwifiex_uap_recv_packet(struct
> mwifiex_private *priv,
> struct sk_buff *skb)
> {
> - struct mwifiex_adapter *adapter = adapter;
> + struct mwifiex_adapter *adapter = priv->adapter;
> struct mwifiex_sta_node *src_node;
> struct ethhdr *p_ethhdr;
> struct sk_buff *skb_uap;
Thanks for the patch. This has been already taken cared by below patch submitted recently.
https://patchwork.kernel.org/patch/9115501/
Regards,
Amitkumar
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web