Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1410376 > unrolled thread
| Started by | Dave Jones <davej@codemonkey.org.uk> |
|---|---|
| First post | 2016-05-31 17:30 +0200 |
| Last post | 2016-06-01 12:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
usbip: vudc: Fix apparent cut-n-paste error Dave Jones <davej@codemonkey.org.uk> - 2016-05-31 17:30 +0200
Re: usbip: vudc: Fix apparent cut-n-paste error Krzysztof Opasiak <k.opasiak@samsung.com> - 2016-06-01 12:30 +0200
| From | Dave Jones <davej@codemonkey.org.uk> |
|---|---|
| Date | 2016-05-31 17:30 +0200 |
| Subject | usbip: vudc: Fix apparent cut-n-paste error |
| Message-ID | <rETMd-4rJ-25@gated-at.bofh.it> |
Coverity picked up that this looks like a cut-n-paste from an almost
identical sequence below that didn't get its variable renamed.
Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c
index 8994a13819ab..7091848df6c8 100644
--- a/drivers/usb/usbip/vudc_dev.c
+++ b/drivers/usb/usbip/vudc_dev.c
@@ -450,7 +450,7 @@ static void vudc_shutdown(struct usbip_device *ud)
if (ud->tcp_socket)
kernel_sock_shutdown(ud->tcp_socket, SHUT_RDWR);
- if (ud->tcp_tx) {
+ if (ud->tcp_rx) {
kthread_stop_put(ud->tcp_rx);
ud->tcp_rx = NULL;
}
[toc] | [next] | [standalone]
| From | Krzysztof Opasiak <k.opasiak@samsung.com> |
|---|---|
| Date | 2016-06-01 12:30 +0200 |
| Message-ID | <rFbzs-7br-25@gated-at.bofh.it> |
| In reply to | #1410376 |
On 05/31/2016 05:25 PM, Dave Jones wrote:
> Coverity picked up that this looks like a cut-n-paste from an almost
> identical sequence below that didn't get its variable renamed.
>
> Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
>
> diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c
> index 8994a13819ab..7091848df6c8 100644
> --- a/drivers/usb/usbip/vudc_dev.c
> +++ b/drivers/usb/usbip/vudc_dev.c
> @@ -450,7 +450,7 @@ static void vudc_shutdown(struct usbip_device *ud)
> if (ud->tcp_socket)
> kernel_sock_shutdown(ud->tcp_socket, SHUT_RDWR);
>
> - if (ud->tcp_tx) {
> + if (ud->tcp_rx) {
> kthread_stop_put(ud->tcp_rx);
> ud->tcp_rx = NULL;
> }
>
>
Reviewed-by: Krzysztof Opasiak <k.opasiak@samsung.com>
--
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web