Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1406278 > unrolled thread
| Started by | Jacob Pan <jacob.jun.pan@linux.intel.com> |
|---|---|
| First post | 2016-05-24 18:40 +0200 |
| Last post | 2016-06-01 20:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] perf/x86/intel/rapl: add skylake server Jacob Pan <jacob.jun.pan@linux.intel.com> - 2016-05-24 18:40 +0200
Re: [PATCH] perf/x86/intel/rapl: add skylake server Peter Zijlstra <peterz@infradead.org> - 2016-05-31 11:30 +0200
Re: [PATCH] perf/x86/intel/rapl: add skylake server jacob <jacob.jun.pan@linux.intel.com> - 2016-06-01 20:10 +0200
| From | Jacob Pan <jacob.jun.pan@linux.intel.com> |
|---|---|
| Date | 2016-05-24 18:40 +0200 |
| Subject | [PATCH] perf/x86/intel/rapl: add skylake server |
| Message-ID | <rCnx8-5GI-19@gated-at.bofh.it> |
SKX uses similar RAPL interface as Broadwell server. Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> --- arch/x86/events/intel/rapl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/events/intel/rapl.c b/arch/x86/events/intel/rapl.c index 1705c9d..70af62a 100644 --- a/arch/x86/events/intel/rapl.c +++ b/arch/x86/events/intel/rapl.c @@ -712,6 +712,7 @@ static int __init rapl_pmu_init(void) break; case 63: /* Haswell-Server */ case 79: /* Broadwell-Server */ + case 85: /* Skylake-Server */ apply_quirk = true; rapl_cntr_mask = RAPL_IDX_SRV; rapl_pmu_events_group.attrs = rapl_events_srv_attr; -- 1.9.1
[toc] | [next] | [standalone]
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Date | 2016-05-31 11:30 +0200 |
| Message-ID | <rEO9P-Rc-9@gated-at.bofh.it> |
| In reply to | #1406278 |
On Tue, May 24, 2016 at 09:31:43AM -0700, Jacob Pan wrote:
> SKX uses similar RAPL interface as Broadwell server.
>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> ---
> arch/x86/events/intel/rapl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/events/intel/rapl.c b/arch/x86/events/intel/rapl.c
> index 1705c9d..70af62a 100644
> --- a/arch/x86/events/intel/rapl.c
> +++ b/arch/x86/events/intel/rapl.c
> @@ -712,6 +712,7 @@ static int __init rapl_pmu_init(void)
> break;
> case 63: /* Haswell-Server */
> case 79: /* Broadwell-Server */
> + case 85: /* Skylake-Server */
> apply_quirk = true;
> rapl_cntr_mask = RAPL_IDX_SRV;
> rapl_pmu_events_group.attrs = rapl_events_srv_attr;
This does not apply; please try against a more recent kernel. In
specific commit:
4b6e2571bf00 ("x86/perf/intel/rapl: Make the Intel RAPL PMU driver modular")
seems to the 'problem'.
[toc] | [prev] | [next] | [standalone]
| From | jacob <jacob.jun.pan@linux.intel.com> |
|---|---|
| Date | 2016-06-01 20:10 +0200 |
| Message-ID | <rFiKB-3t1-9@gated-at.bofh.it> |
| In reply to | #1410030 |
On Tue, 31 May 2016 11:29:08 +0200
Peter Zijlstra <peterz@infradead.org> wrote:
> > case 63: /* Haswell-Server */
> > case 79: /* Broadwell-Server */
> > + case 85: /* Skylake-Server */
> > apply_quirk = true;
> > rapl_cntr_mask = RAPL_IDX_SRV;
> > rapl_pmu_events_group.attrs =
> > rapl_events_srv_attr;
>
> This does not apply; please try against a more recent kernel. In
> specific commit:
>
> 4b6e2571bf00 ("x86/perf/intel/rapl: Make the Intel RAPL PMU driver
> modular")
>
> seems to the 'problem'.
Dave Hanse (cc'd) will send out the patch as part of the clean up of
open-coding x86 model numbers.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web