Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1409815 > unrolled thread

[PATCH 0/3] watchdog, sbsa_gwdt: Update SBSA watchdog with the new infrastructure of watchdog.

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] watchdog, sbsa_gwdt: Update SBSA watchdog with the new infrastructure of watchdog. fu.wei@linaro.org - 2016-05-31 08:10 +0200
    [PATCH 3/3] sbsa_gwdt: Set WDOG_HW_RUNNING, when watchdog is already running. fu.wei@linaro.org - 2016-05-31 08:10 +0200
      Re: [PATCH 3/3] sbsa_gwdt: Set WDOG_HW_RUNNING, when watchdog is  already running. Guenter Roeck <linux@roeck-us.net> - 2016-06-01 23:50 +0200

#1409815 — [PATCH 0/3] watchdog, sbsa_gwdt: Update SBSA watchdog with the new infrastructure of watchdog.

From: Fu Wei <fu.wei@linaro.org>

This patchset:
    (1)Try to fix an issue about min and max timeout validity check:
    when max_hw_heartbeat_ms is defined, this check should be skipped.

    (2)Use max_hw_heartbeat_ms instead of max_timeout in SBSA watchdog.

    (3)Set WDOG_HW_RUNNING, when SBSA watchdog is already running before
    it's initialized.

Changelog:
v1: The first formal upstreaming version

RFC: https://lkml.org/lkml/2016/5/3/145

Pratyush Anand (3):
  watchdog: skip min and max timeout validity check when
    max_hw_heartbeat_ms is defined
  sbsa_gwdt: Use max_hw_heartbeat_ms instead of max_timeout
  sbsa_gwdt: Set WDOG_HW_RUNNING, when watchdog is already running.

 drivers/watchdog/sbsa_gwdt.c     | 6 ++++--
 drivers/watchdog/watchdog_core.c | 2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)

-- 
2.5.5

[toc] | [next] | [standalone]

#1409817 — [PATCH 3/3] sbsa_gwdt: Set WDOG_HW_RUNNING, when watchdog is already running.

From: Pratyush Anand <panand@redhat.com>

This patch uses the new flag WDOG_HW_RUNNING in driver.
According to the definition of this flag, it should be set,
if watchdog is running after booting, before it's opened.

Signed-off-by: Pratyush Anand <panand@redhat.com>
Signed-off-by: Fu Wei <fu.wei@linaro.org>
---
 drivers/watchdog/sbsa_gwdt.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/watchdog/sbsa_gwdt.c b/drivers/watchdog/sbsa_gwdt.c
index 6af71e0..cc885f1 100644
--- a/drivers/watchdog/sbsa_gwdt.c
+++ b/drivers/watchdog/sbsa_gwdt.c
@@ -283,6 +283,8 @@ static int sbsa_gwdt_probe(struct platform_device *pdev)
 		dev_warn(dev, "System reset by WDT.\n");
 		wdd->bootstatus |= WDIOF_CARDRESET;
 	}
+	if (status & SBSA_GWDT_WCS_EN)
+		set_bit(WDOG_HW_RUNNING, &wdd->status);
 
 	if (action) {
 		irq = platform_get_irq(pdev, 0);
-- 
2.5.5

[toc] | [prev] | [next] | [standalone]

#1411573 — Re: [PATCH 3/3] sbsa_gwdt: Set WDOG_HW_RUNNING, when watchdog is already running.

On Tue, May 31, 2016 at 02:08:10PM +0800, fu.wei@linaro.org wrote:
> From: Pratyush Anand <panand@redhat.com>
> 
> This patch uses the new flag WDOG_HW_RUNNING in driver.
> According to the definition of this flag, it should be set,
> if watchdog is running after booting, before it's opened.
> 
> Signed-off-by: Pratyush Anand <panand@redhat.com>
> Signed-off-by: Fu Wei <fu.wei@linaro.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/sbsa_gwdt.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/watchdog/sbsa_gwdt.c b/drivers/watchdog/sbsa_gwdt.c
> index 6af71e0..cc885f1 100644
> --- a/drivers/watchdog/sbsa_gwdt.c
> +++ b/drivers/watchdog/sbsa_gwdt.c
> @@ -283,6 +283,8 @@ static int sbsa_gwdt_probe(struct platform_device *pdev)
>  		dev_warn(dev, "System reset by WDT.\n");
>  		wdd->bootstatus |= WDIOF_CARDRESET;
>  	}
> +	if (status & SBSA_GWDT_WCS_EN)
> +		set_bit(WDOG_HW_RUNNING, &wdd->status);
>  
>  	if (action) {
>  		irq = platform_get_irq(pdev, 0);
> -- 
> 2.5.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web