Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1409331 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-05-30 21:10 +0200 |
| Last post | 2016-05-31 09:00 +0200 |
| Articles | 6 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v4 00/16] genrtc removal Arnd Bergmann <arnd@arndb.de> - 2016-05-30 21:10 +0200
[PATCH v4 12/16] rtc: powerpc: provide rtc_class_ops directly Arnd Bergmann <arnd@arndb.de> - 2016-05-30 21:10 +0200
[PATCH v4 06/16] char/genrtc: remove mn10300 support Arnd Bergmann <arnd@arndb.de> - 2016-05-30 21:10 +0200
[PATCH v4 03/16] char/genrtc: x86: remove remnants of asm/rtc.h Arnd Bergmann <arnd@arndb.de> - 2016-05-30 21:20 +0200
Re: [PATCH v4 00/16] genrtc removal Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-05-30 22:40 +0200
Re: [PATCH v4 00/16] genrtc removal Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-31 09:00 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-05-30 21:10 +0200 |
| Subject | [PATCH v4 00/16] genrtc removal |
| Message-ID | <rEAzT-83V-5@gated-at.bofh.it> |
This is the promised resend of the removal of the genrtc driver and some
related code, now that we are at a good time to merge this for the coming
merge window.
The contents are the same as before, except fixing the build regressions
reported by the 0day builder: on both x86 and mn10300 the rearranging
of the header files caused some missing headers that were included
implicitly before.
Things regarding rtc are a bit intertwined, so I'm mixing patches for
drivers/rtc with drivers/char and arch. This series should make that
better in the end.
This now thoroughly removes the genrtc driver including the asm/rtc.h
headers it uses. For all architectures that still have a meaningful
asm/rtc.h, this goes through two stages:
1) make the rtc-generic implementation independent of asm/rtc.h
2) remove the asm/rtc.h header and disallow the gen_rtc driver
As the last step, the driver itself gets removed. There are a
couple of follow-up cleanup tasks that we could do once this is
all merged, including removing all the remaining nonstandard
RTC drivers from drivers/char:
- alpha most likely doesn't ever use CONFIG_RTC, as it has its
own replacement driver in arch/alpha/kernel/rtc.c, and the legacy
driver is slightly broken on at least one alpha machine
- loongson64 is the only MIPS machine that has the option of running
the legacy CONFIG_RTC driver, but it should also work with rtc-cmos,
and support for that was added in 2010 with 5df74352876 ("MIPS:
Loongson: Define rtc device on MC146818-equipped systems").
- with the above two gone, the only remaining user of CONFIG_RTC
is arch/mn10300, and that just needs to register the appropriate
platform device to use the RTC_CMOS driver instead. I'm sure the
only reason that hasn't happened is because there is very little
active development on this architecture.
- CONFIG_JS_RTC depends on SPARC32, but can not be selected there
because SPARC unconditionally selects RTC_CLASS since 2008, so
this is effectively dead code. Interestingly, this is not even
a separate driver, but actually uses the same code as CONFIG_RTC
with some #ifdef
- CONFIG_EFI_RTC is actively used on all six Itanium configurations,
though the CONFIG_RTC_DRV_EFI replacement driver is also available
there (and has been Itanium-only until ARM64 support for EFI was
merged). I suspect it's just a matter of getting an Ack from the
Itanium maintainers to remove it and change the defconfigs.
- the last remaining legacy RTC driver after those is CONFIG_DS1302,
which has a slightly nonstandard ioctl interface and is only used
on arch/m32r. I have experimented with this a bit and think it
can be converted in a backward-compatible way as well.
- Regarding the users of RTC_DRV_GENERIC, it would be nice to convert
them into hardware-specific drivers that look more like the other
drivers. parisc is particularly easy, it just needs to call
platform_create_bundle() instead of platform_device_register.
The three other architectures have their own abstraction layer
on top of rtc-generic and should kill that off. There are only
a few drivers in each case: m68k has one (q40), sh has two
(dreamcast and sh3) and powerpc has four (rtas, mpc8xx, chrp
and pmac).
- Once all RTC support uses the RTC class subsystem, we should
remove all implementations of read_persistent_clock{,64} that only
access the RTC or return a hardwired time, and we should
remove all update_persistent_clock{,64} users and
CONFIG_GENERIC_CMOS_UPDATE, as both are replaced with
generic rtc code.
Arnd
Cc: geert@linux-m68k.org
Cc: gregkh@linuxfoundation.org
Cc: deller@gmx.de
Cc: benh@kernel.crashing.org
Cc: mpe@ellerman.id.au
Cc: dalias@libc.org
Cc: dhowells@redhat.com
Cc: linux-alpha@vger.kernel.org
Cc: a.zummo@towertech.it
Cc: linux-kernel@vger.kernel.org
Cc: linux-parisc@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-sh@vger.kernel.org
Cc: linux-m68k@lists.linux-m68k.org
Cc: rtc-linux@googlegroups.com
Cc: linux-arch@vger.kernel.org
Arnd Bergmann (16):
rtc: cmos: remove empty asm/mc146818rtc.h files
rtc: cmos: move mc146818rtc code out of asm-generic/rtc.h
char/genrtc: x86: remove remnants of asm/rtc.h
rtc: sh: provide rtc_class_ops directly
char/genrtc: remove alpha support
char/genrtc: remove mn10300 support
rtc: parisc: provide rtc_class_ops directly
char/genrtc: remove parisc support
rtc: m68k: provide rtc_class_ops directly
rtc: m68k: provide ioctl for q40
char/genrtc: remove m68k support
rtc: powerpc: provide rtc_class_ops directly
char/genrtc: remove powerpc support
rtc: generic: remove get_rtc_time/set_rtc_time wrappers
char/genrtc: remove asm-generic/rtc.h from mips
char/genrtc: remove the rest of the driver
arch/alpha/include/asm/rtc.h | 1 -
arch/alpha/kernel/core_marvel.c | 1 -
arch/alpha/kernel/rtc.c | 6 +-
arch/frv/include/asm/mc146818rtc.h | 16 -
arch/h8300/include/asm/mc146818rtc.h | 9 -
arch/ia64/include/asm/mc146818rtc.h | 10 -
arch/m68k/amiga/config.c | 1 -
arch/m68k/apollo/config.c | 1 -
arch/m68k/bvme6000/config.c | 1 -
arch/m68k/hp300/config.c | 2 +-
arch/m68k/include/asm/rtc.h | 79 ----
arch/m68k/kernel/time.c | 48 ++-
arch/m68k/mac/config.c | 3 +-
arch/m68k/mac/misc.c | 1 -
arch/m68k/mvme147/config.c | 1 -
arch/m68k/mvme16x/config.c | 1 -
arch/m68k/q40/config.c | 2 +-
arch/m68k/sun3/config.c | 1 -
arch/m68k/sun3/intersil.c | 2 +-
arch/m68k/sun3x/time.c | 2 +-
arch/mips/sni/time.c | 1 -
arch/mn10300/include/asm/rtc.h | 2 -
arch/mn10300/kernel/rtc.c | 2 +-
arch/mn10300/proc-mn103e010/proc-init.c | 1 +
arch/mn10300/proc-mn2ws0050/proc-init.c | 1 +
arch/parisc/include/asm/mc146818rtc.h | 9 -
arch/parisc/include/asm/rtc.h | 131 -------
arch/parisc/kernel/time.c | 36 +-
arch/powerpc/include/asm/rtc.h | 78 ----
arch/powerpc/kernel/time.c | 29 +-
arch/powerpc/platforms/Kconfig | 11 +
arch/powerpc/platforms/ps3/time.c | 2 +-
arch/sh/include/asm/mc146818rtc.h | 7 -
arch/sh/include/asm/rtc.h | 11 -
arch/sh/kernel/time.c | 33 +-
arch/x86/include/asm/mc146818rtc.h | 1 -
arch/x86/include/asm/rtc.h | 1 -
arch/x86/kernel/hpet.c | 3 +-
arch/x86/kernel/rtc.c | 3 +-
arch/x86/platform/efi/efi.c | 1 -
arch/x86/platform/efi/efi_64.c | 1 +
arch/x86/platform/intel-mid/intel_mid_vrtc.c | 1 +
drivers/acpi/acpi_cmos_rtc.c | 2 +-
drivers/base/power/trace.c | 6 +-
drivers/char/Kconfig | 26 --
drivers/char/Makefile | 1 -
drivers/char/genrtc.c | 539 ---------------------------
drivers/rtc/rtc-cmos.c | 12 +-
drivers/rtc/rtc-generic.c | 36 +-
drivers/rtc/rtc-mrst.c | 2 +-
include/asm-generic/rtc.h | 247 ------------
include/linux/mc146818rtc.h | 194 ++++++++++
52 files changed, 362 insertions(+), 1256 deletions(-)
delete mode 100644 arch/alpha/include/asm/rtc.h
delete mode 100644 arch/frv/include/asm/mc146818rtc.h
delete mode 100644 arch/h8300/include/asm/mc146818rtc.h
delete mode 100644 arch/ia64/include/asm/mc146818rtc.h
delete mode 100644 arch/m68k/include/asm/rtc.h
delete mode 100644 arch/parisc/include/asm/mc146818rtc.h
delete mode 100644 arch/parisc/include/asm/rtc.h
delete mode 100644 arch/powerpc/include/asm/rtc.h
delete mode 100644 arch/sh/include/asm/mc146818rtc.h
delete mode 100644 arch/x86/include/asm/rtc.h
delete mode 100644 drivers/char/genrtc.c
delete mode 100644 include/asm-generic/rtc.h
--
2.7.0
[toc] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-05-30 21:10 +0200 |
| Subject | [PATCH v4 12/16] rtc: powerpc: provide rtc_class_ops directly |
| Message-ID | <rEAJA-8nt-27@gated-at.bofh.it> |
| In reply to | #1409331 |
The rtc-generic driver provides an architecture specific
wrapper on top of the generic rtc_class_ops abstraction,
and powerpc has another abstraction on top, which is a bit
silly.
This changes the powerpc rtc-generic device to provide its
rtc_class_ops directly, to reduce the number of layers
by one.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/powerpc/kernel/time.c | 29 ++++++++++++++++++++++++++++-
drivers/rtc/rtc-generic.c | 2 +-
2 files changed, 29 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c
index 3ed9a5a21d77..7a482a7f4d8d 100644
--- a/arch/powerpc/kernel/time.c
+++ b/arch/powerpc/kernel/time.c
@@ -56,6 +56,7 @@
#include <linux/irq_work.h>
#include <linux/clk-provider.h>
#include <linux/suspend.h>
+#include <linux/rtc.h>
#include <asm/trace.h>
#include <asm/io.h>
@@ -1081,6 +1082,29 @@ void calibrate_delay(void)
loops_per_jiffy = tb_ticks_per_jiffy;
}
+#if IS_ENABLED(CONFIG_RTC_DRV_GENERIC)
+static int rtc_generic_get_time(struct device *dev, struct rtc_time *tm)
+{
+ ppc_md.get_rtc_time(tm);
+ return rtc_valid_tm(tm);
+}
+
+static int rtc_generic_set_time(struct device *dev, struct rtc_time *tm)
+{
+ if (!ppc_md.set_rtc_time)
+ return -EOPNOTSUPP;
+
+ if (ppc_md.set_rtc_time(tm) < 0)
+ return -EOPNOTSUPP;
+
+ return 0;
+}
+
+static const struct rtc_class_ops rtc_generic_ops = {
+ .read_time = rtc_generic_get_time,
+ .set_time = rtc_generic_set_time,
+};
+
static int __init rtc_init(void)
{
struct platform_device *pdev;
@@ -1088,9 +1112,12 @@ static int __init rtc_init(void)
if (!ppc_md.get_rtc_time)
return -ENODEV;
- pdev = platform_device_register_simple("rtc-generic", -1, NULL, 0);
+ pdev = platform_device_register_data(NULL, "rtc-generic", -1,
+ &rtc_generic_ops,
+ sizeof(rtc_generic_ops));
return PTR_ERR_OR_ZERO(pdev);
}
device_initcall(rtc_init);
+#endif
diff --git a/drivers/rtc/rtc-generic.c b/drivers/rtc/rtc-generic.c
index 5c82bae73b9c..efcb9833cac8 100644
--- a/drivers/rtc/rtc-generic.c
+++ b/drivers/rtc/rtc-generic.c
@@ -9,7 +9,7 @@
#include <linux/platform_device.h>
#include <linux/rtc.h>
-#if defined(CONFIG_PPC)
+#if 0
#include <asm/rtc.h>
static int generic_get_time(struct device *dev, struct rtc_time *tm)
--
2.7.0
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-05-30 21:10 +0200 |
| Subject | [PATCH v4 06/16] char/genrtc: remove mn10300 support |
| Message-ID | <rEAJA-8nt-33@gated-at.bofh.it> |
| In reply to | #1409331 |
The genrtc driver serves no purpose on mn10300 because it drives the
same hardware as the original rtc.c driver, and the newer rtc-generic.c
or rtc-cmos.c drivers on architectures that use the asm-generic/rtc.h
header.
I assume it was initially only added for completeness when the
mn10300 port was done, but the older rtc.c driver was always used
instead.
We can also stop include asm-generic/rtc.h now, because we
just call mc146818_set_time() directly.
It would be nice to change the architecture to use the rtc-cmos driver
next, and remove support for the old rtc driver as well.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/mn10300/include/asm/rtc.h | 2 --
arch/mn10300/kernel/rtc.c | 2 +-
arch/mn10300/proc-mn103e010/proc-init.c | 1 +
arch/mn10300/proc-mn2ws0050/proc-init.c | 1 +
drivers/char/Kconfig | 2 +-
5 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/mn10300/include/asm/rtc.h b/arch/mn10300/include/asm/rtc.h
index 6c14bb1d0d9b..07dc87656197 100644
--- a/arch/mn10300/include/asm/rtc.h
+++ b/arch/mn10300/include/asm/rtc.h
@@ -25,6 +25,4 @@ static inline void calibrate_clock(void)
#endif /* !CONFIG_MN10300_RTC */
-#include <asm-generic/rtc.h>
-
#endif /* _ASM_RTC_H */
diff --git a/arch/mn10300/kernel/rtc.c b/arch/mn10300/kernel/rtc.c
index 48d7058b3295..77e0be4d92ea 100644
--- a/arch/mn10300/kernel/rtc.c
+++ b/arch/mn10300/kernel/rtc.c
@@ -27,7 +27,7 @@ void read_persistent_clock(struct timespec *ts)
{
struct rtc_time tm;
- get_rtc_time(&tm);
+ mc146818_set_time(&tm);
ts->tv_nsec = 0;
ts->tv_sec = mktime(tm.tm_year, tm.tm_mon, tm.tm_mday,
diff --git a/arch/mn10300/proc-mn103e010/proc-init.c b/arch/mn10300/proc-mn103e010/proc-init.c
index 27b97980dca4..d4dcb0c56b35 100644
--- a/arch/mn10300/proc-mn103e010/proc-init.c
+++ b/arch/mn10300/proc-mn103e010/proc-init.c
@@ -9,6 +9,7 @@
* 2 of the Licence, or (at your option) any later version.
*/
#include <linux/kernel.h>
+#include <asm/cacheflush.h>
#include <asm/fpu.h>
#include <asm/rtc.h>
#include <asm/busctl-regs.h>
diff --git a/arch/mn10300/proc-mn2ws0050/proc-init.c b/arch/mn10300/proc-mn2ws0050/proc-init.c
index ee6d03dbc8d8..950cc8dbb284 100644
--- a/arch/mn10300/proc-mn2ws0050/proc-init.c
+++ b/arch/mn10300/proc-mn2ws0050/proc-init.c
@@ -14,6 +14,7 @@
#include <linux/delay.h>
#include <linux/interrupt.h>
+#include <asm/cacheflush.h>
#include <asm/processor.h>
#include <asm/uaccess.h>
#include <asm/io.h>
diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index e3f2f3e293e5..1d9e3063373b 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -328,7 +328,7 @@ config JS_RTC
config GEN_RTC
tristate "Generic /dev/rtc emulation"
depends on RTC!=y
- depends on M68K || MN10300 || PARISC || PPC
+ depends on M68K || PARISC || PPC
---help---
If you say Y here and create a character special file /dev/rtc with
major number 10 and minor number 135 using mknod ("man mknod"), you
--
2.7.0
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-05-30 21:20 +0200 |
| Subject | [PATCH v4 03/16] char/genrtc: x86: remove remnants of asm/rtc.h |
| Message-ID | <rEATf-8ry-1@gated-at.bofh.it> |
| In reply to | #1409331 |
Commit 3195ef59cb42 ("x86: Do full rtc synchronization with ntp") had
the side-effect of unconditionally enabling the RTC_LIB symbol on x86,
which in turn disables the selection of the CONFIG_RTC and
CONFIG_GEN_RTC drivers that contain a two older implementations of
the CONFIG_RTC_DRV_CMOS driver.
This removes x86 from the list for genrtc, and changes all references
to the asm/rtc.h header to instead point to the interfaces
from linux/mc146818rtc.h.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/x86/include/asm/rtc.h | 1 -
arch/x86/kernel/hpet.c | 3 +--
arch/x86/kernel/rtc.c | 3 +--
arch/x86/platform/efi/efi.c | 1 -
drivers/acpi/acpi_cmos_rtc.c | 2 +-
drivers/base/power/trace.c | 6 +++---
drivers/char/Kconfig | 2 +-
drivers/rtc/rtc-mrst.c | 2 +-
8 files changed, 8 insertions(+), 12 deletions(-)
delete mode 100644 arch/x86/include/asm/rtc.h
diff --git a/arch/x86/include/asm/rtc.h b/arch/x86/include/asm/rtc.h
deleted file mode 100644
index f71c3b0ed360..000000000000
--- a/arch/x86/include/asm/rtc.h
+++ /dev/null
@@ -1 +0,0 @@
-#include <asm-generic/rtc.h>
diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
index f112af7aa62e..357900aad62c 100644
--- a/arch/x86/kernel/hpet.c
+++ b/arch/x86/kernel/hpet.c
@@ -1020,7 +1020,6 @@ void hpet_disable(void)
*/
#include <linux/mc146818rtc.h>
#include <linux/rtc.h>
-#include <asm/rtc.h>
#define DEFAULT_RTC_INT_FREQ 64
#define DEFAULT_RTC_SHIFT 6
@@ -1244,7 +1243,7 @@ irqreturn_t hpet_rtc_interrupt(int irq, void *dev_id)
memset(&curr_time, 0, sizeof(struct rtc_time));
if (hpet_rtc_flags & (RTC_UIE | RTC_AIE))
- get_rtc_time(&curr_time);
+ mc146818_set_time(&curr_time);
if (hpet_rtc_flags & RTC_UIE &&
curr_time.tm_sec != hpet_prev_update_sec) {
diff --git a/arch/x86/kernel/rtc.c b/arch/x86/kernel/rtc.c
index eceaa082ec3f..79c6311cd912 100644
--- a/arch/x86/kernel/rtc.c
+++ b/arch/x86/kernel/rtc.c
@@ -13,7 +13,6 @@
#include <asm/x86_init.h>
#include <asm/time.h>
#include <asm/intel-mid.h>
-#include <asm/rtc.h>
#include <asm/setup.h>
#ifdef CONFIG_X86_32
@@ -47,7 +46,7 @@ int mach_set_rtc_mmss(const struct timespec *now)
rtc_time_to_tm(nowtime, &tm);
if (!rtc_valid_tm(&tm)) {
- retval = set_rtc_time(&tm);
+ retval = mc146818_set_time(&tm);
if (retval)
printk(KERN_ERR "%s: RTC write failed with error %d\n",
__func__, retval);
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index f93545e7dc54..56400d03409f 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -51,7 +51,6 @@
#include <asm/cacheflush.h>
#include <asm/tlbflush.h>
#include <asm/x86_init.h>
-#include <asm/rtc.h>
#include <asm/uv/uv.h>
static struct efi efi_phys __initdata;
diff --git a/drivers/acpi/acpi_cmos_rtc.c b/drivers/acpi/acpi_cmos_rtc.c
index 81dc75033f15..0980a133916f 100644
--- a/drivers/acpi/acpi_cmos_rtc.c
+++ b/drivers/acpi/acpi_cmos_rtc.c
@@ -14,7 +14,7 @@
#include <linux/err.h>
#include <linux/kernel.h>
#include <linux/module.h>
-#include <asm-generic/rtc.h>
+#include <linux/mc146818rtc.h>
#include "internal.h"
diff --git a/drivers/base/power/trace.c b/drivers/base/power/trace.c
index a6975795e7f3..efec10b49d59 100644
--- a/drivers/base/power/trace.c
+++ b/drivers/base/power/trace.c
@@ -11,7 +11,7 @@
#include <linux/export.h>
#include <linux/rtc.h>
-#include <asm/rtc.h>
+#include <linux/mc146818rtc.h>
#include "power.h"
@@ -103,7 +103,7 @@ static int set_magic_time(unsigned int user, unsigned int file, unsigned int dev
n /= 24;
time.tm_min = (n % 20) * 3;
n /= 20;
- set_rtc_time(&time);
+ mc146818_set_time(&time);
return n ? -1 : 0;
}
@@ -112,7 +112,7 @@ static unsigned int read_magic_time(void)
struct rtc_time time;
unsigned int val;
- get_rtc_time(&time);
+ mc146818_get_time(&time);
pr_info("RTC time: %2d:%02d:%02d, date: %02d/%02d/%02d\n",
time.tm_hour, time.tm_min, time.tm_sec,
time.tm_mon + 1, time.tm_mday, time.tm_year % 100);
diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 601f64fcc890..31b5861649ee 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -328,7 +328,7 @@ config JS_RTC
config GEN_RTC
tristate "Generic /dev/rtc emulation"
depends on RTC!=y
- depends on ALPHA || M68K || MN10300 || PARISC || PPC || X86
+ depends on ALPHA || M68K || MN10300 || PARISC || PPC
---help---
If you say Y here and create a character special file /dev/rtc with
major number 10 and minor number 135 using mknod ("man mknod"), you
diff --git a/drivers/rtc/rtc-mrst.c b/drivers/rtc/rtc-mrst.c
index 0094d9bdd1e6..fe840c0edfef 100644
--- a/drivers/rtc/rtc-mrst.c
+++ b/drivers/rtc/rtc-mrst.c
@@ -32,11 +32,11 @@
#include <linux/interrupt.h>
#include <linux/spinlock.h>
#include <linux/kernel.h>
+#include <linux/mc146818rtc.h>
#include <linux/module.h>
#include <linux/init.h>
#include <linux/sfi.h>
-#include <asm-generic/rtc.h>
#include <asm/intel_scu_ipc.h>
#include <asm/intel-mid.h>
#include <asm/intel_mid_vrtc.h>
--
2.7.0
[toc] | [prev] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2016-05-30 22:40 +0200 |
| Message-ID | <rEC8F-Os-7@gated-at.bofh.it> |
| In reply to | #1409331 |
Hi, On 30/05/2016 at 20:57:48 +0200, Arnd Bergmann wrote : > This is the promised resend of the removal of the genrtc driver and some > related code, now that we are at a good time to merge this for the coming > merge window. > Thanks a lot! I'm applying the series right now so it sits in linux-next for a while before the next merge window. I would still happily take any acks, Reviewed-by or Tested-by tags. > - CONFIG_EFI_RTC is actively used on all six Itanium configurations, > though the CONFIG_RTC_DRV_EFI replacement driver is also available > there (and has been Itanium-only until ARM64 support for EFI was > merged). I suspect it's just a matter of getting an Ack from the > Itanium maintainers to remove it and change the defconfigs. > I have that one on my radar. There was an impressive number of separate drivers for EFI and CMOS... > - the last remaining legacy RTC driver after those is CONFIG_DS1302, > which has a slightly nonstandard ioctl interface and is only used > on arch/m32r. I have experimented with this a bit and think it > can be converted in a backward-compatible way as well. > That one has been converted to a standard SPI driver in v4.6. Following some discussion, driving it using gpios will be added. m32r will have to use one of those two interfaces. It is broken on that architecture for now but we never got any reply from maintainers. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2016-05-31 09:00 +0200 |
| Message-ID | <rELOF-7tj-3@gated-at.bofh.it> |
| In reply to | #1409364 |
Allo Alexandre,
On Mon, May 30, 2016 at 10:32 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> On 30/05/2016 at 20:57:48 +0200, Arnd Bergmann wrote :
>> This is the promised resend of the removal of the genrtc driver and some
>> related code, now that we are at a good time to merge this for the coming
>> merge window.
>>
>
> Thanks a lot!
>
> I'm applying the series right now so it sits in linux-next for a while
> before the next merge window.
>
> I would still happily take any acks, Reviewed-by or Tested-by tags.
Looks like Arnd forgot to include these when reposting:
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
For the m68k bits:
Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web