Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1407431 > unrolled thread
| Started by | "Hillf Danton" <hillf.zj@alibaba-inc.com> |
|---|---|
| First post | 2016-05-26 10:00 +0200 |
| Last post | 2016-05-27 00:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: can't boot with reiserfs on linux-4.6.0+ "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-05-26 10:00 +0200
Re: can't boot with reiserfs on linux-4.6.0+ Jeff Chua <jeff.chua.linux@gmail.com> - 2016-05-27 00:50 +0200
| From | "Hillf Danton" <hillf.zj@alibaba-inc.com> |
|---|---|
| Date | 2016-05-26 10:00 +0200 |
| Subject | Re: can't boot with reiserfs on linux-4.6.0+ |
| Message-ID | <rCYn5-3DH-15@gated-at.bofh.it> |
> > See if this fixes your reproducer.
> >
> > diff --git a/fs/xattr.c b/fs/xattr.c
> > index b11945e..49b8eab 100644
> > --- a/fs/xattr.c
> > +++ b/fs/xattr.c
> > @@ -667,6 +667,9 @@ xattr_resolve_name(const struct xattr_handler **handlers, const char **name)
> > {
> > const struct xattr_handler *handler;
> >
> > + if (!handlers)
> > + return NULL;
> > +
> > if (!*name)
> > return NULL;
> >
>
> Tried, but doesn't work.
>
See if this fixes your reproducer.
--- linux-4.6/fs/xattr.c Mon May 16 06:43:13 2016
+++ b/fs/xattr.c Thu May 26 15:36:14 2016
@@ -667,8 +667,8 @@ xattr_resolve_name(const struct xattr_ha
{
const struct xattr_handler *handler;
- if (!*name)
- return NULL;
+ if (!handlers || !*name)
+ return ERR_PTR(-EINVAL);
for_each_xattr_handler(handlers, handler) {
const char *n;
--
[toc] | [next] | [standalone]
| From | Jeff Chua <jeff.chua.linux@gmail.com> |
|---|---|
| Date | 2016-05-27 00:50 +0200 |
| Message-ID | <rDcgh-3I8-7@gated-at.bofh.it> |
| In reply to | #1407431 |
On Thu, May 26, 2016 at 3:46 PM, Hillf Danton <hillf.zj@alibaba-inc.com> wrote:
>> > See if this fixes your reproducer.
>> >
>> > diff --git a/fs/xattr.c b/fs/xattr.c
>> > index b11945e..49b8eab 100644
>> > --- a/fs/xattr.c
>> > +++ b/fs/xattr.c
>> > @@ -667,6 +667,9 @@ xattr_resolve_name(const struct xattr_handler **handlers, const char **name)
>> > {
>> > const struct xattr_handler *handler;
>> >
>> > + if (!handlers)
>> > + return NULL;
>> > +
>> > if (!*name)
>> > return NULL;
>> >
>>
>> Tried, but doesn't work.
>>
> See if this fixes your reproducer.
>
> --- linux-4.6/fs/xattr.c Mon May 16 06:43:13 2016
> +++ b/fs/xattr.c Thu May 26 15:36:14 2016
> @@ -667,8 +667,8 @@ xattr_resolve_name(const struct xattr_ha
> {
> const struct xattr_handler *handler;
>
> - if (!*name)
> - return NULL;
> + if (!handlers || !*name)
> + return ERR_PTR(-EINVAL);
>
> for_each_xattr_handler(handlers, handler) {
> const char *n;
> --
Hillf,
That worked and it's already in Linus's latest tree.
Thanks for sharing.
Jeff
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web