Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1407563 > unrolled thread

[PATCH] clk: rockchip: fix cclk error handing

Back to article view | Back to linux.kernel

Contents

  [PATCH] clk: rockchip: fix cclk error handing Xing Zheng <zhengxing@rock-chips.com> - 2016-05-26 15:50 +0200
    Re: [PATCH] clk: rockchip: fix cclk error handing Heiko Stuebner <heiko@sntech.de> - 2016-05-26 23:50 +0200

#1407563 — [PATCH] clk: rockchip: fix cclk error handing

It maybe due to a copy-paste error the error handing should be
cclk not clk.

Reported-by: Lin Huang <lin.huang@rock-chips.com>
Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
---

 drivers/clk/rockchip/clk-cpu.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/rockchip/clk-cpu.c b/drivers/clk/rockchip/clk-cpu.c
index 4bb130c..05b3d73 100644
--- a/drivers/clk/rockchip/clk-cpu.c
+++ b/drivers/clk/rockchip/clk-cpu.c
@@ -321,9 +321,9 @@ struct clk *rockchip_clk_register_cpuclk(const char *name,
 	}
 
 	cclk = clk_register(NULL, &cpuclk->hw);
-	if (IS_ERR(clk)) {
+	if (IS_ERR(cclk)) {
 		pr_err("%s: could not register cpuclk %s\n", __func__,	name);
-		ret = PTR_ERR(clk);
+		ret = PTR_ERR(cclk);
 		goto free_rate_table;
 	}
 
-- 
1.7.9.5

[toc] | [next] | [standalone]

#1407732

Am Donnerstag, 26. Mai 2016, 21:49:08 schrieb Xing Zheng:
> It maybe due to a copy-paste error the error handing should be
> cclk not clk.
> 
> Reported-by: Lin Huang <lin.huang@rock-chips.com>
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>

applied to my clk-fixes branch after adapting the commit message a bit.


Thanks for catching that
Heiko

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web