Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1408334 > unrolled thread

[PATCH v5 3/4] iio: stx104: Allow build for X86_64

Started byWilliam Breathitt Gray <vilhelm.gray@gmail.com>
First post2016-05-28 00:10 +0200
Last post2016-05-28 19:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH v5 3/4] iio: stx104: Allow build for X86_64 William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-05-28 00:10 +0200
    Re: [PATCH v5 3/4] iio: stx104: Allow build for X86_64 Jonathan Cameron <jic23@kernel.org> - 2016-05-28 19:20 +0200

#1408334 — [PATCH v5 3/4] iio: stx104: Allow build for X86_64

FromWilliam Breathitt Gray <vilhelm.gray@gmail.com>
Date2016-05-28 00:10 +0200
Subject[PATCH v5 3/4] iio: stx104: Allow build for X86_64
Message-ID<rDy77-FP-7@gated-at.bofh.it>
With the introduction of the ISA_BUS_API Kconfig option, ISA-style
drivers may be built for X86_64 architectures. This patch changes the
ISA Kconfig option dependency of the Apex Embedded Systems STX104 DAC
driver to ISA_BUS_API, thus allowing it to build for X86_64 as it is
expected to.

Cc: Hartmut Knaack <knaack.h@gmx.de>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: Jonathan Cameron <jic23@kernel.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
 drivers/iio/dac/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
index e63b957..f7c71da 100644
--- a/drivers/iio/dac/Kconfig
+++ b/drivers/iio/dac/Kconfig
@@ -247,7 +247,7 @@ config MCP4922
 
 config STX104
 	tristate "Apex Embedded Systems STX104 DAC driver"
-	depends on X86 && ISA
+	depends on X86 && ISA_BUS_API
 	help
 	  Say yes here to build support for the 2-channel DAC on the Apex
 	  Embedded Systems STX104 integrated analog PC/104 card. The base port
-- 
2.7.3

[toc] | [next] | [standalone]


#1408497

FromJonathan Cameron <jic23@kernel.org>
Date2016-05-28 19:20 +0200
Message-ID<rDQ41-3gu-9@gated-at.bofh.it>
In reply to#1408334
On 27/05/16 23:09, William Breathitt Gray wrote:
> With the introduction of the ISA_BUS_API Kconfig option, ISA-style
> drivers may be built for X86_64 architectures. This patch changes the
> ISA Kconfig option dependency of the Apex Embedded Systems STX104 DAC
> driver to ISA_BUS_API, thus allowing it to build for X86_64 as it is
> expected to.
> 
> Cc: Hartmut Knaack <knaack.h@gmx.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
I've only been following this discussion very vaguely, but the consensus seems
to be good, so feel free to apply this one with my Ack for IIO.
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
>  drivers/iio/dac/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index e63b957..f7c71da 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -247,7 +247,7 @@ config MCP4922
>  
>  config STX104
>  	tristate "Apex Embedded Systems STX104 DAC driver"
> -	depends on X86 && ISA
> +	depends on X86 && ISA_BUS_API
>  	help
>  	  Say yes here to build support for the 2-channel DAC on the Apex
>  	  Embedded Systems STX104 integrated analog PC/104 card. The base port
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web