Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1407506 > unrolled thread
| Started by | David Vrabel <david.vrabel@citrix.com> |
|---|---|
| First post | 2016-05-26 12:40 +0200 |
| Last post | 2016-05-28 00:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [Xen-devel] [PATCH] xen: remove incorrect forward declaration David Vrabel <david.vrabel@citrix.com> - 2016-05-26 12:40 +0200
Re: [Xen-devel] [PATCH] xen: remove incorrect forward declaration Arnd Bergmann <arnd@arndb.de> - 2016-05-28 00:00 +0200
| From | David Vrabel <david.vrabel@citrix.com> |
|---|---|
| Date | 2016-05-26 12:40 +0200 |
| Subject | Re: [Xen-devel] [PATCH] xen: remove incorrect forward declaration |
| Message-ID | <rD0RQ-5hu-23@gated-at.bofh.it> |
On 11/05/16 14:07, Arnd Bergmann wrote: > A bugfix patch for the xen balloon driver introduced a forward > declaration for a static function that is conditionally compiled, > causing a warning if only the declaration but not the definition > are there: > > drivers/xen/balloon.c:154:13: error: 'release_memory_resource' declared 'static' but never defined [-Werror=unused-function] > static void release_memory_resource(struct resource *resource); > > This removes the declaration again and instead moves the function > definition to the right place, before its first caller and inside > of the #ifdef protecting both. I've applied the equivalent patch from Ross, instead. > The patch that introduced the warning is marked for stable > backports, so if that gets applied to 4.4, so should this one. Fixes for compiler warnings are not sufficiently important to be backported to stable. David
[toc] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-05-28 00:00 +0200 |
| Message-ID | <rDxXs-ni-17@gated-at.bofh.it> |
| In reply to | #1407506 |
On Thursday, May 26, 2016 11:32:40 AM CEST David Vrabel wrote: > On 11/05/16 14:07, Arnd Bergmann wrote: > > A bugfix patch for the xen balloon driver introduced a forward > > declaration for a static function that is conditionally compiled, > > causing a warning if only the declaration but not the definition > > are there: > > > > drivers/xen/balloon.c:154:13: error: 'release_memory_resource' declared 'static' but never defined [-Werror=unused-function] > > static void release_memory_resource(struct resource *resource); > > > > This removes the declaration again and instead moves the function > > definition to the right place, before its first caller and inside > > of the #ifdef protecting both. > > I've applied the equivalent patch from Ross, instead. Ok, thanks. > > The patch that introduced the warning is marked for stable > > backports, so if that gets applied to 4.4, so should this one. > > Fixes for compiler warnings are not sufficiently important to be > backported to stable. Sure, but this is not an existing warning but one that only gets introduced after the other patch gets backported, which I'd consider a different category. Arnd
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web