Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1406338 > unrolled thread

[PATCH 1/3] arm64: Remove orphaned __addr_ok() definition

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/3] arm64: Remove orphaned __addr_ok() definition Robin Murphy <robin.murphy@arm.com> - 2016-05-24 20:10 +0200
    [PATCH 2/3] ARM: Remove orphaned __addr_ok() definition Robin Murphy <robin.murphy@arm.com> - 2016-05-24 20:10 +0200
    [PATCH 3/3] openrisc: Remove orphaned __addr_ok() definition Robin Murphy <robin.murphy@arm.com> - 2016-05-24 20:10 +0200

#1406338 — [PATCH 1/3] arm64: Remove orphaned __addr_ok() definition

Since commit 12a0ef7b0ac3 ("arm64: use generic strnlen_user and
strncpy_from_user functions"), the definition of __addr_ok() has been
languishing unused; eradicate the sucker.

CC: Will Deacon <will.deacon@arm.com>
CC: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
 arch/arm64/include/asm/uaccess.h | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h
index 0685d74572af..9e397a542756 100644
--- a/arch/arm64/include/asm/uaccess.h
+++ b/arch/arm64/include/asm/uaccess.h
@@ -81,19 +81,6 @@ static inline void set_fs(mm_segment_t fs)
 #define segment_eq(a, b)	((a) == (b))
 
 /*
- * Return 1 if addr < current->addr_limit, 0 otherwise.
- */
-#define __addr_ok(addr)							\
-({									\
-	unsigned long flag;						\
-	asm("cmp %1, %0; cset %0, lo"					\
-		: "=&r" (flag)						\
-		: "r" (addr), "0" (current_thread_info()->addr_limit)	\
-		: "cc");						\
-	flag;								\
-})
-
-/*
  * Test whether a block of memory is a valid user space address.
  * Returns 1 if the range is valid, 0 otherwise.
  *
-- 
2.8.1.dirty

[toc] | [next] | [standalone]

#1406352 — [PATCH 2/3] ARM: Remove orphaned __addr_ok() definition

Since commit 8c56cc8be5b3 ("ARM: 7449/1: use generic strnlen_user and
strncpy_from_user functions"), the definition of __addr_ok() has been
languishing unused; eradicate the sucker.

CC: Russell King <linux@armlinux.org.uk>
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
 arch/arm/include/asm/uaccess.h | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/arch/arm/include/asm/uaccess.h b/arch/arm/include/asm/uaccess.h
index 35c9db857ebe..7badc3e55109 100644
--- a/arch/arm/include/asm/uaccess.h
+++ b/arch/arm/include/asm/uaccess.h
@@ -104,14 +104,6 @@ static inline void set_fs(mm_segment_t fs)
 
 #define segment_eq(a, b)	((a) == (b))
 
-#define __addr_ok(addr) ({ \
-	unsigned long flag; \
-	__asm__("cmp %2, %0; movlo %0, #0" \
-		: "=&r" (flag) \
-		: "0" (current_thread_info()->addr_limit), "r" (addr) \
-		: "cc"); \
-	(flag == 0); })
-
 /* We use 33-bit arithmetic here... */
 #define __range_ok(addr, size) ({ \
 	unsigned long flag, roksum; \
-- 
2.8.1.dirty

[toc] | [prev] | [next] | [standalone]

#1406363 — [PATCH 3/3] openrisc: Remove orphaned __addr_ok() definition

Since commit b48b2c3e5043 ("openrisc: use generic strnlen_user()
function"), the definition of __addr_ok() has been languishing unused;
eradicate the sucker.

CC: Jonas Bonn <jonas@southpole.se>
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
 arch/openrisc/include/asm/uaccess.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/openrisc/include/asm/uaccess.h b/arch/openrisc/include/asm/uaccess.h
index a6bd07ca3d6c..74bcb34c6d0b 100644
--- a/arch/openrisc/include/asm/uaccess.h
+++ b/arch/openrisc/include/asm/uaccess.h
@@ -59,9 +59,6 @@
  */
 #define __range_ok(addr, size) (size <= get_fs() && addr <= (get_fs()-size))
 
-/* Ensure that addr is below task's addr_limit */
-#define __addr_ok(addr) ((unsigned long) addr < get_fs())
-
 #define access_ok(type, addr, size) \
 	__range_ok((unsigned long)addr, (unsigned long)size)
 
-- 
2.8.1.dirty

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web