Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1406141 > unrolled thread
| Started by | Javi Merino <javi.merino@arm.com> |
|---|---|
| First post | 2016-05-24 15:10 +0200 |
| Last post | 2016-05-25 05:40 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 4/5] thermal: bang-bang governor: act on lower trip boundary Javi Merino <javi.merino@arm.com> - 2016-05-24 15:10 +0200
Re: [PATCH v2 4/5] thermal: bang-bang governor: act on lower trip boundary "Peter Feuerer" <peter@piie.net> - 2016-05-24 15:20 +0200
Re: [PATCH v2 4/5] thermal: bang-bang governor: act on lower trip boundary "Peter Feuerer" <peter@piie.net> - 2016-05-24 19:40 +0200
Re: [PATCH v2 4/5] thermal: bang-bang governor: act on lower trip boundary Caesar Wang <wxt@rock-chips.com> - 2016-05-25 05:40 +0200
| From | Javi Merino <javi.merino@arm.com> |
|---|---|
| Date | 2016-05-24 15:10 +0200 |
| Subject | Re: [PATCH v2 4/5] thermal: bang-bang governor: act on lower trip boundary |
| Message-ID | <rCkfU-3Ft-27@gated-at.bofh.it> |
Ccing Peter Feuerer, author of the bang bang governor. On Tue, May 03, 2016 at 05:33:32PM +0800, Caesar Wang wrote: > From: Sascha Hauer <s.hauer@pengutronix.de> > > With interrupt driven thermal zones we pass the lower and upper > temperature on which shall be acted, so in the governor we have to act on > the exact lower temperature to be consistent. Otherwise an interrupt maybe > generated on the exact lower temperature, but the bang bang governor does > not react since The polling driven zones have to be one step cooler before > the governor reacts. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > Signed-off-by: Caesar Wang <wxt@rock-chips.com> > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: Eduardo Valentin <edubezval@gmail.com> > Cc: linux-pm@vger.kernel.org > > --- > > Changes in v2: > - Update the commit for patch[v2 4/5]. > > drivers/thermal/gov_bang_bang.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c > index 70836c5..9d1dfea 100644 > --- a/drivers/thermal/gov_bang_bang.c > +++ b/drivers/thermal/gov_bang_bang.c > @@ -59,7 +59,7 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip) > if (instance->target == 0 && tz->temperature >= trip_temp) > instance->target = 1; > else if (instance->target == 1 && > - tz->temperature < trip_temp - trip_hyst) > + tz->temperature <= trip_temp - trip_hyst) > instance->target = 0; > > dev_dbg(&instance->cdev->device, "target=%d\n", > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
[toc] | [next] | [standalone]
| From | "Peter Feuerer" <peter@piie.net> |
|---|---|
| Date | 2016-05-24 15:20 +0200 |
| Message-ID | <rCkpA-3IP-23@gated-at.bofh.it> |
| In reply to | #1406141 |
Hi, 24. Mai 2016 15:06 Uhr, "Javi Merino" <javi.merino@arm.com> schrieb: > Ccing Peter Feuerer, author of the bang bang governor. thanks, will take care today in the evening. --peter; > > On Tue, May 03, 2016 at 05:33:32PM +0800, Caesar Wang wrote: > >> From: Sascha Hauer <s.hauer@pengutronix.de> >> >> With interrupt driven thermal zones we pass the lower and upper >> temperature on which shall be acted, so in the governor we have to act on >> the exact lower temperature to be consistent. Otherwise an interrupt maybe >> generated on the exact lower temperature, but the bang bang governor does >> not react since The polling driven zones have to be one step cooler before >> the governor reacts. >> >> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> >> Signed-off-by: Caesar Wang <wxt@rock-chips.com> >> Cc: Zhang Rui <rui.zhang@intel.com> >> Cc: Eduardo Valentin <edubezval@gmail.com> >> Cc: linux-pm@vger.kernel.org >> >> --- >> >> Changes in v2: >> - Update the commit for patch[v2 4/5]. >> >> drivers/thermal/gov_bang_bang.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c >> index 70836c5..9d1dfea 100644 >> --- a/drivers/thermal/gov_bang_bang.c >> +++ b/drivers/thermal/gov_bang_bang.c >> @@ -59,7 +59,7 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip) >> if (instance->target == 0 && tz->temperature >= trip_temp) >> instance->target = 1; >> else if (instance->target == 1 && >> - tz->temperature < trip_temp - trip_hyst) >> + tz->temperature <= trip_temp - trip_hyst) >> instance->target = 0; >> >> dev_dbg(&instance->cdev->device, "target=%d\n", >> -- >> 1.9.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-pm" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [next] | [standalone]
| From | "Peter Feuerer" <peter@piie.net> |
|---|---|
| Date | 2016-05-24 19:40 +0200 |
| Message-ID | <rCotc-6fG-17@gated-at.bofh.it> |
| In reply to | #1406141 |
Hi, 24. Mai 2016 15:06 Uhr, "Javi Merino" <javi.merino@arm.com> schrieb: > Ccing Peter Feuerer, author of the bang bang governor. > > On Tue, May 03, 2016 at 05:33:32PM +0800, Caesar Wang wrote: > >> From: Sascha Hauer <s.hauer@pengutronix.de> >> >> With interrupt driven thermal zones we pass the lower and upper >> temperature on which shall be acted, so in the governor we have to act on >> the exact lower temperature to be consistent. Otherwise an interrupt maybe >> generated on the exact lower temperature, but the bang bang governor does >> not react since The polling driven zones have to be one step cooler before >> the governor reacts. >> >> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> >> Signed-off-by: Caesar Wang <wxt@rock-chips.com> >> Cc: Zhang Rui <rui.zhang@intel.com> >> Cc: Eduardo Valentin <edubezval@gmail.com> >> Cc: linux-pm@vger.kernel.org Acked-by: Peter Feuerer <peter@piie.net> >> >> --- >> >> Changes in v2: >> - Update the commit for patch[v2 4/5]. >> >> drivers/thermal/gov_bang_bang.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c >> index 70836c5..9d1dfea 100644 >> --- a/drivers/thermal/gov_bang_bang.c >> +++ b/drivers/thermal/gov_bang_bang.c >> @@ -59,7 +59,7 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip) >> if (instance->target == 0 && tz->temperature >= trip_temp) >> instance->target = 1; >> else if (instance->target == 1 && >> - tz->temperature < trip_temp - trip_hyst) >> + tz->temperature <= trip_temp - trip_hyst) >> instance->target = 0; >> >> dev_dbg(&instance->cdev->device, "target=%d\n", >> -- >> 1.9.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-pm" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [next] | [standalone]
| From | Caesar Wang <wxt@rock-chips.com> |
|---|---|
| Date | 2016-05-25 05:40 +0200 |
| Message-ID | <rCxPP-4ey-7@gated-at.bofh.it> |
| In reply to | #1406304 |
On 2016年05月25日 01:34, Peter Feuerer wrote: > Hi, > > 24. Mai 2016 15:06 Uhr, "Javi Merino" <javi.merino@arm.com> schrieb: >> Ccing Peter Feuerer, author of the bang bang governor. >> >> On Tue, May 03, 2016 at 05:33:32PM +0800, Caesar Wang wrote: >> >>> From: Sascha Hauer <s.hauer@pengutronix.de> >>> >>> With interrupt driven thermal zones we pass the lower and upper >>> temperature on which shall be acted, so in the governor we have to act on >>> the exact lower temperature to be consistent. Otherwise an interrupt maybe >>> generated on the exact lower temperature, but the bang bang governor does >>> not react since The polling driven zones have to be one step cooler before >>> the governor reacts. >>> >>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> >>> Signed-off-by: Caesar Wang <wxt@rock-chips.com> >>> Cc: Zhang Rui <rui.zhang@intel.com> >>> Cc: Eduardo Valentin <edubezval@gmail.com> >>> Cc: linux-pm@vger.kernel.org > Acked-by: Peter Feuerer <peter@piie.net> Okay, thanks your reviewing. :) > > >>> --- >>> >>> Changes in v2: >>> - Update the commit for patch[v2 4/5]. >>> >>> drivers/thermal/gov_bang_bang.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c >>> index 70836c5..9d1dfea 100644 >>> --- a/drivers/thermal/gov_bang_bang.c >>> +++ b/drivers/thermal/gov_bang_bang.c >>> @@ -59,7 +59,7 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip) >>> if (instance->target == 0 && tz->temperature >= trip_temp) >>> instance->target = 1; >>> else if (instance->target == 1 && >>> - tz->temperature < trip_temp - trip_hyst) >>> + tz->temperature <= trip_temp - trip_hyst) >>> instance->target = 0; >>> >>> dev_dbg(&instance->cdev->device, "target=%d\n", >>> -- >>> 1.9.1 >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-pm" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- caesar wang | software engineer | wxt@rock-chip.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web