Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1406067 > unrolled thread

[PATCH 0/3] debugfs: fixes to "file removal race" series

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] debugfs: fixes to "file removal race" series Nicolai Stange <nicstange@gmail.com> - 2016-05-24 13:10 +0200
    [PATCH 1/3] debugfs: remove extra debugfs_create_file_unsafe() declaration Nicolai Stange <nicstange@gmail.com> - 2016-05-24 13:20 +0200

#1406067 — [PATCH 0/3] debugfs: fixes to "file removal race" series

Hi Greg,

the recent report by Sasha Levin made me review my debugfs
"file removal race" series again.

For your reference, the original series in question was posted here:
http://lkml.kernel.org/g/1458652280-19785-1-git-send-email-nicstange@gmail.com
It has been merged through your driver-core tree into mainline.


Unfortunately, I found three issues:

The first one is a minor code style issue.
The second one is more serious: on ->open() failure, references to modules
as well as memory are leaked.
The third one is a potential leak of module references with future debugfs
users.

The patches don't depend on each other and are unrelated except that they
all address issues introduced by the same series.
I tested them with linux-next 20160523.

Apologies and thanks,

Nicolai

Nicolai Stange (3):
  debugfs: remove extra debugfs_create_file_unsafe() declaration
  debugfs: full_proxy_open(): free proxy on ->open() failure
  debugfs: open_proxy_open(): avoid double fops release

 fs/debugfs/file.c     | 7 ++++---
 fs/debugfs/internal.h | 4 ----
 2 files changed, 4 insertions(+), 7 deletions(-)

-- 
2.8.2

[toc] | [next] | [standalone]

#1406077 — [PATCH 1/3] debugfs: remove extra debugfs_create_file_unsafe() declaration

debugfs_create_file_unsafe() is declared twice in exactly the same
manner each: once in fs/debugfs/internal.h and once in
include/linux/debugfs.h

All files that include the former also include the latter and thus,
the declaration in fs/debugfs/internal.h is superfluous.

Remove it.

Signed-off-by: Nicolai Stange <nicstange@gmail.com>
---
 fs/debugfs/internal.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/fs/debugfs/internal.h b/fs/debugfs/internal.h
index bba5263..b3e8443 100644
--- a/fs/debugfs/internal.h
+++ b/fs/debugfs/internal.h
@@ -19,8 +19,4 @@ extern const struct file_operations debugfs_noop_file_operations;
 extern const struct file_operations debugfs_open_proxy_file_operations;
 extern const struct file_operations debugfs_full_proxy_file_operations;
 
-struct dentry *debugfs_create_file_unsafe(const char *name, umode_t mode,
-					struct dentry *parent, void *data,
-					const struct file_operations *fops);
-
 #endif /* _DEBUGFS_INTERNAL_H_ */
-- 
2.8.2

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web