Groups > linux.kernel > #1405874 > unrolled thread

[git pull] check headers fix.

Started by	Dave Airlie <airlied@linux.ie>
First post	2016-05-24 08:30 +0200
Last post	2016-05-24 12:20 +0200
Articles	4 — 4 participants

Back to article view | Back to linux.kernel

  [git pull] check headers fix. Dave Airlie <airlied@linux.ie> - 2016-05-24 08:30 +0200
    Re: [git pull] check headers fix. Christoph Hellwig <hch@infradead.org> - 2016-05-24 11:20 +0200
      Re: [git pull] check headers fix. Jani Nikula <jani.nikula@linux.intel.com> - 2016-05-24 12:00 +0200
        Re: [git pull] check headers fix. Daniel Vetter <daniel@ffwll.ch> - 2016-05-24 12:20 +0200

#1405874 — [git pull] check headers fix.

From	Dave Airlie <airlied@linux.ie>
Date	2016-05-24 08:30 +0200
Subject	[git pull] check headers fix.
Message-ID	<rCe0O-89R-25@gated-at.bofh.it>

Hi Linus,

here is the C++ guards warning fix from Arnd.

I've tried using a tag for this.

Dave.

The following changes since commit 84787c572d402644dca4874aba73324d9f8e3948:

  Merge branch 'akpm' (patches from Andrew) (2016-05-23 19:42:28 -0700)

are available in the git repository at:

  git://people.freedesktop.org/~airlied/linux tags/drm-4.7-rc1-headers-fix

for you to fetch changes up to 92181d47ee74749bdf902f080dab9fa9ef44b37f:

  headers_check: don't warn about c++ guards (2016-05-24 14:12:48 +1000)

----------------------------------------------------------------
Arnd Bergmann (1):
      headers_check: don't warn about c++ guards

 scripts/headers_check.pl | 4 ++++
 1 file changed, 4 insertions(+)

[toc] | [next] | [standalone]

#1405976

From	Christoph Hellwig <hch@infradead.org>
Date	2016-05-24 11:20 +0200
Message-ID	<rCgFj-1o2-9@gated-at.bofh.it>
In reply to	#1405874

On Tue, May 24, 2016 at 07:29:25AM +0100, Dave Airlie wrote:
> 
> Hi Linus,
> 
> here is the C++ guards warning fix from Arnd.

So why the hell do we have C++ guards in kernel headers?

[toc] | [prev] | [next] | [standalone]

#1406014

From	Jani Nikula <jani.nikula@linux.intel.com>
Date	2016-05-24 12:00 +0200
Message-ID	<rChi2-1AN-11@gated-at.bofh.it>
In reply to	#1405976

On Tue, 24 May 2016, Christoph Hellwig <hch@infradead.org> wrote:
> On Tue, May 24, 2016 at 07:29:25AM +0100, Dave Airlie wrote:
>> 
>> Hi Linus,
>> 
>> here is the C++ guards warning fix from Arnd.
>
> So why the hell do we have C++ guards in kernel headers?

uapi headers. See [1] for the cover letter to the patches with
rationale.

BR,
Jani.


[1] http://mid.gmane.org/1461269857-12813-1-git-send-email-emil.l.velikov@gmail.com


-- 
Jani Nikula, Intel Open Source Technology Center

[toc] | [prev] | [next] | [standalone]

#1406031

From	Daniel Vetter <daniel@ffwll.ch>
Date	2016-05-24 12:20 +0200
Message-ID	<rChBn-1Ye-5@gated-at.bofh.it>
In reply to	#1406014

On Tue, May 24, 2016 at 11:52 AM, Jani Nikula
<jani.nikula@linux.intel.com> wrote:
> On Tue, 24 May 2016, Christoph Hellwig <hch@infradead.org> wrote:
>> On Tue, May 24, 2016 at 07:29:25AM +0100, Dave Airlie wrote:
>>>
>>> Hi Linus,
>>>
>>> here is the C++ guards warning fix from Arnd.
>>
>> So why the hell do we have C++ guards in kernel headers?
>
> uapi headers. See [1] for the cover letter to the patches with
> rationale.

Short summary: We want to directly reuse the headers generated by make
headers_install for the userspace side of gpu drivers, and at least
some driver teams use C++ for the compilers in there.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

[toc] | [prev] | [standalone]

csiph-web

[git pull] check headers fix.

Contents

#1405874 — [git pull] check headers fix.

#1405976

#1406014

#1406031