Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1406132 > unrolled thread
| Started by | Anna-Maria Gleixner <anna-maria@linutronix.de> |
|---|---|
| First post | 2016-05-24 15:10 +0200 |
| Last post | 2016-05-25 12:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] MIPS: Add missing FROZEN hotplug notifier transitions Anna-Maria Gleixner <anna-maria@linutronix.de> - 2016-05-24 15:10 +0200
Re: [PATCH] MIPS: Add missing FROZEN hotplug notifier transitions David Daney <ddaney.cavm@gmail.com> - 2016-05-24 20:20 +0200
Re: [PATCH] MIPS: Add missing FROZEN hotplug notifier transitions Anna-Maria Gleixner <anna-maria@linutronix.de> - 2016-05-25 12:00 +0200
| From | Anna-Maria Gleixner <anna-maria@linutronix.de> |
|---|---|
| Date | 2016-05-24 15:10 +0200 |
| Subject | [PATCH] MIPS: Add missing FROZEN hotplug notifier transitions |
| Message-ID | <rCkfT-3Ft-7@gated-at.bofh.it> |
The corresponding FROZEN hotplug notifier transitions used on
suspend/resume are ignored. Therefore the switch case action argument
is masked with the frozen hotplug notifier transition mask.
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
---
arch/mips/cavium-octeon/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/mips/cavium-octeon/smp.c
+++ b/arch/mips/cavium-octeon/smp.c
@@ -384,7 +384,7 @@ static int octeon_cpu_callback(struct no
{
unsigned int cpu = (unsigned long)hcpu;
- switch (action) {
+ switch (action & ~CPU_TASKS_FROZEN) {
case CPU_UP_PREPARE:
octeon_update_boot_vector(cpu);
break;
[toc] | [next] | [standalone]
| From | David Daney <ddaney.cavm@gmail.com> |
|---|---|
| Date | 2016-05-24 20:20 +0200 |
| Message-ID | <rCp5T-6JY-21@gated-at.bofh.it> |
| In reply to | #1406132 |
On 05/24/2016 06:08 AM, Anna-Maria Gleixner wrote:
> The corresponding FROZEN hotplug notifier transitions used on
> suspend/resume are ignored. Therefore the switch case action argument
> is masked with the frozen hotplug notifier transition mask.
>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
This seems sane, and I don't object, but can you tell us how this was
tested?
Thanks,
David Daney
> ---
> arch/mips/cavium-octeon/smp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/mips/cavium-octeon/smp.c
> +++ b/arch/mips/cavium-octeon/smp.c
> @@ -384,7 +384,7 @@ static int octeon_cpu_callback(struct no
> {
> unsigned int cpu = (unsigned long)hcpu;
>
> - switch (action) {
> + switch (action & ~CPU_TASKS_FROZEN) {
> case CPU_UP_PREPARE:
> octeon_update_boot_vector(cpu);
> break;
>
>
[toc] | [prev] | [next] | [standalone]
| From | Anna-Maria Gleixner <anna-maria@linutronix.de> |
|---|---|
| Date | 2016-05-25 12:00 +0200 |
| Message-ID | <rCDLz-7RB-1@gated-at.bofh.it> |
| In reply to | #1406368 |
On Tue, 24 May 2016, David Daney wrote: > On 05/24/2016 06:08 AM, Anna-Maria Gleixner wrote: > > The corresponding FROZEN hotplug notifier transitions used on > > suspend/resume are ignored. Therefore the switch case action argument > > is masked with the frozen hotplug notifier transition mask. > > > > Cc: Ralf Baechle <ralf@linux-mips.org> > > Cc: linux-mips@linux-mips.org > > Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de> > > This seems sane, and I don't object, but can you tell us how this was tested? It is compile tested only due to lack of hardware. Anna-Maria
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web