Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1404838 > unrolled thread
| Started by | Muhammad Falak R Wani <falakreyaz@gmail.com> |
|---|---|
| First post | 2016-05-21 15:10 +0200 |
| Last post | 2016-05-24 02:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] xen/privcmd: use vma_pages(). Muhammad Falak R Wani <falakreyaz@gmail.com> - 2016-05-21 15:10 +0200
Re: [PATCH] xen/privcmd: use vma_pages(). Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-05-23 22:30 +0200
Re: [PATCH] xen/privcmd: use vma_pages(). Muhammad Falak R Wani <falakreyaz@gmail.com> - 2016-05-24 02:10 +0200
| From | Muhammad Falak R Wani <falakreyaz@gmail.com> |
|---|---|
| Date | 2016-05-21 15:10 +0200 |
| Subject | [PATCH] xen/privcmd: use vma_pages(). |
| Message-ID | <rBePf-3U4-15@gated-at.bofh.it> |
Replace explicit computation of vma page count by a call to
vma_pages()
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
---
drivers/xen/privcmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
index df2e6f7..702040f 100644
--- a/drivers/xen/privcmd.c
+++ b/drivers/xen/privcmd.c
@@ -582,7 +582,7 @@ static long privcmd_ioctl(struct file *file,
static void privcmd_close(struct vm_area_struct *vma)
{
struct page **pages = vma->vm_private_data;
- int numpgs = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
+ int numpgs = vma_pages(vma);
int numgfns = (vma->vm_end - vma->vm_start) >> XEN_PAGE_SHIFT;
int rc;
--
1.9.1
[toc] | [next] | [standalone]
| From | Boris Ostrovsky <boris.ostrovsky@oracle.com> |
|---|---|
| Date | 2016-05-23 22:30 +0200 |
| Message-ID | <rC4E9-27h-9@gated-at.bofh.it> |
| In reply to | #1404838 |
On 05/21/2016 09:09 AM, Muhammad Falak R Wani wrote:
> Replace explicit computation of vma page count by a call to
> vma_pages()
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> drivers/xen/privcmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
> index df2e6f7..702040f 100644
> --- a/drivers/xen/privcmd.c
> +++ b/drivers/xen/privcmd.c
> @@ -582,7 +582,7 @@ static long privcmd_ioctl(struct file *file,
> static void privcmd_close(struct vm_area_struct *vma)
> {
> struct page **pages = vma->vm_private_data;
> - int numpgs = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> + int numpgs = vma_pages(vma);
> int numgfns = (vma->vm_end - vma->vm_start) >> XEN_PAGE_SHIFT;
> int rc;
>
Can you combine all three patches into a single one?
Thanks.
-boris
[toc] | [prev] | [next] | [standalone]
| From | Muhammad Falak R Wani <falakreyaz@gmail.com> |
|---|---|
| Date | 2016-05-24 02:10 +0200 |
| Message-ID | <rC853-4h8-13@gated-at.bofh.it> |
| In reply to | #1405609 |
On Mon, May 23, 2016 at 04:26:37PM -0400, Boris Ostrovsky wrote: > On 05/21/2016 09:09 AM, Muhammad Falak R Wani wrote: > > Replace explicit computation of vma page count by a call to > > vma_pages() > > > > Can you combine all three patches into a single one? > > Thanks. > -boris > Sure, I have sent V2 with the required changes. :) -mfrw
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web