Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1405297 > unrolled thread

[PATCH 0/4] usb: gadget: fix most of W=1 warinngs

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/4] usb: gadget: fix most of W=1 warinngs Michal Nazarewicz <mina86@mina86.com> - 2016-05-23 13:50 +0200
    [PATCH 2/4] usb: gadget: m66592: fix unused-but-set-variable warnings Michal Nazarewicz <mina86@mina86.com> - 2016-05-23 13:50 +0200
    Re: [PATCH 0/4] usb: gadget: fix most of W=1 warinngs Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-05-31 09:20 +0200

#1405297 — [PATCH 0/4] usb: gadget: fix most of W=1 warinngs

Fixes all of the unused-but-set-variable warnings enabled when
building with W=1.  As described in the first patch, some warnings are
left off.  See said patch for more description.

Michal Nazarewicz (4):
  usb: gadget: fix unused-but-set-variale warnings
  usb: gadget: m66592: fix unused-but-set-variable warnings
  usb: gadget: r8a66597: fix unused-but-set-variable warnings
  usb: gadget: mv_u3d: fix unused-but-set-variable warnings

 drivers/usb/gadget/function/f_fs.c     |  3 +-
 drivers/usb/gadget/function/u_serial.c |  3 +-
 drivers/usb/gadget/legacy/g_ffs.c      | 15 ++++------
 drivers/usb/gadget/udc/amd5536udc.c    |  9 +-----
 drivers/usb/gadget/udc/bdc/bdc_cmd.c   |  3 --
 drivers/usb/gadget/udc/bdc/bdc_ep.c    |  4 ---
 drivers/usb/gadget/udc/dummy_hcd.c     |  5 ----
 drivers/usb/gadget/udc/m66592-udc.c    | 24 ++++-----------
 drivers/usb/gadget/udc/mv_u3d_core.c   | 23 ++-------------
 drivers/usb/gadget/udc/mv_udc_core.c   |  9 ++----
 drivers/usb/gadget/udc/net2272.c       |  4 ---
 drivers/usb/gadget/udc/pch_udc.c       | 54 +++++++++++++++-------------------
 drivers/usb/gadget/udc/pxa27x_udc.c    |  3 --
 drivers/usb/gadget/udc/r8a66597-udc.c  | 24 ++++-----------
 drivers/usb/gadget/udc/udc-xilinx.c    |  3 --
 15 files changed, 50 insertions(+), 136 deletions(-)

-- 
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»

[toc] | [next] | [standalone]

#1405299 — [PATCH 2/4] usb: gadget: m66592: fix unused-but-set-variable warnings

This patch fixes the following (W=1) warnings:

drivers/usb/gadget/udc/m66592-udc.c: In function ‘m66592_irq’:
drivers/usb/gadget/udc/m66592-udc.c:1203:15: warning: variable ‘nrdyenb’ set but not used [-Wunused-but-set-variable]
  u16 brdyenb, nrdyenb, bempenb;
               ^
drivers/usb/gadget/udc/m66592-udc.c:1202:15: warning: variable ‘nrdysts’ set but not used [-Wunused-but-set-variable]
  u16 brdysts, nrdysts, bempsts;
               ^

In doing so, it removes calls to m66592_read function which does I/O
with the device, but I hope the reads don’t have any side effects that
are needed.

Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Cc: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>
---
 drivers/usb/gadget/udc/m66592-udc.c | 24 ++++++------------------
 1 file changed, 6 insertions(+), 18 deletions(-)

diff --git a/drivers/usb/gadget/udc/m66592-udc.c b/drivers/usb/gadget/udc/m66592-udc.c
index b1cfa96..6e977dc 100644
--- a/drivers/usb/gadget/udc/m66592-udc.c
+++ b/drivers/usb/gadget/udc/m66592-udc.c
@@ -1199,8 +1199,6 @@ static irqreturn_t m66592_irq(int irq, void *_m66592)
 	struct m66592 *m66592 = _m66592;
 	u16 intsts0;
 	u16 intenb0;
-	u16 brdysts, nrdysts, bempsts;
-	u16 brdyenb, nrdyenb, bempenb;
 	u16 savepipe;
 	u16 mask0;
 
@@ -1224,12 +1222,10 @@ static irqreturn_t m66592_irq(int irq, void *_m66592)
 
 	mask0 = intsts0 & intenb0;
 	if (mask0) {
-		brdysts = m66592_read(m66592, M66592_BRDYSTS);
-		nrdysts = m66592_read(m66592, M66592_NRDYSTS);
-		bempsts = m66592_read(m66592, M66592_BEMPSTS);
-		brdyenb = m66592_read(m66592, M66592_BRDYENB);
-		nrdyenb = m66592_read(m66592, M66592_NRDYENB);
-		bempenb = m66592_read(m66592, M66592_BEMPENB);
+		u16 brdysts = m66592_read(m66592, M66592_BRDYSTS);
+		u16 bempsts = m66592_read(m66592, M66592_BEMPSTS);
+		u16 brdyenb = m66592_read(m66592, M66592_BRDYENB);
+		u16 bempenb = m66592_read(m66592, M66592_BEMPENB);
 
 		if (mask0 & M66592_VBINT) {
 			m66592_write(m66592,  0xffff & ~M66592_VBINT,
@@ -1408,28 +1404,20 @@ static int m66592_dequeue(struct usb_ep *_ep, struct usb_request *_req)
 
 static int m66592_set_halt(struct usb_ep *_ep, int value)
 {
-	struct m66592_ep *ep;
-	struct m66592_request *req;
+	struct m66592_ep *ep = container_of(_ep, struct m66592_ep, ep);
 	unsigned long flags;
 	int ret = 0;
 
-	ep = container_of(_ep, struct m66592_ep, ep);
-	req = list_entry(ep->queue.next, struct m66592_request, queue);
-
 	spin_lock_irqsave(&ep->m66592->lock, flags);
 	if (!list_empty(&ep->queue)) {
 		ret = -EAGAIN;
-		goto out;
-	}
-	if (value) {
+	} else if (value) {
 		ep->busy = 1;
 		pipe_stall(ep->m66592, ep->pipenum);
 	} else {
 		ep->busy = 0;
 		pipe_stop(ep->m66592, ep->pipenum);
 	}
-
-out:
 	spin_unlock_irqrestore(&ep->m66592->lock, flags);
 	return ret;
 }
-- 
2.8.0.rc3.226.g39d4020

[toc] | [prev] | [next] | [standalone]

#1409923

[Multipart message — attachments visible in raw view] — view raw

Hi,

Michal Nazarewicz <mina86@mina86.com> writes:
> Fixes all of the unused-but-set-variable warnings enabled when
> building with W=1.  As described in the first patch, some warnings are
> left off.  See said patch for more description.
>
> Michal Nazarewicz (4):
>   usb: gadget: fix unused-but-set-variale warnings
>   usb: gadget: m66592: fix unused-but-set-variable warnings
>   usb: gadget: r8a66597: fix unused-but-set-variable warnings
>   usb: gadget: mv_u3d: fix unused-but-set-variable warnings

This series doesn't seem to apply to v4.7-rc1. Care to rebase on
testing/fixes?

-- 
balbi

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web