Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1405011 > unrolled thread
| Started by | Clifton Barnes <clifton.a.barnes@gmail.com> |
|---|---|
| First post | 2016-05-22 16:30 +0200 |
| Last post | 2016-05-24 01:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] Input: tc3589x-keypad - remove stray ')' Clifton Barnes <clifton.a.barnes@gmail.com> - 2016-05-22 16:30 +0200
Re: [PATCH] Input: tc3589x-keypad - remove stray ')' Linus Walleij <linus.walleij@linaro.org> - 2016-05-23 15:30 +0200
Re: [PATCH] Input: tc3589x-keypad - remove stray ')' Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-05-24 01:00 +0200
| From | Clifton Barnes <clifton.a.barnes@gmail.com> |
|---|---|
| Date | 2016-05-22 16:30 +0200 |
| Subject | [PATCH] Input: tc3589x-keypad - remove stray ')' |
| Message-ID | <rBCye-1Q3-13@gated-at.bofh.it> |
The end ')' needs to be removed if the macro is ever used or there
would be a compiler error as it does not have a matching '('.
Signed-off-by: Clifton Barnes <clifton.a.barnes@gmail.com>
---
drivers/input/keyboard/tc3589x-keypad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/tc3589x-keypad.c b/drivers/input/keyboard/tc3589x-keypad.c
index e92dfd8..ec0070e 100644
--- a/drivers/input/keyboard/tc3589x-keypad.c
+++ b/drivers/input/keyboard/tc3589x-keypad.c
@@ -32,7 +32,7 @@
#define TC3589x_PULL_DOWN_MASK 0x1
#define TC3589x_PULL_UP_MASK 0x2
#define TC3589x_PULLUP_ALL_MASK 0xAA
-#define TC3589x_IO_PULL_VAL(index, mask) ((mask)<<((index)%4)*2))
+#define TC3589x_IO_PULL_VAL(index, mask) ((mask)<<((index)%4)*2)
/* Bit masks for IOCFG register */
#define IOCFG_BALLCFG 0x01
--
1.9.1
[toc] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2016-05-23 15:30 +0200 |
| Message-ID | <rBY5I-6pa-21@gated-at.bofh.it> |
| In reply to | #1405011 |
On Sun, May 22, 2016 at 4:20 PM, Clifton Barnes
<clifton.a.barnes@gmail.com> wrote:
> The end ')' needs to be removed if the macro is ever used or there
> would be a compiler error as it does not have a matching '('.
>
> Signed-off-by: Clifton Barnes <clifton.a.barnes@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
[toc] | [prev] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2016-05-24 01:00 +0200 |
| Message-ID | <rC6Zj-3q1-7@gated-at.bofh.it> |
| In reply to | #1405368 |
On Mon, May 23, 2016 at 03:26:56PM +0200, Linus Walleij wrote:
> On Sun, May 22, 2016 at 4:20 PM, Clifton Barnes
> <clifton.a.barnes@gmail.com> wrote:
>
> > The end ')' needs to be removed if the macro is ever used or there
> > would be a compiler error as it does not have a matching '('.
> >
> > Signed-off-by: Clifton Barnes <clifton.a.barnes@gmail.com>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Applied, thank you.
--
Dmitry
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web