Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1403040 > unrolled thread
| Started by | Caesar Wang <wxt@rock-chips.com> |
|---|---|
| First post | 2016-05-18 16:50 +0200 |
| Last post | 2016-05-20 23:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] arm64: dts: rockchip: fixes the gic400 2nd region size for rk3368 Caesar Wang <wxt@rock-chips.com> - 2016-05-18 16:50 +0200
Re: [PATCH] arm64: dts: rockchip: fixes the gic400 2nd region size for rk3368 Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-20 15:00 +0200
Re: [PATCH] arm64: dts: rockchip: fixes the gic400 2nd region size for rk3368 Heiko Stuebner <heiko@sntech.de> - 2016-05-20 23:30 +0200
| From | Caesar Wang <wxt@rock-chips.com> |
|---|---|
| Date | 2016-05-18 16:50 +0200 |
| Subject | [PATCH] arm64: dts: rockchip: fixes the gic400 2nd region size for rk3368 |
| Message-ID | <rAaXn-3oK-3@gated-at.bofh.it> |
The 2nd additional region is the GIC virtual cpu interface register base and size. As the gic400 of rk3368 says, the cpu interface register map as below : -0x0000 GICC_CTRL . . . -0x00fc GICC_IIDR -0x1000 GICC_IDR Obviously, the region size should be greater than 0x1000. So we should make sure to include the GICC_IDR since the kernel will access it in some cases. Signed-off-by: Caesar Wang <wxt@rock-chips.com> Cc: Heiko Stuebner <heiko@sntech.de> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-rockchip@lists.infradead.org --- arch/arm64/boot/dts/rockchip/rk3368.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi index 8b4a7c9..080203e 100644 --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi @@ -670,7 +670,7 @@ #address-cells = <0>; reg = <0x0 0xffb71000 0x0 0x1000>, - <0x0 0xffb72000 0x0 0x1000>, + <0x0 0xffb72000 0x0 0x2000>, <0x0 0xffb74000 0x0 0x2000>, <0x0 0xffb76000 0x0 0x2000>; interrupts = <GIC_PPI 9 -- 2.7.4
[toc] | [next] | [standalone]
| From | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| Date | 2016-05-20 15:00 +0200 |
| Subject | Re: [PATCH] arm64: dts: rockchip: fixes the gic400 2nd region size for rk3368 |
| Message-ID | <rASc2-5AE-33@gated-at.bofh.it> |
| In reply to | #1403040 |
在 2016/5/18 22:41, Caesar Wang 写道: > The 2nd additional region is the GIC virtual cpu interface register > base and size. > > As the gic400 of rk3368 says, the cpu interface register map as below > > : > > -0x0000 GICC_CTRL > . > . > . > -0x00fc GICC_IIDR > -0x1000 GICC_IDR > > Obviously, the region size should be greater than 0x1000. > So we should make sure to include the GICC_IDR since the kernel will access > it in some cases. > yes, address range for GICC_* should be from 0x2000 to 0x3fff according to gic400 memory map Table 3-1. Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com> > Signed-off-by: Caesar Wang <wxt@rock-chips.com> > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org > > --- > > arch/arm64/boot/dts/rockchip/rk3368.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi > index 8b4a7c9..080203e 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi > @@ -670,7 +670,7 @@ > #address-cells = <0>; > > reg = <0x0 0xffb71000 0x0 0x1000>, > - <0x0 0xffb72000 0x0 0x1000>, > + <0x0 0xffb72000 0x0 0x2000>, > <0x0 0xffb74000 0x0 0x2000>, > <0x0 0xffb76000 0x0 0x2000>; > interrupts = <GIC_PPI 9 > -- Best Regards Shawn Lin
[toc] | [prev] | [next] | [standalone]
| From | Heiko Stuebner <heiko@sntech.de> |
|---|---|
| Date | 2016-05-20 23:30 +0200 |
| Message-ID | <rB09A-2IX-13@gated-at.bofh.it> |
| In reply to | #1403040 |
Hi Caesar, Am Mittwoch, 18. Mai 2016, 22:41:50 schrieb Caesar Wang: > The 2nd additional region is the GIC virtual cpu interface register > base and size. > > As the gic400 of rk3368 says, the cpu interface register map as below > > > > -0x0000 GICC_CTRL > . > . > . > -0x00fc GICC_IIDR > -0x1000 GICC_IDR > > Obviously, the region size should be greater than 0x1000. > So we should make sure to include the GICC_IDR since the kernel will > access it in some cases. > > Signed-off-by: Caesar Wang <wxt@rock-chips.com> > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org applied to a fixes branch for 4.7 with Shawn's review-tag. Thanks for catching this Heiko
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web