Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1402107 > unrolled thread

[PATCH 01/11] clk: microchip: use readl_poll_timeout() in pbclk_set_rate().

Started byPurna Chandra Mandal <purna.mandal@microchip.com>
First post2016-05-17 07:10 +0200
Last post2016-05-18 19:00 +0200
Articles 11 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 01/11] clk: microchip: use readl_poll_timeout() in pbclk_set_rate(). Purna Chandra Mandal <purna.mandal@microchip.com> - 2016-05-17 07:10 +0200
    [PATCH 02/11] clk: microchip: Initialize SOSC clock rate for PIC32MZDA. Purna Chandra Mandal <purna.mandal@microchip.com> - 2016-05-17 07:10 +0200
    [PATCH 10/11] dt/bindings: Correct clk binding example for PIC32 WDT. Purna Chandra Mandal <purna.mandal@microchip.com> - 2016-05-17 07:20 +0200
      Re: [PATCH 10/11] dt/bindings: Correct clk binding example for PIC32  WDT. Rob Herring <robh@kernel.org> - 2016-05-18 19:00 +0200
    [PATCH 11/11] dt/bindings: Correct clk binding example for PIC32 gpio. Purna Chandra Mandal <purna.mandal@microchip.com> - 2016-05-17 07:20 +0200
      Re: [PATCH 11/11] dt/bindings: Correct clk binding example for PIC32  gpio. Rob Herring <robh@kernel.org> - 2016-05-18 19:00 +0200
      Re: [PATCH 11/11] dt/bindings: Correct clk binding example for PIC32 gpio. Linus Walleij <linus.walleij@linaro.org> - 2016-05-26 10:40 +0200
    [PATCH 09/11] dt/bindings: Correct clk binding example for PIC32 DMT. Purna Chandra Mandal <purna.mandal@microchip.com> - 2016-05-17 07:20 +0200
      Re: [PATCH 09/11] dt/bindings: Correct clk binding example for PIC32  DMT. Rob Herring <robh@kernel.org> - 2016-05-18 19:00 +0200
    [PATCH 08/11] dt/bindings: Correct clk binding example for PIC32 serial. Purna Chandra Mandal <purna.mandal@microchip.com> - 2016-05-17 07:20 +0200
      Re: [PATCH 08/11] dt/bindings: Correct clk binding example for PIC32  serial. Rob Herring <robh@kernel.org> - 2016-05-18 19:00 +0200

#1402107 — [PATCH 01/11] clk: microchip: use readl_poll_timeout() in pbclk_set_rate().

FromPurna Chandra Mandal <purna.mandal@microchip.com>
Date2016-05-17 07:10 +0200
Subject[PATCH 01/11] clk: microchip: use readl_poll_timeout() in pbclk_set_rate().
Message-ID<rzFqx-fn-3@gated-at.bofh.it>
pbclk_set_rate() is using readl_poll_timeout_atomic() even
though spinlock is released. Fix it by replacing with
readl_poll_timeout().

Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
---
Note: Please pull this complete series through the MIPS tree.

---

 drivers/clk/microchip/clk-core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/microchip/clk-core.c b/drivers/clk/microchip/clk-core.c
index ca85cea..c3b3014 100644
--- a/drivers/clk/microchip/clk-core.c
+++ b/drivers/clk/microchip/clk-core.c
@@ -199,9 +199,9 @@ static int pbclk_set_rate(struct clk_hw *hw, unsigned long rate,
 
 	spin_unlock_irqrestore(&pb->core->reg_lock, flags);
 
-	/* wait again, for pbdivready */
-	err = readl_poll_timeout_atomic(pb->ctrl_reg, v, v & PB_DIV_READY,
-					1, LOCK_TIMEOUT_US);
+	/* wait again for DIV_READY */
+	err = readl_poll_timeout(pb->ctrl_reg, v, v & PB_DIV_READY,
+				 1, LOCK_TIMEOUT_US);
 	if (err)
 		return err;
 
-- 
1.8.3.1

[toc] | [next] | [standalone]

#1402108 — [PATCH 02/11] clk: microchip: Initialize SOSC clock rate for PIC32MZDA.

FromPurna Chandra Mandal <purna.mandal@microchip.com>
Date2016-05-17 07:10 +0200
Subject[PATCH 02/11] clk: microchip: Initialize SOSC clock rate for PIC32MZDA.
Message-ID<rzFqy-fn-23@gated-at.bofh.it>
In reply to#1402107
Optional SOSC is an external fixed clock running at 32768HZ.
So Initialize SOSC rate as per PIC32MZDA datasheet.

Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>

---
Note: Please pull this complete series through the MIPS tree.

---

 drivers/clk/microchip/clk-pic32mzda.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/microchip/clk-pic32mzda.c b/drivers/clk/microchip/clk-pic32mzda.c
index 020a29a..210694b 100644
--- a/drivers/clk/microchip/clk-pic32mzda.c
+++ b/drivers/clk/microchip/clk-pic32mzda.c
@@ -118,6 +118,7 @@ static const struct pic32_sec_osc_data sosc_clk = {
 	.status_reg = 0x1d0,
 	.enable_mask = BIT(1),
 	.status_mask = BIT(4),
+	.fixed_rate = 32768,
 	.init_data = {
 		.name = "sosc_clk",
 		.parent_names = NULL,
-- 
1.8.3.1

[toc] | [prev] | [next] | [standalone]

#1402112 — [PATCH 10/11] dt/bindings: Correct clk binding example for PIC32 WDT.

FromPurna Chandra Mandal <purna.mandal@microchip.com>
Date2016-05-17 07:20 +0200
Subject[PATCH 10/11] dt/bindings: Correct clk binding example for PIC32 WDT.
Message-ID<rzFAe-iS-5@gated-at.bofh.it>
In reply to#1402107
Update binding example based on new clock binding scheme.
[1] Documentation/devicetree/bindings/clock/microchip,pic32.txt

Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
---

 Documentation/devicetree/bindings/watchdog/microchip,pic32-wdt.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/watchdog/microchip,pic32-wdt.txt b/Documentation/devicetree/bindings/watchdog/microchip,pic32-wdt.txt
index d140103..f03a29a 100644
--- a/Documentation/devicetree/bindings/watchdog/microchip,pic32-wdt.txt
+++ b/Documentation/devicetree/bindings/watchdog/microchip,pic32-wdt.txt
@@ -7,12 +7,12 @@ Required properties:
 - compatible: must be "microchip,pic32mzda-wdt".
 - reg: physical base address of the controller and length of memory mapped
   region.
-- clocks: phandle of source clk. should be <&LPRC> clk.
+- clocks: phandle of source clk. Should be <&rootclk LPRCCLK>.
 
 Example:
 
 	watchdog@1f800800 {
 		compatible = "microchip,pic32mzda-wdt";
 		reg = <0x1f800800 0x200>;
-		clocks = <&LPRC>;
+		clocks = <&rootclk LPRCCLK>;
 	};
-- 
1.8.3.1

[toc] | [prev] | [next] | [standalone]

#1403150 — Re: [PATCH 10/11] dt/bindings: Correct clk binding example for PIC32 WDT.

FromRob Herring <robh@kernel.org>
Date2016-05-18 19:00 +0200
SubjectRe: [PATCH 10/11] dt/bindings: Correct clk binding example for PIC32 WDT.
Message-ID<rAcZb-4DW-13@gated-at.bofh.it>
In reply to#1402112
On Tue, May 17, 2016 at 10:35:59AM +0530, Purna Chandra Mandal wrote:
> Update binding example based on new clock binding scheme.
> [1] Documentation/devicetree/bindings/clock/microchip,pic32.txt
> 
> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
> ---
> 
>  Documentation/devicetree/bindings/watchdog/microchip,pic32-wdt.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>

[toc] | [prev] | [next] | [standalone]

#1402113 — [PATCH 11/11] dt/bindings: Correct clk binding example for PIC32 gpio.

FromPurna Chandra Mandal <purna.mandal@microchip.com>
Date2016-05-17 07:20 +0200
Subject[PATCH 11/11] dt/bindings: Correct clk binding example for PIC32 gpio.
Message-ID<rzFAe-iS-11@gated-at.bofh.it>
In reply to#1402107
Update binding example based on new clock binding scheme.
[1] Documentation/devicetree/bindings/clock/microchip,pic32.txt

Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
---

 Documentation/devicetree/bindings/gpio/microchip,pic32-gpio.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/gpio/microchip,pic32-gpio.txt b/Documentation/devicetree/bindings/gpio/microchip,pic32-gpio.txt
index ef37528..dd031fc 100644
--- a/Documentation/devicetree/bindings/gpio/microchip,pic32-gpio.txt
+++ b/Documentation/devicetree/bindings/gpio/microchip,pic32-gpio.txt
@@ -33,7 +33,7 @@ gpio0: gpio0@1f860000 {
 	gpio-controller;
 	interrupt-controller;
 	#interrupt-cells = <2>;
-	clocks = <&PBCLK4>;
+	clocks = <&rootclk PB4CLK>;
 	microchip,gpio-bank = <0>;
 	gpio-ranges = <&pic32_pinctrl 0 0 16>;
 };
-- 
1.8.3.1

[toc] | [prev] | [next] | [standalone]

#1403149 — Re: [PATCH 11/11] dt/bindings: Correct clk binding example for PIC32 gpio.

FromRob Herring <robh@kernel.org>
Date2016-05-18 19:00 +0200
SubjectRe: [PATCH 11/11] dt/bindings: Correct clk binding example for PIC32 gpio.
Message-ID<rAcZb-4DW-1@gated-at.bofh.it>
In reply to#1402113
On Tue, May 17, 2016 at 10:36:00AM +0530, Purna Chandra Mandal wrote:
> Update binding example based on new clock binding scheme.
> [1] Documentation/devicetree/bindings/clock/microchip,pic32.txt
> 
> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
> ---
> 
>  Documentation/devicetree/bindings/gpio/microchip,pic32-gpio.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Rob Herring <robh@kernel.org>

[toc] | [prev] | [next] | [standalone]

#1407458 — Re: [PATCH 11/11] dt/bindings: Correct clk binding example for PIC32 gpio.

FromLinus Walleij <linus.walleij@linaro.org>
Date2016-05-26 10:40 +0200
SubjectRe: [PATCH 11/11] dt/bindings: Correct clk binding example for PIC32 gpio.
Message-ID<rCYZI-45r-31@gated-at.bofh.it>
In reply to#1402113
On Tue, May 17, 2016 at 7:06 AM, Purna Chandra Mandal
<purna.mandal@microchip.com> wrote:

> Update binding example based on new clock binding scheme.
> [1] Documentation/devicetree/bindings/clock/microchip,pic32.txt
>
> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>

Patch applied and squashed into the other pic32 patch
with Rob's ACK.

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]

#1402116 — [PATCH 09/11] dt/bindings: Correct clk binding example for PIC32 DMT.

FromPurna Chandra Mandal <purna.mandal@microchip.com>
Date2016-05-17 07:20 +0200
Subject[PATCH 09/11] dt/bindings: Correct clk binding example for PIC32 DMT.
Message-ID<rzFAe-iS-15@gated-at.bofh.it>
In reply to#1402107
Update binding example based on new clock binding scheme.
[1] Documentation/devicetree/bindings/clock/microchip,pic32.txt

Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
---

 Documentation/devicetree/bindings/watchdog/microchip,pic32-dmt.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/watchdog/microchip,pic32-dmt.txt b/Documentation/devicetree/bindings/watchdog/microchip,pic32-dmt.txt
index 852f694..49485f8 100644
--- a/Documentation/devicetree/bindings/watchdog/microchip,pic32-dmt.txt
+++ b/Documentation/devicetree/bindings/watchdog/microchip,pic32-dmt.txt
@@ -8,12 +8,12 @@ Required properties:
 - compatible: must be "microchip,pic32mzda-dmt".
 - reg: physical base address of the controller and length of memory mapped
   region.
-- clocks: phandle of parent clock (should be &PBCLK7).
+- clocks: phandle of source clk. Should be <&rootclk PB7CLK>.
 
 Example:
 
 	watchdog@1f800a00 {
 		compatible = "microchip,pic32mzda-dmt";
 		reg = <0x1f800a00 0x80>;
-		clocks = <&PBCLK7>;
+		clocks = <&rootclk PB7CLK>;
 	};
-- 
1.8.3.1

[toc] | [prev] | [next] | [standalone]

#1403156 — Re: [PATCH 09/11] dt/bindings: Correct clk binding example for PIC32 DMT.

FromRob Herring <robh@kernel.org>
Date2016-05-18 19:00 +0200
SubjectRe: [PATCH 09/11] dt/bindings: Correct clk binding example for PIC32 DMT.
Message-ID<rAcZc-4DW-33@gated-at.bofh.it>
In reply to#1402116
On Tue, May 17, 2016 at 10:35:58AM +0530, Purna Chandra Mandal wrote:
> Update binding example based on new clock binding scheme.
> [1] Documentation/devicetree/bindings/clock/microchip,pic32.txt
> 
> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
> ---
> 
>  Documentation/devicetree/bindings/watchdog/microchip,pic32-dmt.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>

[toc] | [prev] | [next] | [standalone]

#1402117 — [PATCH 08/11] dt/bindings: Correct clk binding example for PIC32 serial.

FromPurna Chandra Mandal <purna.mandal@microchip.com>
Date2016-05-17 07:20 +0200
Subject[PATCH 08/11] dt/bindings: Correct clk binding example for PIC32 serial.
Message-ID<rzFAe-iS-21@gated-at.bofh.it>
In reply to#1402107
Update binding example based on new clock binding scheme.
[1] Documentation/devicetree/bindings/clock/microchip,pic32.txt

Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
---

 Documentation/devicetree/bindings/serial/microchip,pic32-uart.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/serial/microchip,pic32-uart.txt b/Documentation/devicetree/bindings/serial/microchip,pic32-uart.txt
index 65b38bf..7a34345 100644
--- a/Documentation/devicetree/bindings/serial/microchip,pic32-uart.txt
+++ b/Documentation/devicetree/bindings/serial/microchip,pic32-uart.txt
@@ -20,7 +20,7 @@ Example:
 		interrupts = <112 IRQ_TYPE_LEVEL_HIGH>,
 			<113 IRQ_TYPE_LEVEL_HIGH>,
 			<114 IRQ_TYPE_LEVEL_HIGH>;
-		clocks = <&PBCLK2>;
+		clocks = <&rootclk PB2CLK>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_uart1
 				&pinctrl_uart1_cts
-- 
1.8.3.1

[toc] | [prev] | [next] | [standalone]

#1403153 — Re: [PATCH 08/11] dt/bindings: Correct clk binding example for PIC32 serial.

FromRob Herring <robh@kernel.org>
Date2016-05-18 19:00 +0200
SubjectRe: [PATCH 08/11] dt/bindings: Correct clk binding example for PIC32 serial.
Message-ID<rAcZb-4DW-7@gated-at.bofh.it>
In reply to#1402117
On Tue, May 17, 2016 at 10:35:57AM +0530, Purna Chandra Mandal wrote:
> Update binding example based on new clock binding scheme.
> [1] Documentation/devicetree/bindings/clock/microchip,pic32.txt
> 
> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
> ---
> 
>  Documentation/devicetree/bindings/serial/microchip,pic32-uart.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Rob Herring <robh@kernel.org>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web