Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1401770 > unrolled thread

[PATCH 1/2 V3] dt: add Atmel Captouch bindings

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2 V3] dt: add Atmel Captouch bindings Grant Grundler <grundler@chromium.org> - 2016-05-16 23:00 +0200
    Re: [PATCH 1/2 V3] dt: add Atmel Captouch bindings Rob Herring <robh@kernel.org> - 2016-05-18 18:50 +0200
      Re: [PATCH 1/2 V3] dt: add Atmel Captouch bindings Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-05-19 00:00 +0200
        Re: [PATCH 1/2 V3] dt: add Atmel Captouch bindings Grant Grundler <grundler@chromium.org> - 2016-05-19 00:30 +0200
        Re: [PATCH 1/2 V3] dt: add Atmel Captouch bindings Rob Herring <robh@kernel.org> - 2016-05-20 15:00 +0200
          Re: [PATCH 1/2 V3] dt: add Atmel Captouch bindings Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-05-20 18:20 +0200
            Re: [PATCH 1/2 V3] dt: add Atmel Captouch bindings Rob Herring <robh@kernel.org> - 2016-05-21 00:20 +0200
              Re: [PATCH 1/2 V3] dt: add Atmel Captouch bindings Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-05-21 00:30 +0200

#1401770 — [PATCH 1/2 V3] dt: add Atmel Captouch bindings

From: Daniel Hung-yu Wu <hywu@google.com>

Add binding for Atmel Capacitive Touch Button device.

Signed-off-by: Daniel Hung-yu Wu <hywu@google.com>
Signed-off-by: Grant Grundler <grundler@chromium.org>
---
 .../devicetree/bindings/input/atmel,captouch.txt   | 36 ++++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/atmel,captouch.txt

V3: doh! use dash, not underscore in node names. Wordsmith description.

V2: split Documentation/devicetree/bindings from driver patch
    rename "atmel,atmegaxx_captouch" to "atmel,captouch" since it's irrelevant
           which controller implements the register set/controller.

V1: posted https://lkml.org/lkml/2016/5/3/613

diff --git a/Documentation/devicetree/bindings/input/atmel,captouch.txt b/Documentation/devicetree/bindings/input/atmel,captouch.txt
new file mode 100644
index 0000000..405d287
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/atmel,captouch.txt
@@ -0,0 +1,36 @@
+Device tree bindings for Atmel capacitive touch device, typically
+an Atmel touch sensor connected to AtmegaXX MCU running firmware
+based on Qtouch library.
+
+The node for this device must be a child of a I2C controller node, as the
+device communicates via I2C.
+
+Required properties:
+
+	compatible:	Must be "atmel,captouch".
+	reg:		The I2C slave address of the device.
+	interrupts:	Property describing the interrupt line the device
+			is connected to. The device only has one interrupt
+			source.
+	linux,keycodes:	Specifies an array of numeric keycode values to
+			be used for reporting button presses. The array can
+			contain up to 8 entries.
+
+Optional properties:
+
+	autorepeat:	Enables the Linux input system's autorepeat
+			feature on the input device.
+
+Example:
+
+	atmel-captouch@51 {
+		compatible = "atmel,captouch";
+		reg = <0x51>;
+		interrupt-parent = <&tlmm>;
+		interrupts = <67 IRQ_TYPE_EDGE_FALLING>;
+		linux,keycodes = <BTN_0>, <BTN_1>,
+			<BTN_2>, <BTN_3>,
+			<BTN_4>, <BTN_5>,
+			<BTN_6>, <BTN_7>;
+		autorepeat;
+	};
-- 
2.1.2

[toc] | [next] | [standalone]

#1403145

On Mon, May 16, 2016 at 01:54:53PM -0700, Grant Grundler wrote:
> From: Daniel Hung-yu Wu <hywu@google.com>
> 
> Add binding for Atmel Capacitive Touch Button device.
> 
> Signed-off-by: Daniel Hung-yu Wu <hywu@google.com>
> Signed-off-by: Grant Grundler <grundler@chromium.org>
> ---
>  .../devicetree/bindings/input/atmel,captouch.txt   | 36 ++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/atmel,captouch.txt

Acked-by: Rob Herring <robh@kernel.org>

[toc] | [prev] | [next] | [standalone]

#1403317

On Wed, May 18, 2016 at 11:44:04AM -0500, Rob Herring wrote:
> On Mon, May 16, 2016 at 01:54:53PM -0700, Grant Grundler wrote:
> > From: Daniel Hung-yu Wu <hywu@google.com>
> > 
> > Add binding for Atmel Capacitive Touch Button device.
> > 
> > Signed-off-by: Daniel Hung-yu Wu <hywu@google.com>
> > Signed-off-by: Grant Grundler <grundler@chromium.org>
> > ---
> >  .../devicetree/bindings/input/atmel,captouch.txt   | 36 ++++++++++++++++++++++
> >  1 file changed, 34 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/input/atmel,captouch.txt
> 
> Acked-by: Rob Herring <robh@kernel.org>

Folded into the driver patch and applied.

Thanks.

-- 
Dmitry

[toc] | [prev] | [next] | [standalone]

#1403326

On Wed, May 18, 2016 at 2:59 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Wed, May 18, 2016 at 11:44:04AM -0500, Rob Herring wrote:
>> On Mon, May 16, 2016 at 01:54:53PM -0700, Grant Grundler wrote:
>> > From: Daniel Hung-yu Wu <hywu@google.com>
>> >
>> > Add binding for Atmel Capacitive Touch Button device.
>> >
>> > Signed-off-by: Daniel Hung-yu Wu <hywu@google.com>
>> > Signed-off-by: Grant Grundler <grundler@chromium.org>
>> > ---
>> >  .../devicetree/bindings/input/atmel,captouch.txt   | 36 ++++++++++++++++++++++
>> >  1 file changed, 34 insertions(+)
>> >  create mode 100644 Documentation/devicetree/bindings/input/atmel,captouch.txt
>>
>> Acked-by: Rob Herring <robh@kernel.org>
>
> Folded into the driver patch and applied.
>
> Thanks.

Thanks Rob! Thanks Dmitry! :)

grant

>
> --
> Dmitry

[toc] | [prev] | [next] | [standalone]

#1404406

On Wed, May 18, 2016 at 4:59 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Wed, May 18, 2016 at 11:44:04AM -0500, Rob Herring wrote:
>> On Mon, May 16, 2016 at 01:54:53PM -0700, Grant Grundler wrote:
>> > From: Daniel Hung-yu Wu <hywu@google.com>
>> >
>> > Add binding for Atmel Capacitive Touch Button device.
>> >
>> > Signed-off-by: Daniel Hung-yu Wu <hywu@google.com>
>> > Signed-off-by: Grant Grundler <grundler@chromium.org>
>> > ---
>> >  .../devicetree/bindings/input/atmel,captouch.txt   | 36 ++++++++++++++++++++++
>> >  1 file changed, 34 insertions(+)
>> >  create mode 100644 Documentation/devicetree/bindings/input/atmel,captouch.txt
>>
>> Acked-by: Rob Herring <robh@kernel.org>
>
> Folded into the driver patch and applied.

Folded why? Please don't do that. You should be committing what is
posted as is for the most part. We specifically ask that binding
changes are kept separate commits. It also messes up the ability to
correlate git commits to patchworks or mail searches.

Rob

[toc] | [prev] | [next] | [standalone]

#1404574

On Fri, May 20, 2016 at 07:56:51AM -0500, Rob Herring wrote:
> On Wed, May 18, 2016 at 4:59 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > On Wed, May 18, 2016 at 11:44:04AM -0500, Rob Herring wrote:
> >> On Mon, May 16, 2016 at 01:54:53PM -0700, Grant Grundler wrote:
> >> > From: Daniel Hung-yu Wu <hywu@google.com>
> >> >
> >> > Add binding for Atmel Capacitive Touch Button device.
> >> >
> >> > Signed-off-by: Daniel Hung-yu Wu <hywu@google.com>
> >> > Signed-off-by: Grant Grundler <grundler@chromium.org>
> >> > ---
> >> >  .../devicetree/bindings/input/atmel,captouch.txt   | 36 ++++++++++++++++++++++
> >> >  1 file changed, 34 insertions(+)
> >> >  create mode 100644 Documentation/devicetree/bindings/input/atmel,captouch.txt
> >>
> >> Acked-by: Rob Herring <robh@kernel.org>
> >
> > Folded into the driver patch and applied.
> 
> Folded why? Please don't do that. You should be committing what is
> posted as is for the most part. We specifically ask that binding
> changes are kept separate commits. It also messes up the ability to

I know that you ask for binding docs to be posted separately (I guess
so that devicetree list is not overrun with driver code mails), but
logically driver patch and binding doc patch are a single change and
should be committed together, so that when I am researching the history
I can easily see what was introduced and when. You do not require header
changes to be submitted separately form .c files, do you?

> correlate git commits to patchworks or mail searches.

The fact that it was applied can be found in mail archives.

Thanks.

-- 
Dmitry

[toc] | [prev] | [next] | [standalone]

#1404746

On Fri, May 20, 2016 at 11:16 AM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Fri, May 20, 2016 at 07:56:51AM -0500, Rob Herring wrote:
>> On Wed, May 18, 2016 at 4:59 PM, Dmitry Torokhov
>> <dmitry.torokhov@gmail.com> wrote:
>> > On Wed, May 18, 2016 at 11:44:04AM -0500, Rob Herring wrote:
>> >> On Mon, May 16, 2016 at 01:54:53PM -0700, Grant Grundler wrote:
>> >> > From: Daniel Hung-yu Wu <hywu@google.com>
>> >> >
>> >> > Add binding for Atmel Capacitive Touch Button device.
>> >> >
>> >> > Signed-off-by: Daniel Hung-yu Wu <hywu@google.com>
>> >> > Signed-off-by: Grant Grundler <grundler@chromium.org>
>> >> > ---
>> >> >  .../devicetree/bindings/input/atmel,captouch.txt   | 36 ++++++++++++++++++++++
>> >> >  1 file changed, 34 insertions(+)
>> >> >  create mode 100644 Documentation/devicetree/bindings/input/atmel,captouch.txt
>> >>
>> >> Acked-by: Rob Herring <robh@kernel.org>
>> >
>> > Folded into the driver patch and applied.
>>
>> Folded why? Please don't do that. You should be committing what is
>> posted as is for the most part. We specifically ask that binding
>> changes are kept separate commits. It also messes up the ability to
>
> I know that you ask for binding docs to be posted separately (I guess
> so that devicetree list is not overrun with driver code mails),

And because we're really only reviewing the binding, so putting my ack
on the driver is not really correct.

> but
> logically driver patch and binding doc patch are a single change and
> should be committed together, so that when I am researching the history
> I can easily see what was introduced and when. You do not require header
> changes to be submitted separately form .c files, do you?

Yes, for include/dt-bindings we ask that they are part of the binding
doc, not the driver even though both use it. You can also certainly
have bindings without drivers though generally we require them. I
would not if they had a driver in BSD or u-boot for example.

You can already easily see when things are introduced because they
will be next to each other in the git history.

>> correlate git commits to patchworks or mail searches.
>
> The fact that it was applied can be found in mail archives.

Yes, with extra effort reading the history you can, but not with a
script. There's a patchwork script to add commit hashes to patchwork
which works all based on the subject.

Regardless of one commit or two, you simply shouldn't be changing what
you commit. Either commit what was posted or require the author to
combine things and repost. That's our job as patch monkeys.

Rob

[toc] | [prev] | [next] | [standalone]

#1404752

On Fri, May 20, 2016 at 05:12:55PM -0500, Rob Herring wrote:
> On Fri, May 20, 2016 at 11:16 AM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > On Fri, May 20, 2016 at 07:56:51AM -0500, Rob Herring wrote:
> >> On Wed, May 18, 2016 at 4:59 PM, Dmitry Torokhov
> >> <dmitry.torokhov@gmail.com> wrote:
> >> > On Wed, May 18, 2016 at 11:44:04AM -0500, Rob Herring wrote:
> >> >> On Mon, May 16, 2016 at 01:54:53PM -0700, Grant Grundler wrote:
> >> >> > From: Daniel Hung-yu Wu <hywu@google.com>
> >> >> >
> >> >> > Add binding for Atmel Capacitive Touch Button device.
> >> >> >
> >> >> > Signed-off-by: Daniel Hung-yu Wu <hywu@google.com>
> >> >> > Signed-off-by: Grant Grundler <grundler@chromium.org>
> >> >> > ---
> >> >> >  .../devicetree/bindings/input/atmel,captouch.txt   | 36 ++++++++++++++++++++++
> >> >> >  1 file changed, 34 insertions(+)
> >> >> >  create mode 100644 Documentation/devicetree/bindings/input/atmel,captouch.txt
> >> >>
> >> >> Acked-by: Rob Herring <robh@kernel.org>
> >> >
> >> > Folded into the driver patch and applied.
> >>
> >> Folded why? Please don't do that. You should be committing what is
> >> posted as is for the most part. We specifically ask that binding
> >> changes are kept separate commits. It also messes up the ability to
> >
> > I know that you ask for binding docs to be posted separately (I guess
> > so that devicetree list is not overrun with driver code mails),
> 
> And because we're really only reviewing the binding, so putting my ack
> on the driver is not really correct.

If you'd like I can annotate your Acks to state that they are for
bindings only when I fold everything together.

> 
> > but
> > logically driver patch and binding doc patch are a single change and
> > should be committed together, so that when I am researching the history
> > I can easily see what was introduced and when. You do not require header
> > changes to be submitted separately form .c files, do you?
> 
> Yes, for include/dt-bindings we ask that they are part of the binding
> doc, not the driver even though both use it. You can also certainly
> have bindings without drivers though generally we require them. I
> would not if they had a driver in BSD or u-boot for example.

Would they be in linux kernel sources then? I can see rules changed if
ever DTS/bindings are split from kernel, but while they are kept
together I do not see why we'd want to keep commits separate.

> 
> You can already easily see when things are introduced because they
> will be next to each other in the git history.
> 
> >> correlate git commits to patchworks or mail searches.
> >
> > The fact that it was applied can be found in mail archives.
> 
> Yes, with extra effort reading the history you can, but not with a
> script. There's a patchwork script to add commit hashes to patchwork
> which works all based on the subject.

If you'd like I can teach my scripts to update patches in your patchwork
instance when I do folds.

> 
> Regardless of one commit or two, you simply shouldn't be changing what
> you commit. Either commit what was posted or require the author to
> combine things and repost. That's our job as patch monkeys.

Or I do a bit of work on my end (i.e. add a few "depends on" that were
missed in case I notice them) and not ask for yet another respin.

Thanks.

-- 
Dmitry

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web