Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1404016 > unrolled thread

Re: [PATCH v4 0/6] Add alignment check for DAX mount

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v4 0/6] Add alignment check for DAX mount Eric Sandeen <sandeen@sandeen.net> - 2016-05-20 01:40 +0200
    Re: [PATCH v4 0/6] Add alignment check for DAX mount "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2016-05-20 17:30 +0200
      Re: [PATCH v4 0/6] Add alignment check for DAX mount "Verma, Vishal L" <vishal.l.verma@intel.com> - 2016-05-20 19:40 +0200
        Re: [PATCH v4 0/6] Add alignment check for DAX mount "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2016-05-20 20:00 +0200

#1404016 — Re: [PATCH v4 0/6] Add alignment check for DAX mount

On 5/10/16 11:23 AM, Toshi Kani wrote:
> When a partition is not aligned by 4KB, mount -o dax succeeds,

Sorry for being late, but -

Shouldn't this and all subsequent patch commits refer to
PAGE_SIZE, rather than "4kB?"

-Eric

[toc] | [next] | [standalone]

#1404540

On Thu, 2016-05-19 at 18:37 -0500, Eric Sandeen wrote:
> On 5/10/16 11:23 AM, Toshi Kani wrote:
> > 
> > When a partition is not aligned by 4KB, mount -o dax succeeds,
>
> Sorry for being late, but -
> 
> Shouldn't this and all subsequent patch commits refer to
> PAGE_SIZE, rather than "4kB?"

Right, the patch commits should refer to PAGE_SIZE to match with the code
changes.  I am afraid it may be a bit too late to update, though...

Vishal, do you think you can tweak the logs, "4KB" to "PAGE_SIZE"?

Thanks,
-Toshi

[toc] | [prev] | [next] | [standalone]

#1404637

On Fri, 2016-05-20 at 14:50 +0000, Kani, Toshimitsu wrote:
> On Thu, 2016-05-19 at 18:37 -0500, Eric Sandeen wrote:
> > 
> > On 5/10/16 11:23 AM, Toshi Kani wrote:
> > > 
> > > 
> > > When a partition is not aligned by 4KB, mount -o dax succeeds,
> > Sorry for being late, but -
> > 
> > Shouldn't this and all subsequent patch commits refer to
> > PAGE_SIZE, rather than "4kB?"
> Right, the patch commits should refer to PAGE_SIZE to match with the
> code
> changes.  I am afraid it may be a bit too late to update, though...
> 
> Vishal, do you think you can tweak the logs, "4KB" to "PAGE_SIZE"?
> 
> Thanks,
> -Toshi

Hi Toshi,

Is it just commit message changes? If so I'm not sure it is worthwhile
to rebase everything for that - i.e. my dax error handling series and
Ross' dax-locking branch would both have to be rebased..

If there are and fixes for code, we can do them as an add-on patch
though.

[toc] | [prev] | [next] | [standalone]

#1404664

On Fri, 2016-05-20 at 17:34 +0000, Verma, Vishal L wrote:
> On Fri, 2016-05-20 at 14:50 +0000, Kani, Toshimitsu wrote:
> > On Thu, 2016-05-19 at 18:37 -0500, Eric Sandeen wrote:
> > > On 5/10/16 11:23 AM, Toshi Kani wrote:
> > > > 
> > > > When a partition is not aligned by 4KB, mount -o dax succeeds,
> > >
> > > Sorry for being late, but -
> > > 
> > > Shouldn't this and all subsequent patch commits refer to
> > > PAGE_SIZE, rather than "4kB?"
> >
> > Right, the patch commits should refer to PAGE_SIZE to match with the
> > code changes.  I am afraid it may be a bit too late to update,
> > though...
> > 
> > Vishal, do you think you can tweak the logs, "4KB" to "PAGE_SIZE"?
> > 
> > Thanks,
> > -Toshi
>
> Hi Toshi,
> 
> Is it just commit message changes? If so I'm not sure it is worthwhile
> to rebase everything for that - i.e. my dax error handling series and
> Ross' dax-locking branch would both have to be rebased..
> 
> If there are and fixes for code, we can do them as an add-on patch
> though.

Hi Vishal,

Yes, it is just commit messages, and it's OK not to make this change.

Thanks,
-Toshi

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web