Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1404449 > unrolled thread
| Started by | Ian Abbott <abbotti@mev.co.uk> |
|---|---|
| First post | 2016-05-20 15:50 +0200 |
| Last post | 2016-05-20 19:00 +0200 |
| Articles | 2 on this page of 22 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 00/20] staging: comedi: re-do drivers/plx9080.h Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 15:50 +0200
[PATCH 20/20] staging: comedi: plx9080.h: include headers for declarations Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 16:00 +0200
[PATCH 16/20] staging: comedi: drivers: re-do PLX PCI 9080 DMACSRx register values Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 16:00 +0200
[PATCH 14/20] staging: comedi: drivers: re-do PLX PCI 9080 DMAMODEx register values Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 16:00 +0200
[PATCH 18/20] staging: comedi: plx9080.h: tidy up some comments Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 16:00 +0200
[PATCH 15/20] staging: comedi: drivers: re-do PLX PCI 9080 DMADPRx register values Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 16:00 +0200
[PATCH 13/20] staging: comedi: plx9080.h: add hard-coded PCIHIDR register value Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 16:00 +0200
[PATCH 01/20] staging: comedi: plx9080.h: correct LRNG_IO_MASK and LMAP_IO_MASK Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 16:00 +0200
[PATCH 09/20] staging: comedi: drivers: re-do PLX PCI 9080 DMPBAM register values Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 16:00 +0200
[PATCH 07/20] staging: comedi: drivers: re-do PLX PCI 9080 BIGEND register values Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 16:00 +0200
[PATCH 06/20] staging: comedi: drivers: re-do PLX PCI 9080 MARBR register values Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 16:00 +0200
[PATCH 05/20] staging: comedi: drivers: re-do macros for PLX PCI 9080 LASxBA values Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 16:00 +0200
[PATCH 19/20] staging: comedi: plx9080.h: Add kerneldoc comments Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 16:00 +0200
[PATCH 12/20] staging: comedi: drivers: re-do PLX PCI 9080 CNTRL register values Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 16:00 +0200
[PATCH 10/20] staging: comedi: drivers: re-do PLX PCI 9080 DMCFGA register values Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 16:00 +0200
[PATCH 11/20] staging: comedi: drivers: re-do PLX PCI 9080 INTCSR register values Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 16:00 +0200
[PATCH 17/20] staging: comedi: drivers: add PLX PCI 9080 DMATHR register values Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 16:00 +0200
[PATCH 08/20] staging: comedi: drivers: re-do PLX PCI 9080 LBRDx register values Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 16:00 +0200
[PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 16:00 +0200
RE: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets Hartley Sweeten <HartleyS@visionengravers.com> - 2016-05-20 18:30 +0200
Re: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 18:40 +0200
RE: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets Hartley Sweeten <HartleyS@visionengravers.com> - 2016-05-20 19:00 +0200
Page 2 of 2 — ← Prev page 1 [2]
| From | Ian Abbott <abbotti@mev.co.uk> |
|---|---|
| Date | 2016-05-20 18:40 +0200 |
| Subject | Re: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets |
| Message-ID | <rAVCW-7On-21@gated-at.bofh.it> |
| In reply to | #1404583 |
On 20/05/16 17:21, Hartley Sweeten wrote: > On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote: >> Rename the macros in "plx9080.h" that define the offsets of registers, >> following the pattern `PLX_REG_<NAME>`, where `<NAME>` is the register >> name from the PLX PCI 9080 Data Book. >> >> Add defines for the "Mailbox" registers, and add parameterized macros >> for the mailbox registers and the DMA control registers. Make use of >> the parameterized versions of the macros where it seems appropriate. >> >> The registers for supporting the I2O (Intelligent Input/Output) feature >> are largely left undefined, just defining enough to allow the I2O >> feature to be disabled. >> >> Signed-off-by: Ian Abbott <abbotti@mev.co.uk> > > Ian, > > Just an comment on your renaming. > > You also renamed the registers in the daqbook2000 driver in the > <driver>_REG_<name> format. Personally I prefer the format to be > <driver>_<name>_REG. That way a grep for <driver>_<name> will > return both the register and bit uses. > > Currently the <driver>_REG_<name> form is not as common in comedi. > Looks like it's only used in amcc_35933.h and will be in daqboard2000.c. > > The <driver>_<name>_REG form is used a lot. > > Not a big deal, just a comment. It makes it easier to distinguish the register offsets from the register values, imho. -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=-
[toc] | [prev] | [next] | [standalone]
| From | Hartley Sweeten <HartleyS@visionengravers.com> |
|---|---|
| Date | 2016-05-20 19:00 +0200 |
| Subject | RE: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets |
| Message-ID | <rAVWi-80D-17@gated-at.bofh.it> |
| In reply to | #1404588 |
On Friday, May 20, 2016 9:31 AM, Ian Abbott wrote: > On 20/05/16 17:21, Hartley Sweeten wrote: >> Just an comment on your renaming. >> >> You also renamed the registers in the daqbook2000 driver in the >> <driver>_REG_<name> format. Personally I prefer the format to be >> <driver>_<name>_REG. That way a grep for <driver>_<name> will >> return both the register and bit uses. > > It makes it easier to distinguish the register offsets from the register > values, imho. I guess. It's just not as common in comedi right now and it does make grep'ing for all the register/bit uses a bit more cumbersome. Regards, Hartley
[toc] | [prev] | [standalone]
Page 2 of 2 — ← Prev page 1 [2]
Back to top | Article view | linux.kernel
csiph-web