Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1404153 > unrolled thread
| Started by | Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com> |
|---|---|
| First post | 2016-05-20 08:30 +0200 |
| Last post | 2016-05-20 12:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue in s626.c Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com> - 2016-05-20 08:30 +0200
Re: [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue in s626.c Ian Abbott <abbotti@mev.co.uk> - 2016-05-20 12:20 +0200
| From | Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com> |
|---|---|
| Date | 2016-05-20 08:30 +0200 |
| Subject | [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue in s626.c |
| Message-ID | <rAM6B-1Zw-17@gated-at.bofh.it> |
This is a patch to the s626.c file that fixes up a WARNING: Prefer 'unsigned int' to bare use of 'unsigned' found by the checkpatch.pl tool Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com> --- Changes since V1: - No change --- drivers/staging/comedi/drivers/s626.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c index 723504b..1d663a0 100644 --- a/drivers/staging/comedi/drivers/s626.c +++ b/drivers/staging/comedi/drivers/s626.c @@ -728,7 +728,7 @@ static uint16_t s626_get_mode_a(struct comedi_device *dev, u16 cra; u16 crb; u16 setup; - unsigned cntsrc, clkmult, clkpol, encmode; + unsigned int cntsrc, clkmult, clkpol, encmode; /* Fetch CRA and CRB register images. */ cra = s626_debi_read(dev, S626_LP_CRA(chan)); @@ -783,7 +783,7 @@ static uint16_t s626_get_mode_b(struct comedi_device *dev, u16 cra; u16 crb; u16 setup; - unsigned cntsrc, clkmult, clkpol, encmode; + unsigned int cntsrc, clkmult, clkpol, encmode; /* Fetch CRA and CRB register images. */ cra = s626_debi_read(dev, S626_LP_CRA(chan)); @@ -858,7 +858,7 @@ static void s626_set_mode_a(struct comedi_device *dev, struct s626_private *devpriv = dev->private; u16 cra; u16 crb; - unsigned cntsrc, clkmult, clkpol; + unsigned int cntsrc, clkmult, clkpol; /* Initialize CRA and CRB images. */ /* Preload trigger is passed through. */ @@ -936,7 +936,7 @@ static void s626_set_mode_b(struct comedi_device *dev, struct s626_private *devpriv = dev->private; u16 cra; u16 crb; - unsigned cntsrc, clkmult, clkpol; + unsigned int cntsrc, clkmult, clkpol; /* Initialize CRA and CRB images. */ /* IndexSrc is passed through. */ -- 1.9.1
[toc] | [next] | [standalone]
| From | Ian Abbott <abbotti@mev.co.uk> |
|---|---|
| Date | 2016-05-20 12:20 +0200 |
| Subject | Re: [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue in s626.c |
| Message-ID | <rAPHd-4eE-31@gated-at.bofh.it> |
| In reply to | #1404153 |
On 20/05/16 07:22, Ravishankar Karkala Mallikarjunayya wrote: > This is a patch to the s626.c file that fixes up a > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > found by the checkpatch.pl tool > > Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com> > --- > Changes since V1: > - No change > --- > drivers/staging/comedi/drivers/s626.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Thanks! Reviewed-by: Ian Abbott <abbotti@mev.co.uk> -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=-
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web