Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1402672 > unrolled thread
| Started by | Heinrich Schuchardt <xypron.glpk@gmx.de> |
|---|---|
| First post | 2016-05-18 02:50 +0200 |
| Last post | 2016-05-18 14:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/1] rtlwifi: rtl8192ee: simplify coding Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-05-18 02:50 +0200
Re: [PATCH 1/1] rtlwifi: rtl8192ee: simplify coding Larry Finger <Larry.Finger@lwfinger.net> - 2016-05-18 14:10 +0200
| From | Heinrich Schuchardt <xypron.glpk@gmx.de> |
|---|---|
| Date | 2016-05-18 02:50 +0200 |
| Subject | [PATCH 1/1] rtlwifi: rtl8192ee: simplify coding |
| Message-ID | <rzXQu-3gO-15@gated-at.bofh.it> |
Simplify _rtl92ee_phy_path_adda_on.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c
index 018340a..c2bf8d1 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c
@@ -2414,19 +2414,10 @@ static void _rtl92ee_phy_reload_mac_registers(struct ieee80211_hw *hw,
static void _rtl92ee_phy_path_adda_on(struct ieee80211_hw *hw, u32 *addareg,
bool is_patha_on, bool is2t)
{
- u32 pathon;
u32 i;
- pathon = is_patha_on ? 0x0fc01616 : 0x0fc01616;
- if (!is2t) {
- pathon = 0x0fc01616;
- rtl_set_bbreg(hw, addareg[0], MASKDWORD, 0x0fc01616);
- } else {
- rtl_set_bbreg(hw, addareg[0], MASKDWORD, pathon);
- }
-
- for (i = 1; i < IQK_ADDA_REG_NUM; i++)
- rtl_set_bbreg(hw, addareg[i], MASKDWORD, pathon);
+ for (i = 0; i < IQK_ADDA_REG_NUM; i++)
+ rtl_set_bbreg(hw, addareg[i], MASKDWORD, 0x0fc01616);
}
static void _rtl92ee_phy_mac_setting_calibration(struct ieee80211_hw *hw,
--
2.1.4
[toc] | [next] | [standalone]
| From | Larry Finger <Larry.Finger@lwfinger.net> |
|---|---|
| Date | 2016-05-18 14:10 +0200 |
| Message-ID | <rA8sy-1WF-19@gated-at.bofh.it> |
| In reply to | #1402672 |
On 05/17/2016 07:43 PM, Heinrich Schuchardt wrote:
> Simplify _rtl92ee_phy_path_adda_on.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c
> index 018340a..c2bf8d1 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c
> @@ -2414,19 +2414,10 @@ static void _rtl92ee_phy_reload_mac_registers(struct ieee80211_hw *hw,
> static void _rtl92ee_phy_path_adda_on(struct ieee80211_hw *hw, u32 *addareg,
> bool is_patha_on, bool is2t)
> {
> - u32 pathon;
> u32 i;
>
> - pathon = is_patha_on ? 0x0fc01616 : 0x0fc01616;
> - if (!is2t) {
> - pathon = 0x0fc01616;
> - rtl_set_bbreg(hw, addareg[0], MASKDWORD, 0x0fc01616);
> - } else {
> - rtl_set_bbreg(hw, addareg[0], MASKDWORD, pathon);
> - }
> -
> - for (i = 1; i < IQK_ADDA_REG_NUM; i++)
> - rtl_set_bbreg(hw, addareg[i], MASKDWORD, pathon);
> + for (i = 0; i < IQK_ADDA_REG_NUM; i++)
> + rtl_set_bbreg(hw, addareg[i], MASKDWORD, 0x0fc01616);
> }
>
> static void _rtl92ee_phy_mac_setting_calibration(struct ieee80211_hw *hw,
Initially the thought was that addareg[0] would need to be set differently for
devices with 2 TX paths. For that reason, this routine was coded as shown. As
that assumption is no longer valid, this change should be made.
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web