Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1350748 > unrolled thread
| Started by | Brian Norris <computersforpeace@gmail.com> |
|---|---|
| First post | 2016-03-05 03:30 +0100 |
| Last post | 2016-03-07 10:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v5 09/26] mtd: nand: omap: Clean up device tree support Brian Norris <computersforpeace@gmail.com> - 2016-03-05 03:30 +0100
Re: [PATCH v5 09/26] mtd: nand: omap: Clean up device tree support Roger Quadros <rogerq@ti.com> - 2016-03-07 10:10 +0100
| From | Brian Norris <computersforpeace@gmail.com> |
|---|---|
| Date | 2016-03-05 03:30 +0100 |
| Subject | Re: [PATCH v5 09/26] mtd: nand: omap: Clean up device tree support |
| Message-ID | <r9a8G-7P5-5@gated-at.bofh.it> |
Sorry, another small thing I noticed.
On Fri, Feb 19, 2016 at 11:15:31PM +0200, Roger Quadros wrote:
> Move NAND specific device tree parsing to NAND driver.
>
> The NAND controller node must have a compatible id, register space
> resource and interrupt resource.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
[...]
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 9e99199..0a637c4 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -24,6 +24,7 @@
> #include <linux/slab.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_mtd.h>
>
> #include <linux/mtd/nand_bch.h>
> #include <linux/platform_data/elm.h>
> @@ -177,10 +178,11 @@ struct omap_nand_info {
> struct gpmc_nand_regs reg;
> struct gpmc_nand_ops *ops;
> /* generated at runtime depending on ECC algorithm and layout selected */
^^^ I don't think that comment describes the following line. You
probably meant to delete this one?
> + bool flash_bbt;
> + /* generated at runtime depending on ECC algorithm and layout */
> struct nand_ecclayout oobinfo;
> /* fields specific for BCHx_HW ECC scheme */
> struct device *elm_dev;
> - struct device_node *of_node;
> };
>
> static inline struct omap_nand_info *mtd_to_omap(struct mtd_info *mtd)
[...]
Brian
[toc] | [next] | [standalone]
| From | Roger Quadros <rogerq@ti.com> |
|---|---|
| Date | 2016-03-07 10:10 +0100 |
| Message-ID | <r9ZkS-QT-13@gated-at.bofh.it> |
| In reply to | #1350748 |
On 05/03/16 04:28, Brian Norris wrote:
> Sorry, another small thing I noticed.
>
> On Fri, Feb 19, 2016 at 11:15:31PM +0200, Roger Quadros wrote:
>> Move NAND specific device tree parsing to NAND driver.
>>
>> The NAND controller node must have a compatible id, register space
>> resource and interrupt resource.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
> [...]
>
>> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
>> index 9e99199..0a637c4 100644
>> --- a/drivers/mtd/nand/omap2.c
>> +++ b/drivers/mtd/nand/omap2.c
>> @@ -24,6 +24,7 @@
>> #include <linux/slab.h>
>> #include <linux/of.h>
>> #include <linux/of_device.h>
>> +#include <linux/of_mtd.h>
>>
>> #include <linux/mtd/nand_bch.h>
>> #include <linux/platform_data/elm.h>
>> @@ -177,10 +178,11 @@ struct omap_nand_info {
>> struct gpmc_nand_regs reg;
>> struct gpmc_nand_ops *ops;
>> /* generated at runtime depending on ECC algorithm and layout selected */
>
> ^^^ I don't think that comment describes the following line. You
> probably meant to delete this one?
Yes. I'll remove that. Was my bad on cherry-pick conflict resolution.
>
>> + bool flash_bbt;
>> + /* generated at runtime depending on ECC algorithm and layout */
>> struct nand_ecclayout oobinfo;
>> /* fields specific for BCHx_HW ECC scheme */
>> struct device *elm_dev;
>> - struct device_node *of_node;
>> };
>>
>> static inline struct omap_nand_info *mtd_to_omap(struct mtd_info *mtd)
>
> [...]
>
cheers,
-roger
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web