Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1350949 > unrolled thread
| Started by | "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> |
|---|---|
| First post | 2016-03-05 18:40 +0100 |
| Last post | 2016-03-06 20:40 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] pps: kc: fix non-tickless system config dependency "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2016-03-05 18:40 +0100
Re: [PATCH] pps: kc: fix non-tickless system config dependency Rodolfo Giometti <giometti@enneenne.com> - 2016-03-06 20:40 +0100
| From | "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> |
|---|---|
| Date | 2016-03-05 18:40 +0100 |
| Subject | [PATCH] pps: kc: fix non-tickless system config dependency |
| Message-ID | <r9olj-14L-1@gated-at.bofh.it> |
CONFIG_NO_HZ currently only sets the default value of dynticks config so if PPS kernel consumer needs periodic timer ticks it should depend on !CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ. Otherwise it is possible to enable it even on tickless system which has CONFIG_NO_HZ not set and CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set. Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> --- drivers/pps/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pps/Kconfig b/drivers/pps/Kconfig index 7512e98e9311..564a51abeece 100644 --- a/drivers/pps/Kconfig +++ b/drivers/pps/Kconfig @@ -31,7 +31,7 @@ config PPS_DEBUG config NTP_PPS bool "PPS kernel consumer support" - depends on !NO_HZ + depends on !NO_HZ_COMMON help This option adds support for direct in-kernel time synchronization using an external PPS signal.
[toc] | [next] | [standalone]
| From | Rodolfo Giometti <giometti@enneenne.com> |
|---|---|
| Date | 2016-03-06 20:40 +0100 |
| Message-ID | <r9MH0-Wy-7@gated-at.bofh.it> |
| In reply to | #1350949 |
On Sat, Mar 05, 2016 at 06:37:39PM +0100, Maciej S. Szmigiero wrote: > CONFIG_NO_HZ currently only sets the default value > of dynticks config so if PPS kernel consumer needs > periodic timer ticks it should depend on > !CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ. > > Otherwise it is possible to enable it even on > tickless system which has CONFIG_NO_HZ not set and > CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set. > > Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> It's ok for me. Ciao, Rodolfo -- HCE Engineering e-mail: giometti@hce-engineering.com GNU/Linux Solutions giometti@enneenne.com Linux Device Driver giometti@linux.it Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti Cosino Project - the quick prototyping embedded system - www.cosino.io Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web