Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1351072 > unrolled thread
| Started by | Alexander Kochetkov <al.kochet@gmail.com> |
|---|---|
| First post | 2016-03-06 10:50 +0100 |
| Last post | 2016-03-10 23:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] rtc: hym8563: fix invalid year calculation Alexander Kochetkov <al.kochet@gmail.com> - 2016-03-06 10:50 +0100
Re: [PATCH] rtc: hym8563: fix invalid year calculation Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-03-10 23:50 +0100
| From | Alexander Kochetkov <al.kochet@gmail.com> |
|---|---|
| Date | 2016-03-06 10:50 +0100 |
| Subject | [PATCH] rtc: hym8563: fix invalid year calculation |
| Message-ID | <r9Du1-3bG-1@gated-at.bofh.it> |
Year field must be in BCD format, according to hym8563 datasheet. Due to the bug year 2016 became 2010. Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com> --- drivers/rtc/rtc-hym8563.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c index 097325d..b1b4746 100644 --- a/drivers/rtc/rtc-hym8563.c +++ b/drivers/rtc/rtc-hym8563.c @@ -144,7 +144,7 @@ static int hym8563_rtc_set_time(struct device *dev, struct rtc_time *tm) * it does not seem to carry it over a subsequent write/read. * So we'll limit ourself to 100 years, starting at 2000 for now. */ - buf[6] = tm->tm_year - 100; + buf[6] = bin2bcd(tm->tm_year - 100); /* * CTL1 only contains TEST-mode bits apart from stop, -- 1.7.9.5
[toc] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2016-03-10 23:50 +0100 |
| Message-ID | <rbhz4-59y-9@gated-at.bofh.it> |
| In reply to | #1351072 |
On 06/03/2016 at 12:43:57 +0300, Alexander Kochetkov wrote : > Year field must be in BCD format, according to > hym8563 datasheet. > > Due to the bug year 2016 became 2010. > > Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com> > --- > drivers/rtc/rtc-hym8563.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web