Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1350717 > unrolled thread
| Started by | Dan Williams <dan.j.williams@intel.com> |
|---|---|
| First post | 2016-03-05 01:50 +0100 |
| Last post | 2016-03-07 11:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] mm: ZONE_DEVICE depends on SPARSEMEM_VMEMMAP Dan Williams <dan.j.williams@intel.com> - 2016-03-05 01:50 +0100
Re: [PATCH] mm: ZONE_DEVICE depends on SPARSEMEM_VMEMMAP Vlastimil Babka <vbabka@suse.cz> - 2016-03-07 11:00 +0100
| From | Dan Williams <dan.j.williams@intel.com> |
|---|---|
| Date | 2016-03-05 01:50 +0100 |
| Subject | [PATCH] mm: ZONE_DEVICE depends on SPARSEMEM_VMEMMAP |
| Message-ID | <r98zT-6BN-11@gated-at.bofh.it> |
The primary use case for devm_memremap_pages() is to allocate an memmap array from persistent memory. That capabilty requires vmem_altmap which requires SPARSEMEM_VMEMMAP. Also, without SPARSEMEM_VMEMMAP the addition of ZONE_DEVICE expands ZONES_WIDTH and triggers the: "Unfortunate NUMA and NUMA Balancing config, growing page-frame for last_cpupid." ...warning in mm/memory.c. SPARSEMEM_VMEMMAP=n && ZONE_DEVICE=y is not a configuration we should worry about supporting. Reported-by: Vlastimil Babka <vbabka@suse.cz> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- mm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/Kconfig b/mm/Kconfig index 664fa2416909..b95322ba542b 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -654,6 +654,7 @@ config ZONE_DEVICE bool "Device memory (pmem, etc...) hotplug support" if EXPERT depends on MEMORY_HOTPLUG depends on MEMORY_HOTREMOVE + depends on SPARSEMEM_VMEMMAP depends on X86_64 #arch_add_memory() comprehends device memory help
[toc] | [next] | [standalone]
| From | Vlastimil Babka <vbabka@suse.cz> |
|---|---|
| Date | 2016-03-07 11:00 +0100 |
| Message-ID | <ra07i-1aG-39@gated-at.bofh.it> |
| In reply to | #1350717 |
On 03/05/2016 01:42 AM, Dan Williams wrote: > The primary use case for devm_memremap_pages() is to allocate an > memmap array from persistent memory. That capabilty requires > vmem_altmap which requires SPARSEMEM_VMEMMAP. Some if the ifdefs around to_vmem_altmap() could now be simplified, but that can also be done later... > Also, without SPARSEMEM_VMEMMAP the addition of ZONE_DEVICE expands > ZONES_WIDTH and triggers the: > > "Unfortunate NUMA and NUMA Balancing config, growing page-frame for > last_cpupid." > > ...warning in mm/memory.c. SPARSEMEM_VMEMMAP=n && ZONE_DEVICE=y is not > a configuration we should worry about supporting. > > Reported-by: Vlastimil Babka <vbabka@suse.cz> > Signed-off-by: Dan Williams <dan.j.williams@intel.com> Acked-by: Vlastimil Babka <vbabka@suse.cz> > --- > mm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 664fa2416909..b95322ba542b 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -654,6 +654,7 @@ config ZONE_DEVICE > bool "Device memory (pmem, etc...) hotplug support" if EXPERT > depends on MEMORY_HOTPLUG > depends on MEMORY_HOTREMOVE > + depends on SPARSEMEM_VMEMMAP > depends on X86_64 #arch_add_memory() comprehends device memory > > help >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web