Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1350594 > unrolled thread

Re: [PATCH 4/4] leds: Replace dedicated SN3218 driver with IS31FL32XX driver

Started byStefan Wahren <stefan.wahren@i2se.com>
First post2016-03-04 22:20 +0100
Last post2016-03-05 06:10 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 4/4] leds: Replace dedicated SN3218 driver with  IS31FL32XX driver Stefan Wahren <stefan.wahren@i2se.com> - 2016-03-04 22:20 +0100
    Re: [PATCH 4/4] leds: Replace dedicated SN3218 driver with  IS31FL32XX driver "David Rivshin (Allworx)" <drivshin.allworx@gmail.com> - 2016-03-05 06:10 +0100

#1350594 — Re: [PATCH 4/4] leds: Replace dedicated SN3218 driver with IS31FL32XX driver

FromStefan Wahren <stefan.wahren@i2se.com>
Date2016-03-04 22:20 +0100
SubjectRe: [PATCH 4/4] leds: Replace dedicated SN3218 driver with IS31FL32XX driver
Message-ID<r95iF-4rf-3@gated-at.bofh.it>
Hi David,

> "David Rivshin (Allworx)" <drivshin.allworx@gmail.com> hat am 3. März 2016 um
> 04:01 geschrieben:
>
>
> From: David Rivshin <drivshin@allworx.com>
>
> Si-En Technology was acquired by ISSI in 2011, and it appears that
> the IS31FL3218/IS31FL3216 are just rebranded SN3218/SN3216 devices.
> As the IS31FL32XX driver already handles the *3218 devices, there
> is no longer a need for the dedicated SN3218 driver.
>
> Add the "sn,sn3218" and "sn,sn3216" compatible strings into the
> IS31FL32XX driver and binding documentation, and remove the
> leds-sn3218 driver.
>
> Datasheets:
> IS31FL3218: http://www.issi.com/WW/pdf/31FL3218.pdf
> SN3218: http://www.si-en.com/uploadpdf/s2011517171720.pdf
>
> IS31FL3216: http://www.issi.com/WW/pdf/31FL3216.pdf
> SN3216; http://www.si-en.com/uploadpdf/SN3216201152410148.pdf
>
> Signed-off-by: David Rivshin <drivshin@allworx.com>

i tested this patch successfully with a Raspberry Pi and a PiGlow (SN3218).

Tested-by: Stefan Wahren <stefan.wahren@i2se.com>

[toc] | [next] | [standalone]


#1350803

From"David Rivshin (Allworx)" <drivshin.allworx@gmail.com>
Date2016-03-05 06:10 +0100
Message-ID<r9cDv-1ew-1@gated-at.bofh.it>
In reply to#1350594
On Fri, 4 Mar 2016 22:14:27 +0100 (CET)
Stefan Wahren <stefan.wahren@i2se.com> wrote:

> Hi David,
> 
> > "David Rivshin (Allworx)" <drivshin.allworx@gmail.com> hat am 3. März 2016 um
> > 04:01 geschrieben:
> >
> >
> > From: David Rivshin <drivshin@allworx.com>
> >
> > Si-En Technology was acquired by ISSI in 2011, and it appears that
> > the IS31FL3218/IS31FL3216 are just rebranded SN3218/SN3216 devices.
> > As the IS31FL32XX driver already handles the *3218 devices, there
> > is no longer a need for the dedicated SN3218 driver.
> >
> > Add the "sn,sn3218" and "sn,sn3216" compatible strings into the
> > IS31FL32XX driver and binding documentation, and remove the
> > leds-sn3218 driver.
> >
> > Datasheets:
> > IS31FL3218: http://www.issi.com/WW/pdf/31FL3218.pdf
> > SN3218: http://www.si-en.com/uploadpdf/s2011517171720.pdf
> >
> > IS31FL3216: http://www.issi.com/WW/pdf/31FL3216.pdf
> > SN3216; http://www.si-en.com/uploadpdf/SN3216201152410148.pdf
> >
> > Signed-off-by: David Rivshin <drivshin@allworx.com>  
> 
> i tested this patch successfully with a Raspberry Pi and a PiGlow (SN3218).
> 
> Tested-by: Stefan Wahren <stefan.wahren@i2se.com>

Thanks very much for testing!

The PiGlow looks interesting, if I had known about it I might have just
ordered one for testing myself. Looks rather easier to hook up than the 
ISSI 3216 eval board.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web