Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1348887 > unrolled thread
| Started by | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| First post | 2016-03-03 09:20 +0100 |
| Last post | 2016-03-04 16:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] goldfish: Fix build error of missing ioremap on UM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 09:20 +0100
Re: [PATCH] goldfish: Fix build error of missing ioremap on UM Alan Cox <alan@linux.intel.com> - 2016-03-04 16:50 +0100
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2016-03-03 09:20 +0100 |
| Subject | [PATCH] goldfish: Fix build error of missing ioremap on UM |
| Message-ID | <r8wEl-4cL-65@gated-at.bofh.it> |
Add missing HAS_IOMEM dependency to fix the allyesconfig build error on ARCH=um (for x86_64): drivers/platform/goldfish/pdev_bus.c: In function ‘goldfish_pdev_bus_probe’: drivers/platform/goldfish/pdev_bus.c:191:18: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration] pdev_bus_base = ioremap(pdev_bus_addr, pdev_bus_len); Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> --- drivers/platform/goldfish/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/goldfish/Kconfig b/drivers/platform/goldfish/Kconfig index 50331e3e54f3..fefbb8370da0 100644 --- a/drivers/platform/goldfish/Kconfig +++ b/drivers/platform/goldfish/Kconfig @@ -1,6 +1,7 @@ menuconfig GOLDFISH bool "Platform support for Goldfish virtual devices" depends on X86_32 || X86_64 || ARM || ARM64 || MIPS + depends on HAS_IOMEM ---help--- Say Y here to get to see options for the Goldfish virtual platform. This option alone does not add any kernel code. -- 2.5.0
[toc] | [next] | [standalone]
| From | Alan Cox <alan@linux.intel.com> |
|---|---|
| Date | 2016-03-04 16:50 +0100 |
| Message-ID | <r909j-mc-1@gated-at.bofh.it> |
| In reply to | #1348887 |
On Thu, 2016-03-03 at 17:13 +0900, Krzysztof Kozlowski wrote: > Add missing HAS_IOMEM dependency to fix the allyesconfig build error > on > ARCH=um (for x86_64): > > drivers/platform/goldfish/pdev_bus.c: In function > ‘goldfish_pdev_bus_probe’: > drivers/platform/goldfish/pdev_bus.c:191:18: error: implicit > declaration of function ‘ioremap’ [-Werror=implicit-function > -declaration] > pdev_bus_base = ioremap(pdev_bus_addr, pdev_bus_len); > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Reviewed-by: Alan Cox <alan@linux.intel.com> Thanks for that - I was trying to work out where that weird 0day complaint was coming from. Alan
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web