Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1340802 > unrolled thread

Re: [PATCH 3/4] Remove dl_new

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 3/4] Remove dl_new Peter Zijlstra <peterz@infradead.org> - 2016-02-23 16:50 +0100
    Re: [PATCH 3/4] Remove dl_new luca abeni <luca.abeni@unitn.it> - 2016-02-24 15:00 +0100
      Re: [PATCH 3/4] Remove dl_new Juri Lelli <juri.lelli@arm.com> - 2016-02-25 10:50 +0100
        Re: [PATCH 3/4] Remove dl_new luca abeni <luca.abeni@unitn.it> - 2016-03-03 10:10 +0100
          Re: [PATCH 3/4] Remove dl_new Juri Lelli <juri.lelli@arm.com> - 2016-03-03 10:30 +0100
            Re: [PATCH 3/4] Remove dl_new Steven Rostedt <rostedt@goodmis.org> - 2016-03-03 15:30 +0100
              Re: [PATCH 3/4] Remove dl_new luca abeni <luca.abeni@unitn.it> - 2016-03-03 15:40 +0100
              Re: [PATCH 3/4] Remove dl_new Juri Lelli <juri.lelli@arm.com> - 2016-03-03 17:20 +0100

#1340802 — Re: [PATCH 3/4] Remove dl_new

On Mon, Feb 22, 2016 at 11:57:04AM +0100, Luca Abeni wrote:
> switched_to_dl() can be used instead

This seems unrelated to the other patches, and looks like a nice
cleanup.

[toc] | [next] | [standalone]

#1342041

On Tue, 23 Feb 2016 16:42:49 +0100
Peter Zijlstra <peterz@infradead.org> wrote:

> On Mon, Feb 22, 2016 at 11:57:04AM +0100, Luca Abeni wrote:
> > switched_to_dl() can be used instead
> 
> This seems unrelated to the other patches, and looks like a nice
> cleanup.

Ok; I'll rebase the patch on master and I'll run some more serious
tests (Juri, your tests repository is available on github, right? Can I
assume that if the patch passes your tests then it is ok?).
If everything goes well, I'll submit the patch.


			Thanks,
				Luca

[toc] | [prev] | [next] | [standalone]

#1343038

Hi,

On 24/02/16 14:53, luca abeni wrote:
> On Tue, 23 Feb 2016 16:42:49 +0100
> Peter Zijlstra <peterz@infradead.org> wrote:
> 
> > On Mon, Feb 22, 2016 at 11:57:04AM +0100, Luca Abeni wrote:
> > > switched_to_dl() can be used instead
> > 
> > This seems unrelated to the other patches, and looks like a nice
> > cleanup.
> 
> Ok; I'll rebase the patch on master and I'll run some more serious
> tests (Juri, your tests repository is available on github, right? Can I
> assume that if the patch passes your tests then it is ok?).
> If everything goes well, I'll submit the patch.
> 

Yes, tests reside here https://github.com/jlelli/tests. They should give
you some confidence that things are not completely broken, but of course
they might be still broken and you do not notice by running such tests.
:-)

Please run also the PI related onces, they might be important in this
case.

Anyway, I'd say that, once you are fine with it, you can submit the
patch an then we have a second look at it.

Thanks,

- Juri

[toc] | [prev] | [next] | [standalone]

#1348920

On Thu, 25 Feb 2016 09:46:55 +0000
Juri Lelli <juri.lelli@arm.com> wrote:

> Hi,
> 
> On 24/02/16 14:53, luca abeni wrote:
> > On Tue, 23 Feb 2016 16:42:49 +0100
> > Peter Zijlstra <peterz@infradead.org> wrote:
> > 
> > > On Mon, Feb 22, 2016 at 11:57:04AM +0100, Luca Abeni wrote:
> > > > switched_to_dl() can be used instead
> > > 
> > > This seems unrelated to the other patches, and looks like a nice
> > > cleanup.
> > 
> > Ok; I'll rebase the patch on master and I'll run some more serious
> > tests (Juri, your tests repository is available on github, right?
> > Can I assume that if the patch passes your tests then it is ok?).
> > If everything goes well, I'll submit the patch.
> > 
> 
> Yes, tests reside here https://github.com/jlelli/tests. They should
> give you some confidence that things are not completely broken, but
> of course they might be still broken and you do not notice by running
> such tests. :-)
I am trying these tests, but... Some scripts use "schedtool"; where can
I find a proper version of it (supporting SCHED_DEADLINE)?
I tried https://github.com/scheduler-tools/schedtool-dl but it does not
seem to work correctly...



			Thanks,
				Luca

[toc] | [prev] | [next] | [standalone]

#1348932

Hi Luca,

On 03/03/16 10:03, Luca Abeni wrote:
> On Thu, 25 Feb 2016 09:46:55 +0000
> Juri Lelli <juri.lelli@arm.com> wrote:
> 
> > Hi,
> > 
> > On 24/02/16 14:53, luca abeni wrote:
> > > On Tue, 23 Feb 2016 16:42:49 +0100
> > > Peter Zijlstra <peterz@infradead.org> wrote:
> > > 
> > > > On Mon, Feb 22, 2016 at 11:57:04AM +0100, Luca Abeni wrote:
> > > > > switched_to_dl() can be used instead
> > > > 
> > > > This seems unrelated to the other patches, and looks like a nice
> > > > cleanup.
> > > 
> > > Ok; I'll rebase the patch on master and I'll run some more serious
> > > tests (Juri, your tests repository is available on github, right?
> > > Can I assume that if the patch passes your tests then it is ok?).
> > > If everything goes well, I'll submit the patch.
> > > 
> > 
> > Yes, tests reside here https://github.com/jlelli/tests. They should
> > give you some confidence that things are not completely broken, but
> > of course they might be still broken and you do not notice by running
> > such tests. :-)
> I am trying these tests, but... Some scripts use "schedtool"; where can
> I find a proper version of it (supporting SCHED_DEADLINE)?
> I tried https://github.com/scheduler-tools/schedtool-dl but it does not
> seem to work correctly...
> 

That's the one that I use, and I'm not seeing any problems with it. I'll
send you the binary in private.

Best,

- Juri

[toc] | [prev] | [next] | [standalone]

#1349222

On Thu, 3 Mar 2016 09:28:01 +0000
Juri Lelli <juri.lelli@arm.com> wrote:

> That's the one that I use, and I'm not seeing any problems with it. I'll
> send you the binary in private.

That's the one I use too. BTW, Juri, do you plan on submitting patches
to schedtool upstream?

-- Steve

[toc] | [prev] | [next] | [standalone]

#1349235

Hi Steven,

On Thu, 3 Mar 2016 09:23:44 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 3 Mar 2016 09:28:01 +0000
> Juri Lelli <juri.lelli@arm.com> wrote:
> 
> > That's the one that I use, and I'm not seeing any problems with it.
> > I'll send you the binary in private.
> 
> That's the one I use too.
Juri provided me with a working binary, and I think I found the cause of
the issue: it works fine on 64bit systems, but fails on 32bit systems.
I think the issue is in the sched_setattr() definition present in
syscall_magic.h (which ignores the "flags" parameter).


			Luca

> BTW, Juri, do you plan on submitting patches
> to schedtool upstream?

[toc] | [prev] | [next] | [standalone]

#1349326

Hi Steve,

On 03/03/16 09:23, Steven Rostedt wrote:
> On Thu, 3 Mar 2016 09:28:01 +0000
> Juri Lelli <juri.lelli@arm.com> wrote:
> 
> > That's the one that I use, and I'm not seeing any problems with it. I'll
> > send you the binary in private.
> 
> That's the one I use too. BTW, Juri, do you plan on submitting patches
> to schedtool upstream?
> 

Good point, I should. But I don't have any plans ATM :-/. OTOH, if
anyone else wants to do that I'll be more than happy. :-)

Best,

- Juri

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web