Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1345614 > unrolled thread
| Started by | Wei Ni <wni@nvidia.com> |
|---|---|
| First post | 2016-02-29 11:00 +0100 |
| Last post | 2016-03-03 01:10 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] thermal: tegra_soctherm: fix sign bit of temperature Wei Ni <wni@nvidia.com> - 2016-02-29 11:00 +0100
Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature Wei Ni <wni@nvidia.com> - 2016-03-02 08:50 +0100
Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature Matt Longnecker <mlongnecker@nvidia.com> - 2016-03-03 01:10 +0100
| From | Wei Ni <wni@nvidia.com> |
|---|---|
| Date | 2016-02-29 11:00 +0100 |
| Subject | [PATCH] thermal: tegra_soctherm: fix sign bit of temperature |
| Message-ID | <r7sMr-1iX-33@gated-at.bofh.it> |
The sign bit of temperature readback is bit 0, not bit 1. Change to BIT(0) to fix it. Signed-off-by: Wei Ni <wni@nvidia.com> --- drivers/thermal/tegra_soctherm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c index 74ea5765938b..136975220c92 100644 --- a/drivers/thermal/tegra_soctherm.c +++ b/drivers/thermal/tegra_soctherm.c @@ -57,7 +57,7 @@ #define READBACK_VALUE_MASK 0xff00 #define READBACK_VALUE_SHIFT 8 #define READBACK_ADD_HALF BIT(7) -#define READBACK_NEGATE BIT(1) +#define READBACK_NEGATE BIT(0) #define FUSE_TSENSOR8_CALIB 0x180 #define FUSE_SPARE_REALIGNMENT_REG_0 0x1fc -- 1.9.1
[toc] | [next] | [standalone]
| From | Wei Ni <wni@nvidia.com> |
|---|---|
| Date | 2016-03-02 08:50 +0100 |
| Message-ID | <r89HI-4v3-3@gated-at.bofh.it> |
| In reply to | #1345614 |
Hi, Rui & Thierry & Matt Could you please take a look on this patch. It's a bug on the temperature's sign bit, it can't show the negative temperature, although it will not cause problems for now. Thanks. Wei. On 2016年02月29日 17:51, Wei Ni wrote: > The sign bit of temperature readback is bit 0, not bit 1. > Change to BIT(0) to fix it. > > Signed-off-by: Wei Ni <wni@nvidia.com> > --- > drivers/thermal/tegra_soctherm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c > index 74ea5765938b..136975220c92 100644 > --- a/drivers/thermal/tegra_soctherm.c > +++ b/drivers/thermal/tegra_soctherm.c > @@ -57,7 +57,7 @@ > #define READBACK_VALUE_MASK 0xff00 > #define READBACK_VALUE_SHIFT 8 > #define READBACK_ADD_HALF BIT(7) > -#define READBACK_NEGATE BIT(1) > +#define READBACK_NEGATE BIT(0) > > #define FUSE_TSENSOR8_CALIB 0x180 > #define FUSE_SPARE_REALIGNMENT_REG_0 0x1fc >
[toc] | [prev] | [next] | [standalone]
| From | Matt Longnecker <mlongnecker@nvidia.com> |
|---|---|
| Date | 2016-03-03 01:10 +0100 |
| Message-ID | <r8p05-7eU-5@gated-at.bofh.it> |
| In reply to | #1347825 |
On 03/01/2016 11:40 PM, Wei Ni wrote: > >diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c > >index 74ea5765938b..136975220c92 100644 > >--- a/drivers/thermal/tegra_soctherm.c > >+++ b/drivers/thermal/tegra_soctherm.c > >@@ -57,7 +57,7 @@ > > #define READBACK_VALUE_MASK 0xff00 > > #define READBACK_VALUE_SHIFT 8 > > #define READBACK_ADD_HALF BIT(7) > >-#define READBACK_NEGATE BIT(1) > >+#define READBACK_NEGATE BIT(0) I confirm that this change is technically correct. It fixes a bug.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web